* Re: master a20f4c7ce19 1/2: Fix string used in recent obsolete variables spec
[not found] ` <20241218105414.EA064BA7DD0@vcs3.savannah.gnu.org>
@ 2024-12-19 0:53 ` Stefan Kangas
2024-12-19 9:42 ` Michael Albinus
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Kangas @ 2024-12-19 0:53 UTC (permalink / raw)
To: Michael Albinus, emacs-devel
Michael Albinus via Mailing list for Emacs changes <emacs-diffs@gnu.org>
writes:
> (make-obsolete-variable
> 'font-lock-comment-face
> - "use the quoted symbol instead: \\='font-lock-comment-face" "31.1")
> + "use the quoted symbol instead: 'font-lock-comment-face" "31.1")
With this change, the warning reads:
use the quoted symbol instead: ’font-lock-warning-face
The idea is that it should be valid Lisp, so that users can copy and use
it directly. In other words, it should use a regular ' character:
use the quoted symbol instead: 'font-lock-warning-face
I suggest reverting this patch. Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: master a20f4c7ce19 1/2: Fix string used in recent obsolete variables spec
2024-12-19 0:53 ` master a20f4c7ce19 1/2: Fix string used in recent obsolete variables spec Stefan Kangas
@ 2024-12-19 9:42 ` Michael Albinus
2024-12-19 10:53 ` Stefan Kangas
0 siblings, 1 reply; 3+ messages in thread
From: Michael Albinus @ 2024-12-19 9:42 UTC (permalink / raw)
To: Stefan Kangas; +Cc: emacs-devel
Stefan Kangas <stefankangas@gmail.com> writes:
Hi Stefan,
> Michael Albinus via Mailing list for Emacs changes <emacs-diffs@gnu.org>
> writes:
>
>> (make-obsolete-variable
>> 'font-lock-comment-face
>> - "use the quoted symbol instead: \\='font-lock-comment-face" "31.1")
>> + "use the quoted symbol instead: 'font-lock-comment-face" "31.1")
>
> With this change, the warning reads:
>
> use the quoted symbol instead: ’font-lock-warning-face
When I use emacs -Q, it reads correctly in the *Help* buffer (calling describe-variable)
--8<---------------cut here---------------start------------->8---
use the quoted symbol instead: 'font-lock-warning-face
--8<---------------cut here---------------end--------------->8---
> The idea is that it should be valid Lisp, so that users can copy and use
> it directly. In other words, it should use a regular ' character:
>
> use the quoted symbol instead: 'font-lock-warning-face
>
> I suggest reverting this patch. Thanks.
But then, I see in the *Help* buffer
--8<---------------cut here---------------start------------->8---
use the quoted symbol instead: \='font-lock-warning-face
--8<---------------cut here---------------end--------------->8---
So we must modify help-fns--var-obsolete to use
substitute-command-keys. I've changed it, and I've reverted my
patch. That should be OK then.
Best regards, Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: master a20f4c7ce19 1/2: Fix string used in recent obsolete variables spec
2024-12-19 9:42 ` Michael Albinus
@ 2024-12-19 10:53 ` Stefan Kangas
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Kangas @ 2024-12-19 10:53 UTC (permalink / raw)
To: Michael Albinus; +Cc: emacs-devel
Michael Albinus <Michael.Albinus@gmx.de> writes:
> Stefan Kangas <stefankangas@gmail.com> writes:
>
> But then, I see in the *Help* buffer
>
> --8<---------------cut here---------------start------------->8---
> use the quoted symbol instead: \='font-lock-warning-face
> --8<---------------cut here---------------end--------------->8---
>
> So we must modify help-fns--var-obsolete to use
> substitute-command-keys. I've changed it, and I've reverted my
> patch. That should be OK then.
Ah, nice catch. Thank you!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-19 10:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <173451925070.2703699.10721152312553968487@vcs3.savannah.gnu.org>
[not found] ` <20241218105414.EA064BA7DD0@vcs3.savannah.gnu.org>
2024-12-19 0:53 ` master a20f4c7ce19 1/2: Fix string used in recent obsolete variables spec Stefan Kangas
2024-12-19 9:42 ` Michael Albinus
2024-12-19 10:53 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).