From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master 388a874 2/4: Do interactive mode tagging for man.el Date: Fri, 19 Feb 2021 20:24:49 -0600 Message-ID: References: <8335xs2grn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8546"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 20 03:25:28 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lDHxW-00023C-Dz for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Feb 2021 03:25:26 +0100 Original-Received: from localhost ([::1]:33654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDHxV-00019h-GZ for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Feb 2021 21:25:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDHwz-0000jZ-Mm for emacs-devel@gnu.org; Fri, 19 Feb 2021 21:24:53 -0500 Original-Received: from mail-pg1-f169.google.com ([209.85.215.169]:33732) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lDHwy-000696-09; Fri, 19 Feb 2021 21:24:53 -0500 Original-Received: by mail-pg1-f169.google.com with SMTP id z68so6497928pgz.0; Fri, 19 Feb 2021 18:24:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=2F0GzqMKn0pA4C2vNN3HkOVJpmQxJ5rXMUlLZph4eE8=; b=PkrOZ68uL0LOxm8MgsVjwifImCWmRAkxBpdWAanrmPN6D5wz2ZNSzbVqJlO3+8bNU2 MXVEy0/7GLTWOzmu5KFGRavtQkqXhuBpBDGc/csWxDukGRYlutAQg156khIb0JsKITMW f6MWkod/hwBtjlGstDvAOkOy82fJV+jFqR4svLwZL/hyqP60XSZ4dRSRezFrWEBmSHwR G066Bkgqq5lTicpmMDXc5/d9T7KIZUfdJ8jJuDjy9oTgbI96Kxscf1sijfBEJB8Xgi+F G0IiOeUlHByw7XWQo7ktdMl0dCIQrkULwRT4K3OI/5JDLuNNT8FiPYN8Y7RkwnNVflw1 zZNw== X-Gm-Message-State: AOAM533rxFPljt4POW0PFO+Clh3aITGvLyKcOnmUSTcDGJzbU12jHj3l XWV8a67HivAchrWGFWHEooZwic6ckUBWNMb2378NJPKz X-Google-Smtp-Source: ABdhPJyicQLZoFUTlvPHS6r8WOCC3XUdl0osmXrZQmEv66LlhVOiRCLBtu6wVpnLsMFiTgnTnnrfiWwouh6m1nYyCM8= X-Received: by 2002:a63:e108:: with SMTP id z8mr10822982pgh.363.1613787889662; Fri, 19 Feb 2021 18:24:49 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 19 Feb 2021 20:24:49 -0600 In-Reply-To: <8335xs2grn.fsf@gnu.org> Received-SPF: pass client-ip=209.85.215.169; envelope-from=stefankangas@gmail.com; helo=mail-pg1-f169.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265290 Archived-At: Eli Zaretskii writes: > Stefan, did you consider the fact that woman.el defines a different > mode, but uses some commands from man.el? (I didn't try invoking the > commands you tagged, so maybe there's no problem.) Thanks for catching this. Yes, completion for these commands in Woman is indeed now broken when filtering is enabled. Sorry about that. The problem here is that `woman-mode' uses `man-mode' but does not inherit that mode. Instead, it *calls* `Man-mode' from `woman-mode', with some extra `fset' shenanigans that I don't see a trivial fix for. (This unusual arrangement should probably be fixed at some point...) So if we want to keep the tagging, I see two possible workarounds: 1) Tag the man-mode commands with both `Man-mode' and `woman-mode'. 2) Introduce a new mode, `man-shared-mode', inheriting from special-mode, that both `Man-mode' and `woman-mode' can inherit from. Then tag the commands using that. Both options have their pros and cons. WDYT?