From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master 262d0c6: Mark some tests as expensive Date: Fri, 18 Sep 2020 03:22:54 -0700 Message-ID: References: <20200910182904.20559.25935@vcs0.savannah.gnu.org> <20200910182905.F0E4520A2E@vcs0.savannah.gnu.org> <877dt0is0p.fsf@gmx.de> <87pn6rgtcl.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1582"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 18 12:23:33 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJDYD-0000Hn-E3 for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Sep 2020 12:23:33 +0200 Original-Received: from localhost ([::1]:43210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJDYC-0003B6-ED for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Sep 2020 06:23:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJDXg-0002m5-CA for emacs-devel@gnu.org; Fri, 18 Sep 2020 06:23:00 -0400 Original-Received: from mail-ej1-f48.google.com ([209.85.218.48]:46540) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJDXe-0003SW-67 for emacs-devel@gnu.org; Fri, 18 Sep 2020 06:22:59 -0400 Original-Received: by mail-ej1-f48.google.com with SMTP id z23so7313560ejr.13 for ; Fri, 18 Sep 2020 03:22:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=EB+BTW+itOA8Ok8vrPkF1SzhuFunIIBPkVsUpQECKkA=; b=EefT55TppPXft2QUBm8kZafzmxWsnlFvdZCVB7MvzAEouTOgnrURRjlTyB3zWx+jyh MTmBry7CnecdHctSi+Bwndsb9bKSbnKT3T0fQNZz+zv5cv/KjfejuyvHFyanDeRShgEH 4QsjyGkNU3v8ZkwBqkEFpagpDFN789AXujk7ykM9YP3u4MlQolSmEkRCzwT1Y3g5//q+ QphLjK+rhFfZ8wW/k8hhSwVEJOfmMn6PBv+O/gTwYPSaZpQ8LqfCkUp4T0jE1ZuD/cdk ynwo61LSeF78na+lY4LmUUEH1m/EW7hjKbFKWIy/u8ba4JylEL3ppDpzAJ+QRml5LQ5h 62Jw== X-Gm-Message-State: AOAM533hXvpxWjuUHnS+Rz2PC0m2+154ovz+eVB9JJ5ClgBBkCWbfNNB SiZfoYF3sEEPUoK2eFxAZ6VYzdrUkctBywBr+y0= X-Google-Smtp-Source: ABdhPJwYkc7Ed6EslayUlGFSO4bbQbqUrKsmGVye/rggEl2TgDVg8r5mLmUl96LMXpW3NCu9WcIHw5E+J5wr1YEFDRY= X-Received: by 2002:a17:906:6993:: with SMTP id i19mr33838046ejr.26.1600424575502; Fri, 18 Sep 2020 03:22:55 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 18 Sep 2020 03:22:54 -0700 In-Reply-To: <87pn6rgtcl.fsf@gmx.de> Received-SPF: pass client-ip=209.85.218.48; envelope-from=stefankangas@gmail.com; helo=mail-ej1-f48.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/18 06:22:55 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256070 Archived-At: Michael Albinus writes: > With your change, you have tagged *all* autorevert tests as > :expensive-test. In practice this means, they won't run by default ever, > because people call "make check" only. Any error there, which is not > related to GNU/Linux, will be hidden (hydra and emba run "make > check-expensive", but only for GNU/Linux). > > I don't think this is your intention. Sorry for the delayed reply here. It does seem unfortunate that no tests run for autorevert-mode in the default case. I have a patch in the works that will reduce the running time for these tests, I will send it here when it's done. (Basically the patch would temporarily lower auto-revert-interval, remove sleeps and manually set mtime to lower values than the current time.) > There have been discussions about how long tests shall run. But there > hasn't been ever a conclusion to limit them to 1 second. Please discuss > this first, before making such changes. Sure, I just didn't expect this to be controversial. Sorry if this change caused any problems. Best regards, Stefan Kangas