From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] New package: eldoc-diffstat Date: Sat, 14 Dec 2024 13:24:29 +0000 Message-ID: References: <87y10osimb.fsf@jklaehn.de> <87r06b72oe.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="556"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, Philip Kaludercic To: Tassilo Horn , =?UTF-8?Q?Johann_Kl=C3=A4hn?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 14 14:25:25 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tMS97-000AYV-17 for ged-emacs-devel@m.gmane-mx.org; Sat, 14 Dec 2024 14:25:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tMS8M-0007wS-5X; Sat, 14 Dec 2024 08:24:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMS8J-0007wE-Pw for emacs-devel@gnu.org; Sat, 14 Dec 2024 08:24:36 -0500 Original-Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tMS8H-0004CM-Sj; Sat, 14 Dec 2024 08:24:35 -0500 Original-Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-5d3e829ff44so6813942a12.0; Sat, 14 Dec 2024 05:24:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734182670; x=1734787470; darn=gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=JYMPNUOOupe3ikcfv8Fj361wxxdhblqktbRHEBrwBuc=; b=Q5paOAYoYO4vjVuFtXLr9DqTqo3qEV0qmu6gTY/35nNgEzH/7LqV1EYXfMaS8J8xFR 3LJ9BhOLfHX5wfUxPJ3bt4F3NnZnhsJ+LvFER3YEotRm7CVsvq9VOoGsgg5ITuJABzL1 zUIdaPulRE4s2buWyg/wbgNRrfDOt/5kRpW/iOP31ibvINP254ssC3R8Fgzd2vwfKzFi gDJd265VsbTcswmwKs0KjlUqeGRp3k8VIoVaf7yWILK0sAEElz3Fwv1NQ6g71uHvxl9G mwRddU/9F1zsgwTHT1dYYRNL0KXY9EfJL8gMdrbl4OYcABqnjeV79Aaecb3LFrZx6x5L Xl5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734182670; x=1734787470; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JYMPNUOOupe3ikcfv8Fj361wxxdhblqktbRHEBrwBuc=; b=S6M5qDJiR7aj52Vb3WTGjU248oITRdGlYmVUbRAAJXgxnNn9kKelFl6HyCNxvFXCa2 0k8qfQy6AUBLVeu69Tw+mmRTE0jrRAKuu/K4cuDIXTv6baL4xZ2X33kShbM25NgsFIpp f5hdo1pZwqCLVilK4wOFmUyrkyF+t0ESLwv3lTDv12dZmgJY+HIuCE4VWi0KL7oF+JqJ QcbPzzsGwMfNyHnLTf6YeHZ+k2Fe2931U531lMdAOHg8FOs6aX5C6hN/S/uYhWL52ZHR jzfVutRQJU5s00c+0rjnr5sYKsT2pCqVHuJr1sza/H1XfFaJDDIHVPTByZ45QtbPRt1n Rgmw== X-Gm-Message-State: AOJu0YwnlcWSSghxPahoxU7zN6siUTYygBIHSN9NgtzpFW5KSDaYH2Lz JIpB+4CbSoUTgu4WKLXwVVl1UQgDXFkKw/SRYLDfFYaYtL7x5WiwJVR+2OkBOpSUKYEBms1u5Kr tF8u1WwMYxc/kvxHnaM95SKR/uROnfMiA X-Gm-Gg: ASbGnct53UEyrshHc/IShbB9PNiunqcyydRpoQ20pyto/I+4b6/t7ugyrRBqd3AkZaM yRBEQudwS2ppXUc6U9L9voRWo4ofAsP1wYb2Gv7k= X-Google-Smtp-Source: AGHT+IEdFuDyn7JmZYhoi3JpwvApm6a/80P+/UdxIgDsLwU4wj87r7cVdOe7ie936nwSWOTJ9ro8AEY4tDeMmrk4nCs= X-Received: by 2002:a05:6402:3228:b0:5d0:9c3b:faf4 with SMTP id 4fb4d7f45d1cf-5d63c2277eamr6220831a12.7.1734182670042; Sat, 14 Dec 2024 05:24:30 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 14 Dec 2024 13:24:29 +0000 In-Reply-To: <87r06b72oe.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::52b; envelope-from=stefankangas@gmail.com; helo=mail-ed1-x52b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326486 Archived-At: Tassilo Horn writes: >> I would like to submit a new package to NonGNU ELPA: eldoc-diffstat. >> >> https://github.com/kljohann/eldoc-diffstat/ > > I'm using it since a couple of days using package-vc and like it very > much, so I took the liberty to add it to NonGNU ELPA. Thanks, this seems pretty useful. I can see myself wanting to have it on sometimes, but not always, so I'd appreciate it being a minor mode that I could toggle, instead of just a function. When the mode is toggled on, it could detect automatically that it's in a magit buffer, and do the `eldoc-add-command` setup for users automatically. Should we have something like this built-in? Here are some more wishlist items: - An option to use a maximum (or fixed) number of lines - Caching the results for the current buffer to get instant results > I think you could add a bit more configuration hints to the README.md, > e.g., where you say that one should call eldoc-diffstat-setup in the > desired buffer or mode hook, provide some typical examples like: > > (add-hook 'log-view-mode-hook #'eldoc-diffstat-setup) > (add-hook 'vc-annotate-mode-hook #'eldoc-diffstat-setup) > (add-hook 'magit-status-mode-hook #'eldoc-diffstat-setup) > (add-hook 'magit-log-mode-hook #'eldoc-diffstat-setup) +1 There could also be a global minor mode that would enable this in as many places as possible.