From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] main 823df3487e: * elpa-packages (pacmacs): New package Date: Sat, 8 Jan 2022 11:45:59 -0600 Message-ID: References: <164152114379.3954.5573277592787205027@vcs2.savannah.gnu.org> <20220107020544.0DE37C0DA1A@vcs2.savannah.gnu.org> <87czl25g9s.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17468"; mail-complaints-to="usenet@ciao.gmane.io" To: Philip Kaludercic , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 08 18:47:00 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n6Fnu-0004Co-JZ for ged-emacs-devel@m.gmane-mx.org; Sat, 08 Jan 2022 18:46:58 +0100 Original-Received: from localhost ([::1]:59734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n6Fnt-0004CY-Jf for ged-emacs-devel@m.gmane-mx.org; Sat, 08 Jan 2022 12:46:57 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6Fn4-0003Pz-Qa for emacs-devel@gnu.org; Sat, 08 Jan 2022 12:46:06 -0500 Original-Received: from mail-pj1-f44.google.com ([209.85.216.44]:50772) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n6Fn0-0007p5-3z for emacs-devel@gnu.org; Sat, 08 Jan 2022 12:46:06 -0500 Original-Received: by mail-pj1-f44.google.com with SMTP id pf13so414417pjb.0 for ; Sat, 08 Jan 2022 09:46:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to; bh=w49MMh5XkE20zPR6vdJ3Upor8hQg0Bqi2RgzZnHYEnM=; b=kstPyKxWiz2FxV1T2qO+yhbPzBvyKl8yjxFQ6Cox3XVLZzE/z8otbOaixsNwBFXdNM 6+csbeysYajQ3u16b5b7/xGQHeAi78EzYFxXspblnjv5qSQEbweFgQ9513V5mskQcbNN G8iJc6o70xd36zfCPF5t4kWvqzNUYCzJXKaGmrtJROH7oa+WtRDLPXvWeb/X+XuSS0L/ 93+B35el4A+NucpxVsC9IL5tbwNLDDs7EcqtJvDE/FabfuY8eyuGOt6Tp1ji2eRZnrwi rWySfqqOwe2CnOiydayz0dlup+EL8aU0CSYgEsrkHGGC73/FXvUw5rnCxXfwwlCllMKw z6VQ== X-Gm-Message-State: AOAM5325QRSYScykj3ihZr1jXJt4ZNqJKySqpfKoTgE5THpA6W45ciuV kxr33wDpFUKmvXK/uLkd+5LI9gXPCSV3lHWb3FY= X-Google-Smtp-Source: ABdhPJxTu9H0abjNCxxIpIqmSirtxKNHp3TvcSaW7fWDSibrAbKGMN+M5ekNMYdfGDcoCiIVxyBrglwdF8H+ICBDWCc= X-Received: by 2002:a63:8c47:: with SMTP id q7mr5963756pgn.591.1641663960020; Sat, 08 Jan 2022 09:46:00 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 8 Jan 2022 11:45:59 -0600 In-Reply-To: <87czl25g9s.fsf@posteo.net> Received-SPF: pass client-ip=209.85.216.44; envelope-from=stefankangas@gmail.com; helo=mail-pj1-f44.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284480 Archived-At: Philip Kaludercic writes: > Stefan Kangas writes: > >> branch: main >> commit 823df3487e89663484191ff5b23b327468efb683 >> Author: Stefan Kangas >> Commit: Stefan Kangas >> >> * elpa-packages (pacmacs): New package > > This package appears to depend on f.el. The dependency or the package > should be removed so that the package isn't marked as incompatible. Ouch. > It shouldn't be hard, if this quick grep is right: > > --8<---------------cut here---------------start------------->8--- > viero$ grep -r -F '(f-' > tools/pacmacs-rr.el: (-> (f-read-text filename) > tools/compile.el: (and (f-file? path) > tools/compile.el: (f-ext? path "el")))) > tools/att.el: (f-write (format "Average Tick Time: %fms" (pacmacs--average-tick-time)) > pacmacs-score.el: (f-read-text) > Binary file .git/objects/pack/pack-f85e046b5df6f330c64cf410e834049e8504c417.pack matches > pacmacs.el: (let* ((lines (split-string (f-read-text map-file-name) > --8<---------------cut here---------------end--------------->8--- > > Ie. two invocations of f-read-text. I'll look into it, thanks. I find that dependencies on s.el and f.el are sometimes trivial to remove, but in some cases their functions have subtly different behavior from the built-in functions that makes it hard to be sure that you're not introducing bugs in the process. See e.g. https://github.com/org-roam/org-roam/pull/2025