From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: ELPA: add lin.el Date: Fri, 5 Nov 2021 13:28:04 -0700 Message-ID: References: <871r3uv1tk.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40485"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Nicolas De Jaeghere To: Protesilaos Stavrou , emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 05 21:28:57 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mj5pW-000A9o-MM for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Nov 2021 21:28:54 +0100 Original-Received: from localhost ([::1]:42814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mj5pV-0005hh-H4 for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Nov 2021 16:28:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mj5om-00050v-Hl for emacs-devel@gnu.org; Fri, 05 Nov 2021 16:28:08 -0400 Original-Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:44824) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mj5ok-0003LX-O1 for emacs-devel@gnu.org; Fri, 05 Nov 2021 16:28:08 -0400 Original-Received: by mail-pl1-x62a.google.com with SMTP id t11so11714481plq.11 for ; Fri, 05 Nov 2021 13:28:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=249oVLcFsh5Gaz9+teVXCqY3W8vwAVXbdveR0AFVQ8A=; b=BWwV+OLn65qO63SHjEeMoPYczpFihlWLT8akIGHyYyVIuoPAJUF99cwRANfx4uqzPT ctKeeoeQjlypE/gH3Tb1/dd7jeAvb1N5mLe86WsaS7OOwEWviCY5Q4O5yLR4mjHoWSiD u4O6T4a/ZvU3D84pt31smEj2qPtj+IAjBOW0NhzoUTdPPkW2D6FnpoQZISezzu8t3Wt1 up7bVmu1OaUvv0XmktrO9D7eHDDmfAco0qQi5XlXxLTvyuygQJvrvau1rNqS6xsT1nb4 ja9uTIsUGSk3fAP45f2zPHmUmZwZcPYXYualfr7z7KDa3jYqP9oYI12d/rSYNGBN9R1W WuZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=249oVLcFsh5Gaz9+teVXCqY3W8vwAVXbdveR0AFVQ8A=; b=jSvwKWaemvQGaGzTQTHwPiKQRyrciKLy3aNSnljGa+bB45vzJPCJ8w6DGxv1QNawvE AEMseh1LPYZgnFrzWOaIJWStwUffkceeRwojUz7G6BRs6sDHokq2GA9eUa2zBDV9TP+R DDvvA7ShylLf1fHtzP2T9PTgZvVVwPVsbGcMBDKn3XnjC1eVV/35RuVbW0oHzVpKndEe jBVz++ds+WRM0LG2PBp1qnfEj7wVsypAVYanwq9SiVA8SFvS+JZmVCY2obyS8SeU12Ev fFd7A7V8muScma4DiSw91c+gK+gg/WlHoVdO6NdVFOuGI/rd9lGmVvnQnymJlOeYzQXD rDiw== X-Gm-Message-State: AOAM5335EeDqG1L4Ll1oXSca7r+GILxKBDgdDihpi2nfORg9hLkcyqBC ptmbznczAPcz89GhLCKj4fEDRSBphPzYjP7LYNuwl8JU X-Google-Smtp-Source: ABdhPJxU+J3HnWKgKo8EB1848kR3z0Y73wazjRDiO4t+ZkR7Xos48r2UbmjGb4QD3pj1/P6Y/1Ol3LyDPMvc2OFa9N4= X-Received: by 2002:a17:90a:4414:: with SMTP id s20mr29564470pjg.132.1636144084871; Fri, 05 Nov 2021 13:28:04 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 5 Nov 2021 13:28:04 -0700 In-Reply-To: <871r3uv1tk.fsf@protesilaos.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=stefankangas@gmail.com; helo=mail-pl1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:278808 Archived-At: Hi Protesilaos, Protesilaos Stavrou writes: > The user can enable 'lin-mode' in select major modes to have a more > intense (or just different) style for the highlighted line of > 'hl-line-mode', without compromising the utility of the 'hl-line' face > in all other buffers. This looks useful, thanks. My question is: why make it into a third-party package instead of a patch against hl-line.el? I imagine that we could introduce a new permanently local defvar that users (or even mode developers?) could set in individual modes. If that variable is non-nil, these faces are used instead of the default ones. We could also have a defcustom that disables this completely (I think it should be on by default, but we can bikeshed that later). We could also just include the mode of course, if we think that's the better interface. I sort of like the variables, as that allows modes to "register" themselves as interesting for this purpose, and the user to completely disable the functionality if they don't like it by setting a defcustom. (Instead of all users having tons of mode-hooks in their configuration for each and every little mode where this could make sense.) What do you think? Best regards, Stefan Kangas