From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master c669afc: Add term/st.el (Bug#33182) Date: Mon, 10 Aug 2020 16:08:01 -0700 Message-ID: References: <20200810123101.2196.88424@vcs0.savannah.gnu.org> <20200810123102.E3F8420CB8@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25631"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 11 01:08:51 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5GuQ-0006c1-70 for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Aug 2020 01:08:50 +0200 Original-Received: from localhost ([::1]:57268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5GuP-00036C-9f for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Aug 2020 19:08:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5Gtg-0002OY-QL for emacs-devel@gnu.org; Mon, 10 Aug 2020 19:08:04 -0400 Original-Received: from mail-yb1-xb2b.google.com ([2607:f8b0:4864:20::b2b]:34997) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k5Gtf-0002Iu-3N for emacs-devel@gnu.org; Mon, 10 Aug 2020 19:08:04 -0400 Original-Received: by mail-yb1-xb2b.google.com with SMTP id y134so6042195yby.2 for ; Mon, 10 Aug 2020 16:08:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to; bh=i80wZunY0RncLF75/a0yC6vv3GlsAv1XcqtnoPhYzlg=; b=Mk5X2/Q2jf/RA8TBhnZWo7YObHyXX3cEmWxkommHpM4p2eSV1I+xTGo4Jf6NgX3s8F nN6KEfUEyH1oK0jd1H6wHd+E4RcTzOBt2iQU3dgVNR+pE+tFCGlXQnemzUYGqja9cUTR GFgZMSi86ANZzGKLtvvuzmObR/ih1n6kXqDRAeu9iSpTW1Wnzd6aNJmZBGUBt5+l6eUC 8agxvRaNyeYJbLUeJ5f/jlYrDiY7S3ewlBOK6ZCQDB+DL+cqLP3JUfHCjnZP5n3P2dRe 0D3mNeBE/2ZCqFay0LzoDp0P2r/IeX+AhhI6UMZR9b2tmTCp+MoNMP9+CwTdSN8MB0kB Cm1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to; bh=i80wZunY0RncLF75/a0yC6vv3GlsAv1XcqtnoPhYzlg=; b=ZH8tuonqJQjJDrpi4HIv3wyslpm4klD7wKKEh9F19CIMsm9mPomFGOPhlgKEviU5EX HWS7TS4IaXGIU2VK8k2j0fUUjTpGaQ9ya1wgxa9ugq8ILEV54O7GLx3bdX0aU4v/JzXJ 2LJnPihpT9bfSNzuEaOWK2to/EpLoeNIoWh9gIE0Tqg1FFrx+Xc3YEx9MtzDCY1dl3lh Qqr1ZsQMUGj6ZZhXjFmiLT8QBlwLkMGacgq5agPAEGVFpWxXDANRLbwvUV2R/NQQmy+M NL8KG9M+fBw6Ytrdg8lxS/tWYCg01TMrM7+mUf4P1Uvah3uxy9icEvJIuW0CYTDwdGiV bo/g== X-Gm-Message-State: AOAM533na5GuLlLEp0+crrLok6iEkFyE7Ef6uMnBVRE++WkEfkBFkEi+ LNbIF6bud1kF8lV6i1/df9iZZIHgBWT9WQrFnD9QtvO0RF4= X-Google-Smtp-Source: ABdhPJzY16dgu4JzWBcrmjXAoyjdkisKHzA6cTVy/1hGXj3m0baHbHTuTb6VCY8tD++VHg7tNC4J44SzDicmELi650Y= X-Received: by 2002:a5b:410:: with SMTP id m16mr42956488ybp.309.1597100881668; Mon, 10 Aug 2020 16:08:01 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 10 Aug 2020 16:08:01 -0700 In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::b2b; envelope-from=stefankangas@gmail.com; helo=mail-yb1-xb2b.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253610 Archived-At: Stefan Monnier writes: >> +;;; st.el --- terminal initialization for st -*- lexical-binding:t -*- >> +;; Copyright (C) 2020 Free Software Foundation, Inc. >> + >> +(require 'term/xterm) >> + >> +(defun terminal-init-st () >> + "Terminal initialization function for st." >> + (tty-run-terminal-initialization (selected-frame) "xterm")) > > Could you add the customary `;;; Code:` and more importantly some > information (description and/or URL) of what is `st`? Why not, but several files in lisp/term are lacking such headers. Including lisp/term/konsole.el which I based this addition on. I had assumed that there was some reason for that (e.g. they are too insignificant). If there isn't, should we then add these headers to the rest of them too? And if yes, should we add all the verbiage, or just parts of it? It seems like many are currently lacking the GPL notice, for example. Best regards, Stefan Kangas