From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Yikes! easy-menu-add is suddenly compiled to `ignore', without any warning. Date: Wed, 7 Apr 2021 07:43:01 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28582"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 07 14:44:31 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lU7Xr-0007Im-A0 for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Apr 2021 14:44:31 +0200 Original-Received: from localhost ([::1]:48680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lU7Xq-000834-B2 for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Apr 2021 08:44:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lU7WT-0007aH-4G for emacs-devel@gnu.org; Wed, 07 Apr 2021 08:43:05 -0400 Original-Received: from mail-pl1-f177.google.com ([209.85.214.177]:35680) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lU7WR-0001cj-9a for emacs-devel@gnu.org; Wed, 07 Apr 2021 08:43:04 -0400 Original-Received: by mail-pl1-f177.google.com with SMTP id j7so4588671plx.2 for ; Wed, 07 Apr 2021 05:43:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=jGhZ51up8GZHwJ9Vy78Fp4eUSs0t3CxEYRZNZ39/lVc=; b=ernfKWJKQZobLUcA1Ht37xnnQW7Tchm8PzmlEG5lYEHOOH0i7DF9MdPIuEiFruuSFf jhUrpqdvf6ESUq/7VGcwT1W5zZhG1uCMxOvfI+V0DgHknOilAmjrZ9l0bf4HIzf6xC0k KjO/V7uqLuVrGcZv9INlyUAxf6BzjfIYTOuLNBvJ6PyjQSUW3XGMH+xuqYgJwkpgY4GT vj+svcIbk43cLKwCV3z9wdvfoD6iOItRDbmBKO0O+QndlW/3tETl2+uV186Rv3cpuC/I 3pkgQQfNrB2CrxNsIStFVFyd3pdzjsP9vsh0o7/VRhOCWahSivSVmrtF3OzWKTvUVtCF q+vQ== X-Gm-Message-State: AOAM530sf47gfxWOAnkyoA7jSJcPzHNCtftnDmZquuJHWyrGlnlNItqU dmKmNTPN7IhbB/Ly6cYrROgyzbV3mxoL6k8sKVUG+k5q X-Google-Smtp-Source: ABdhPJwChzYP6rJHa4MPu94LEo72dt0cNRksaSjFzvZGCQu7YHgWVGJ6Sx4Cp0E1nbnkv76/6Gx9zvl1Cb8C3ViRX3w= X-Received: by 2002:a17:90a:ac08:: with SMTP id o8mr3132501pjq.175.1617799381616; Wed, 07 Apr 2021 05:43:01 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 7 Apr 2021 07:43:01 -0500 In-Reply-To: Received-SPF: pass client-ip=209.85.214.177; envelope-from=stefankangas@gmail.com; helo=mail-pl1-f177.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267512 Archived-At: Hi Alan, Alan Mackenzie writes: > First of all, sorry for being so strident in my opening post. I now > understand what's happening. No worries, I'm just happy we could clarify the situation. I think this is just an example of the kind of confusion that these compatibility shims can sometimes cause. >> > The warning message Emacs 28.1 gives out is particularly unfriendly and >> > unhelpful. It looks like this: > >> > cc-mode.el:2591:4: Warning: `easy-menu-add' is an obsolete function >> > (as of 28.1); use `ignore' instead. > >> Yes, we could improve that message. > >> Perhaps it could say: "it is not needed, so just remove it". > > Maybe it could say something like "which was always a no-op in Emacs", > thus reassuring maintainers that they needn't worry about lost menu > functionality. I have now done this on master (commit 43984d72b0). Feel free to tweak the message if you see a way to make it even more clear.