From: Stefan Kangas <stefankangas@gmail.com>
To: Po Lu <luangruo@yahoo.com>, Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org, dev@rjt.dev
Subject: Re: emacs-29 1ef8b90ae06: Simplify imenu setup for {cmake, dockerfile}-ts-modes
Date: Sat, 27 Jan 2024 14:40:02 -0800 [thread overview]
Message-ID: <CADwFkmm7oFrX-6uyrq-L5AS9OX0dEGyQRS6Uc5+yADkbk55h3Q@mail.gmail.com> (raw)
In-Reply-To: <875xzfkxq7.fsf@yahoo.com>
Po Lu <luangruo@yahoo.com> writes:
> Yes, please. Furthermore, if such bugfix cannot be described as
> anything but a simplification (with a correspondingly large diff), there
> should be another approach safer for the release branch.
We must not get overly rigid about that. It takes extra work, and it
will not always be clear that it's worth the effort. Often it is, but
sometimes it isn't. We tend to decide on a case-by-case basis.
Furthermore, please keep in mind that Yuan is both the principal author
and maintainer of our treesitter support. He's closer to the code than
anyone else, and is thus in the best position to make such judgement
calls. I see no reason to second-guess him here, myself.
If there are any specific technical arguments for why this particular
change must not be installed on emacs-29, then let's hear them. Neither
generalizations nor administrative arguments will cut it, I think.
> Our basic criterion for installing patches on emacs-29 is not whether a
> change contains a bugfix, but whether it runs a risk of destablizing the
> branch. It is more important that a bugfix be the only component of a
> change, since that reduces the probability of unanticipated disruption.
(Speaking here as the co-maintainer of GNU Emacs, responsible for
leading Emacs development together with Eli.)
The above does not necessarily reflect the official line of the project.
It is true that we have preferred to avoid bug fixes that might risk
destabilizing the branch, but this has usually been applied in an ad-hoc
and not in a rigid fashion. I'm not myself prepared to commit to much
more rigid guidelines at this point.
On a personal note, if we believe that some changed guidelines are
necessary, I'd probably be more inclined to make things more relaxed
rather than more strict. But please note that I'm _not_ proposing to
open a discussion about that at the present time.
next prev parent reply other threads:[~2024-01-27 22:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <170633049046.30614.86278647904102476@vcs2.savannah.gnu.org>
[not found] ` <20240127044130.C6F37C4068B@vcs2.savannah.gnu.org>
2024-01-27 4:59 ` emacs-29 1ef8b90ae06: Simplify imenu setup for {cmake, dockerfile}-ts-modes Po Lu
2024-01-27 7:35 ` Eli Zaretskii
2024-01-27 8:05 ` Po Lu
2024-01-27 22:40 ` Stefan Kangas [this message]
2024-01-28 1:34 ` Po Lu
2024-01-28 3:00 ` Stefan Kangas
2024-01-28 5:21 ` Po Lu
2024-01-28 3:29 ` Dmitry Gutov
2024-01-28 5:57 ` Eli Zaretskii
2024-01-31 6:44 ` Yuan Fu
2024-01-27 8:37 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmm7oFrX-6uyrq-L5AS9OX0dEGyQRS6Uc5+yADkbk55h3Q@mail.gmail.com \
--to=stefankangas@gmail.com \
--cc=dev@rjt.dev \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).