From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Initial fontification in sh-mode with tree-sittter Date: Thu, 27 Oct 2022 17:18:58 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26045"; mail-complaints-to="usenet@ciao.gmane.io" To: =?UTF-8?Q?Jo=C3=A3o_Paulo_Labegalini_de_Carvalho?= , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 28 02:21:09 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooD7S-0006b3-Uz for ged-emacs-devel@m.gmane-mx.org; Fri, 28 Oct 2022 02:21:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooD5T-0001Vt-LQ; Thu, 27 Oct 2022 20:19:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooD5S-0001Vm-GC for emacs-devel@gnu.org; Thu, 27 Oct 2022 20:19:02 -0400 Original-Received: from mail-oa1-x36.google.com ([2001:4860:4864:20::36]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ooD5Q-00055R-UA for emacs-devel@gnu.org; Thu, 27 Oct 2022 20:19:02 -0400 Original-Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-13bef14ea06so4620868fac.3 for ; Thu, 27 Oct 2022 17:19:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:from:to:cc:subject:date:message-id :reply-to; bh=wUf7c7rAi7T8FsgA4DGR/yd1jhNQI3bK0edjIezJgTI=; b=DaIqGmzxpN200CAP5iK2S16Jq1jC3MEmRnXe4BHSnQi66wAxSSLlHMy+C48qEEDDkI 9S2vnmGXRsrtoRVcubSmZMIEoYv5LX4KoKq9Hwxnl1tZ49FZqwUlqiRqfKKe0zsuNHKV 2kPvfaQQj7UZAn697/YHmrQAImEWcBChY/8sHHmO6iGIwM2q3S99tHPGJRQnk47ha5je P5HbX0AdrGI3Loaxj43JqEbWsCb8qw9DtB89cc2p8fu+REpVWTRviSnS0k2sZWSLkbp1 lCn5+FO5T7hf0AuPaGjqwvbb5pX4H5mYcNp9AQhcsctdFuyqCwyRyo7vOoMtWWM4wJOI MDxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=wUf7c7rAi7T8FsgA4DGR/yd1jhNQI3bK0edjIezJgTI=; b=UuDqRmdWU9brIYkqDOQs+d2Z9e0ri0XpY/iWtFZoRRLMwZOO2Gl2gR+CjGvuEg0ksB MCrGFsQeRTiKdHlFyGMfZpR8Cf8HE+PAdsRqMtkB1hpwJfAJtgoS1D+HZpJQcrQZ3Yjj 5jGXkjUyKyD5FaIMqXrc9ESR3gDuJ2Vihb3Kd0eaRC5OQ1Z/okzrTm+LuvLYe9AfLi71 iDYmSM8xp0n6+ClsvnOGzRWusMwZMrpM0pBLShfupPQEmJAoQp0MU68TX2xqvAh+5gTF DmwwnJwV0sQUxs+CcebeQ1Isyf3odvVGeszPazMvEjXMAECSluhVJVdBURyT/9Kv1F5V cVmQ== X-Gm-Message-State: ACrzQf1hyZYSF7q/PKjSaSyPfycEzRZBpHiVPsQKcdbZkpACS7IToDfg D/BAouwm7CH2MCCAlwNgXh0cygbpICs2RdH93SM= X-Google-Smtp-Source: AMsMyM5T9awHmxc4oHUJTlhrTyWB1/wOweQFVvhI4GMqYEa+WEEPpLtA1uGMUHQ6+DVMyp1d60Xm2H7YyAiz2qB+Hs0= X-Received: by 2002:a05:6870:c0d5:b0:13a:fb98:713d with SMTP id e21-20020a056870c0d500b0013afb98713dmr7228351oad.199.1666916339620; Thu, 27 Oct 2022 17:18:59 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 27 Oct 2022 17:18:58 -0700 In-Reply-To: X-Hashcash: 1:20:221028:jaopaulolc@gmail.com::cWAB53LiMrHTdq0N:1Uw2 Received-SPF: pass client-ip=2001:4860:4864:20::36; envelope-from=stefankangas@gmail.com; helo=mail-oa1-x36.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298648 Archived-At: Jo=C3=A3o Paulo Labegalini de Carvalho writes: > +(defface sh-mode--treesit-special-var-name-face > + '((t (:inherit font-lock-builtin-face))) > + "Face name to use for special `sh-mode' variables (e.g. PATH)") > + > +(defface sh-mode--treesit-operator-face > + '((t (:inherit font-lock-builtin-face))) > + "Face name to use for `sh-mode' operators (e.g. <<)") > + > +(defface sh-mode--treesit-call-face > + '((t (:inherit font-lock-function-name-face))) > + "Face name to use for `sh-mode' non-builtin command calls") Are those faces really needed? Is it not enough with just the font-lock-* faces we already have? If the answer is that we do need them, should they really be marked private? I thought the point of a face was allowing users and themes to customize them.