From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master 050b830 3/3: Do interactive mode tagging for finder.el Date: Fri, 19 Mar 2021 11:23:25 -0500 Message-ID: References: <83zgyzeezu.fsf@gnu.org> <87eegbo8db.fsf@gnus.org> <83v99nedze.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29424"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii , Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 19 17:24:21 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNHvA-0007Y2-MU for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Mar 2021 17:24:20 +0100 Original-Received: from localhost ([::1]:50316 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNHv9-0007MY-L5 for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Mar 2021 12:24:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNHuM-0006YZ-Da for emacs-devel@gnu.org; Fri, 19 Mar 2021 12:23:30 -0400 Original-Received: from mail-pl1-f181.google.com ([209.85.214.181]:34631) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lNHuK-0005kF-Py; Fri, 19 Mar 2021 12:23:30 -0400 Original-Received: by mail-pl1-f181.google.com with SMTP id o2so3194696plg.1; Fri, 19 Mar 2021 09:23:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=Y8+x+4nWoLG3GE8vi1EkoPCe6btYo2x3JMA6OyydfVk=; b=HJ4zn0k0FbpV4bDdgzcQU7uYWZG+v9gZCbiRbTQiBvtV6/+1RQTlXV8lD92dIupKrY Ws4J2md+M9F1a4MG5VFR1loLAFGuh79GBtK9xZuSfI50148VFhh+tALTy8KzdYtGOF6S EyA0qyewyZImN7LaRjRh8/r6BH/eh53b5WA7rw2YHfrXqpH+RelTpPwv+81mhOb9vmnd LLaT2BjqxLhwDYTpat9sV3jePUFiwfA6VzSYGJTEQ2hTgmlZJYVTaSl+WybW1xXxS6s7 FIQMQQa0oC7ZQMLLTsIg3sdAQLZg8oMJzH0JfT0TnXY5t+wAduDPTJZn7+7uW4TzmEsK JxFw== X-Gm-Message-State: AOAM530YLtxA8OZg2MLFhQxakNJFZjzpBf/hY7+S09Oo8u7t0g3mbFht FyCLZs8FO6y585/7krUp64hqYZVoatdXsLUdBvtLp4Q2q6s= X-Google-Smtp-Source: ABdhPJzrTawT7LCiOqKYO4ywWMwzUHcwa7H5eZCNvXjkZgrKkt9VZBvSsJk2kPx760Ymhamm15RkFs+AAWWW71k5jUM= X-Received: by 2002:a17:902:74cb:b029:e4:7a16:9925 with SMTP id f11-20020a17090274cbb02900e47a169925mr15687203plt.39.1616171006354; Fri, 19 Mar 2021 09:23:26 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 19 Mar 2021 11:23:25 -0500 In-Reply-To: <83v99nedze.fsf@gnu.org> Received-SPF: pass client-ip=209.85.214.181; envelope-from=stefankangas@gmail.com; helo=mail-pl1-f181.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266604 Archived-At: Eli Zaretskii writes: >> It's a command that is applicable only to finder-mode buffers, so I >> think the tagging is correct? > > It depends on what we do with the tag. > > "Applicable only to finder-mode buffers" doesn't tell how we use this > information. We use it to filter out commands as irrelevant in > certain contexts. But this command _is_ relevant even when the major > mode of the current buffer is something other than finder-mode, > because the user can click on text in a non-selected window. Currently we use it to filter commands in `M-x', where you anyways can't use it (it will signal an error as EVENT is not bound). So this change doesn't break anything. What am I missing? If the above is correct, then that also means that there is no point to show such commands even in `finder-mode'. So it would be even better to add some form that marks a command as only relevant to the mouse and then never show those commands in `M-x'. ISTR we discussed something like that but I'm not sure if we reached any conclusion.