From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master b525f201ba: Allow specifying the color to use in image-elide Date: Thu, 15 Sep 2022 00:28:41 -0700 Message-ID: References: <166317972871.8462.16344173364399917298@vcs2.savannah.gnu.org> <20220914182209.04F50C00872@vcs2.savannah.gnu.org> <838rml194r.fsf@gnu.org> <87illp15fd.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1629"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 15 09:42:12 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYjVk-0000Cd-8k for ged-emacs-devel@m.gmane-mx.org; Thu, 15 Sep 2022 09:42:12 +0200 Original-Received: from localhost ([::1]:46098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYjVi-0003Xn-PF for ged-emacs-devel@m.gmane-mx.org; Thu, 15 Sep 2022 03:42:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYjIi-0004Ul-Mu for emacs-devel@gnu.org; Thu, 15 Sep 2022 03:28:44 -0400 Original-Received: from mail-ot1-x32d.google.com ([2607:f8b0:4864:20::32d]:33740) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oYjIh-0004oK-6O; Thu, 15 Sep 2022 03:28:44 -0400 Original-Received: by mail-ot1-x32d.google.com with SMTP id l7-20020a056830154700b0065563d564dfso11923492otp.0; Thu, 15 Sep 2022 00:28:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date; bh=mjqB4X4gfwcOOOR3dPQkZe0xR90AbAmhN4csq7mT4MY=; b=Bx3pg6WBi3jkdDWJi01sv+DClqIlCVqn71OvuIjbnxJYfSv/+zY7cvuej2+2qQbuU3 G7ieQloJLEuYvYg/RbwE7fLU921nRaiLVnErl5qmxfHB7Q3L1XBq9NtVhV0PJ1AKxcBq ErOaUDqb67SrIVOiRy06YGJUNjxUJEActMdki9B2JwjLVW4Wm42HoIdDONT5gu/NT2cR lBvN74Cab11VmFQ8mQC4gv2CFZRVdiltHN9nboPJq8kfFJlWttPiiP/xqmtBm7xawP6i 32Gm9Xf31pqno8i5+9UfT8wrtY25fHYPa0dTcaSRhZOd3ymN9Zz/03hXC55d8rk5N8Z7 aSPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date; bh=mjqB4X4gfwcOOOR3dPQkZe0xR90AbAmhN4csq7mT4MY=; b=VvlmqUSv9DqJUyV/lIXjgDQYolMGW9ONlTsIUNS+7xRbrotFRDJH+8mPBG1+yZn0Lz NznF62xsTQel3kV0+0PN4mOns5fLGL7DxELFvVtwjagJNNzlh0hJ9SP8YC3fehDLp5fE Ojj7KCV4Z+qt6r09wYGOKCXDO6qju8rN1PN/i7jjcUn7UMxkVFu+vFRkpgqu3b1Sk6Ur gWKhbtJsT4nNg3DIMTQKJvIw3b/FUmYNekaNWa/vuX2gcccX6xGtdlO/HaIh8h3NJIKe tqSJONkSG1nkIoy6UomSqnnUAePdcUqEBKhGZBZBJuk5gN6o/pNTv6FFD3JXz1Hh40dg LTZQ== X-Gm-Message-State: ACgBeo1Oe2acL5gN/9qCGuX3iK4G54iao5vOetPf6dy8cN3VXYXkIHQo UfIj6mH9Sp55Uf2Sf0qwen1lZKJS/zTDTZ4xfr7hRHFP X-Google-Smtp-Source: AA6agR6fFlvHm4DsOXhwqfC/AXcy7BW/Neud79o+YN9CDooxQbD/MjvmmRPYGcZFySUMsZJbFP1sxzbzm35+QrI2aUk= X-Received: by 2002:a05:6830:3c1:b0:637:28be:7920 with SMTP id p1-20020a05683003c100b0063728be7920mr16094098otc.105.1663226921480; Thu, 15 Sep 2022 00:28:41 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 15 Sep 2022 00:28:41 -0700 In-Reply-To: <87illp15fd.fsf@gnus.org> X-Hashcash: 1:20:220915:larsi@gnus.org::CM3O4IpIZLMdRywq:4h0o Received-SPF: pass client-ip=2607:f8b0:4864:20::32d; envelope-from=stefankangas@gmail.com; helo=mail-ot1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295399 Archived-At: Lars Ingebrigtsen writes: > Eli Zaretskii writes: > >> Shouldn't the default be the background color of the frame? > > Yes, I guess that's as good a default as any. I don't think the current Emacs theme will affect what I prefer to use for eliding. IOW, I'd rather keep it simple and just stay with "black" as the default (or, even better, adding a defcustom). > I think I'll follow Stefan's suggestion to make it prompt with a prefix, > and then move the SQUARE stuff into the function itself -- i.e., hit a > key while cropping to switch to square mode. Sounds good, thank you. > OK, I'll go with `image-cut', and move the key binding to `x'. FWIW, I like "image-redact" best here. That also alludes to how I imagine one would use this. The problem I see with "cut" is that it leads you to then think about how to "paste".