From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Please fix source of unfixable docstring length warnings Date: Sun, 9 Jan 2022 02:05:33 -0600 Message-ID: References: <25050.19976.741797.448258@google.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000045a53c05d521afcd" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18640"; mail-complaints-to="usenet@ciao.gmane.io" To: "T.V Raman" , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 09 09:07:31 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n6TEh-0004gf-AX for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Jan 2022 09:07:31 +0100 Original-Received: from localhost ([::1]:53736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n6TEf-0000tJ-TF for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Jan 2022 03:07:29 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6TCt-0008QW-II for emacs-devel@gnu.org; Sun, 09 Jan 2022 03:05:41 -0500 Original-Received: from [2607:f8b0:4864:20::636] (port=35715 helo=mail-pl1-x636.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n6TCq-0004gI-7E for emacs-devel@gnu.org; Sun, 09 Jan 2022 03:05:37 -0500 Original-Received: by mail-pl1-x636.google.com with SMTP id n16so9607653plc.2 for ; Sun, 09 Jan 2022 00:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:in-reply-to:references:mime-version:date:message-id:subject:to; bh=DYuc69ErqtPclo12JGvE6aFGITT6ZRgwGRW354RoYg8=; b=eqMIt2z8wOKoseDw5aG1vEXW/tvgFTbQzv72E9pw64+wyOeVbCfNAYJjalnp3rNSrI TSPOhi6Y7Qv/2ALwM7f46zsVG53IVJlDL8VpX5OTsnErtBccGBEypfoeKRMAAvoaVLoi 5TQj/k3WJBwM9nuor9F6QtfeHzYYJXhi/OwqqDpoAFdnzyu1M0yW7/yF8qm8jiIjJzPF 73+AyFYXM0hT/9kmfIKr1nQZjJ2bhXMdnAN4yt9nEIn8ZPZHfZM6s3qrWoIEp3wdMaCQ lGeBjAk0WQiWp+nX0r5icYW7poHCnFDpOaMLDC1oi2D+VdamZIJ9GZIpCYFhfdB3Yn4R JT5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to; bh=DYuc69ErqtPclo12JGvE6aFGITT6ZRgwGRW354RoYg8=; b=iHJZRv094uE57mYJT3O2A0nTiqMteikuPQ0awAVHE1haUrMn59XjfQMc3KFfzLhsWo kfmPIpCPfegM6v/rkIs+Rv/kXA3YAwODrmWzGOyZRvyzn4YQ3EE3g3Op0bD+99Ox1eqH CWdy6Pv84Q3SA7TvN73kUDoba0mAsRr/XpFudeDfMdyzRn2zQj2MQTPj4UnR99bRbys9 K6YL2zNexEfs3EiUjF8SttTEZjvmRxhiQnORJ1Lbg9nJA8IS6ld5NZ/rFzn6R0yiCOGY jk/iNXpCHmLsjrJlKgLbgQtHptbkhcFTcE3QaGjHYu52Yy29HfE34UHlh5D4ub2/SUVA qwiQ== X-Gm-Message-State: AOAM530DYc9KDEvIufQbts4ylntQa17I0+gSXLutBrqQG1wSrJZUyBdX HRWJvfaCqNURFgjM0hJrud1OLOAe9EXxD5EOSns= X-Google-Smtp-Source: ABdhPJwHG5spOx0OAfBiet7ku2CCroouVOmMyShbGc/ySsshccB1vWUGun4g+00dOGOLEcOWq8STLzLzmS+bmFhhitw= X-Received: by 2002:a17:90a:b798:: with SMTP id m24mr10910404pjr.143.1641715534762; Sun, 09 Jan 2022 00:05:34 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 9 Jan 2022 02:05:33 -0600 In-Reply-To: <25050.19976.741797.448258@google.com> X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::636 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::636; envelope-from=stefankangas@gmail.com; helo=mail-pl1-x636.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284498 Archived-At: --00000000000045a53c05d521afcd Content-Type: text/plain; charset="UTF-8" "T.V Raman" writes: > As an example, > emacspeak-table-ui.el:57:45: Warning: docstring wider than 80 > characters > reported on > https://github.com/tvraman/emacspeak/blob/master/lisp/emacspeak-table-ui.el#start-of-content > > These warnings are unfixable since the source code doesn't actually > have the problem reported, it appears to happen for things like calls > to define-derived-mode and similar things and the noise from these > spurious warnings means that real warnings will get ignored over time. I can't reproduce this, as the below patch makes the warning go away here: --00000000000045a53c05d521afcd Content-Type: text/plain; charset="US-ASCII" Content-Disposition: attachment Content-Transfer-Encoding: base64 X-Attachment-Id: 412bc2606e599659_0.2 CkRvZXMgdGhhdCBwYXRjaCBmaXggdGhlIHByb2JsZW0gZm9yIHlvdSB0b28/CgpJJ3ZlIGZpeGVk IHNldmVyYWwgd2FybmluZ3MgZm9yIG92ZXJseSBsb25nIGRvY3N0cmluZ3MgaW4gYXV0b21hdGlj YWxseQpnZW5lcmF0ZWQgc3RyaW5ncy4gIElmIGFueSByZW1haW4sIEkgd291bGQgZGVmaW5pdGVs eSBsaWtlIHRvIGZpbmQgdGhlbQphbmQgZml4IHRoZW0sIHNvIEkgYXBwcmVjaWF0ZSB5b3VyIGhl bHAgaW4gZ2V0dGluZyB0byB0aGUgcm9vdCBvZiB0aGlzLgpUaGFua3MuCgpCVFcsIGlmIHlvdSBm aW5kIHRoZXNlIHdhcm5pbmdzIHRvbyBtdWNoIG9mIGEgaGFzc2xlLCB5b3UgY291bGQgY29uc2lk ZXIKZGlzYWJsaW5nIHRoZW0gd2l0aCBhIGRpcmVjdG9yeSBsb2NhbCB2YXJpYWJsZTsgSSBiZWxp ZXZlIHlvdSB3b3VsZCBuZWVkCnRvIHNldCBgYnl0ZS1jb21waWxlLXdhcm5pbmdzJyB0byBlLmcu IGAobm90IGRvY3N0cmluZ3MpJy4K --00000000000045a53c05d521afcd Content-Type: text/x-diff; charset="US-ASCII"; name="fix-warning.diff" Content-Disposition: attachment; filename="fix-warning.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: 412bc2606e599659_0.1 ZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3NwZWFrLXRhYmxlLXVpLmVsIGIvbGlzcC9lbWFjc3BlYWst dGFibGUtdWkuZWwKaW5kZXggMmMxNDY1ZTBmLi4wYjYwNzY5ZmEgMTAwNjQ0Ci0tLSBhL2xpc3Av ZW1hY3NwZWFrLXRhYmxlLXVpLmVsCisrKyBiL2xpc3AvZW1hY3NwZWFrLXRhYmxlLXVpLmVsCkBA IC04NSw3ICs4NSw4IEBAIFQgICAgICAgICAgICAgICBlbWFjc3BlYWstdGFibGUtZ290by10b3AK IAogVGhlIG5leHQgdHdvIGNvbW1hbmRzIGxldCB5b3Ugc2VhcmNoIHRoZSB0YWJsZS4KIFRoZSBj b21tYW5kcyBhc2sgeW91IGlmIHlvdSB3YW50IHRvIHNlYXJjaCByb3dzIG9yIGNvbHVtbnMuCi1X aGVuIHNlYXJjaGluZyBoZWFkZXJzIHJlbWVtYmVyIHRoYXQgcm93IDAgaXMgdGhlIGNvbHVtbiBo ZWFkZXIsIGFuZCB0aGF0IGNvbHVtbiAwIGlzIHRoZSByb3cgaGVhZGVyLgorV2hlbiBzZWFyY2hp bmcgaGVhZGVycyByZW1lbWJlciB0aGF0IHJvdyAwIGlzIHRoZSBjb2x1bW4gaGVhZGVyLAorYW5k IHRoYXQgY29sdW1uIDAgaXMgdGhlIHJvdyBoZWFkZXIuCiAKIGggICAgICAgICAgICAgICBlbWFj c3BlYWstdGFibGUtc2VhcmNoLWhlYWRlcnMKIHMgICAgICAgICAgICAgICBlbWFjc3BlYWstdGFi bGUtc2VhcmNoCg== --00000000000045a53c05d521afcd--