unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Boruch Baum <boruch_baum@gmx.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	emacs-devel@gnu.org
Subject: Re: ~Make emacs friendlier: package documentation [POC CODE INCLUDED]
Date: Sun, 18 Oct 2020 10:13:17 -0700	[thread overview]
Message-ID: <CADwFkmktTVEnHiOQTFHKKSRy7rciPZAVzoUZvwUbc7EXMuM4dQ@mail.gmail.com> (raw)
In-Reply-To: <20201018162030.h7s4tqch3sprssxu@E15-2016.optimum.net>

Boruch Baum <boruch_baum@gmx.com> writes:

>> Having tested your code,
>
> Thanks. For what packages? It's important to know in order to understand
> the content of your feedback.

I tested it on lisp/time.el.

>> I agree that we should keep `C-h P' as-is, but extend it with
>> everything from the "** Code:" header and down in your code.
>
> That would lose a lot of information. There could be many
> sections/headings above 'code', and it turns out to seem that even the

OK, fair enough, so please modify the above to say "everything after the
'Commentary' section".

You could just move the sections around.  For example, the license could
be moved to the end (if it is even necessary in the GPL case).

> 'commentary' section that describe-package presents isn't directly from
> the 'commentary' section in the elisp file (see, for example, yasnippet).

That's because it comes from the package README file instead.

>> We would also need to check that this works also for packages that are
>> not installed (they don't need to show the full documentation, I don't
>> think, but they should at least not be broken ;-).
>
> My code submission should work as-is on any elisp file that conforms to
> the emacs coding standard format. I've tested it for my other recent
> code submission - key-assist.el
>
> OTOH, the converse is not true. describe-package doesn't expose itself
> to any elisp file, only recognized packages. Even some features that we
> all think of as packages aren't exposed (eg. dired).

Yes, so that's the part that would need looking into.

>> Perhaps one could make it look more polished by rolling a custom
>> solution here,
>
> Ugh. Re-invent yet another wheel?

Not if we can avoid it, but Org-mode is also not a hammer looking for a
nail.

>> Three more nits:
>
> For me to make sense of most of what you write below, I need to know at
> the very least on what elisp file you encountered the problem, and
> helpfully a pointer of where to find it.
>
>> - I wouldn't show obsolete aliases.
>
> ???

Run your code on time.el and see that obsolete aliases are there.

>> - The autoload cookies should probably get a better representation than
>>   just being copied in.
>
> ???

Run your code on time.el and see that the autoload cookies are copied
verbatim above the headings.  I think they should better be marked in a
different way.



  reply	other threads:[~2020-10-18 17:13 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15 19:09 ~Make emacs friendlier: package documentation [POC CODE INCLUDED] Boruch Baum
2020-10-15 19:24 ` Eli Zaretskii
2020-10-15 19:41   ` Boruch Baum
2020-10-16  6:39     ` Eli Zaretskii
2020-10-16  7:34       ` Boruch Baum
2020-10-16 10:20         ` Eli Zaretskii
2020-10-18  5:58           ` Boruch Baum
2020-10-18 14:53             ` Eli Zaretskii
2020-10-18 15:05               ` Boruch Baum
2020-10-18 15:12                 ` Eli Zaretskii
2020-10-18 15:28                   ` Boruch Baum
2020-10-18 16:00                     ` Eli Zaretskii
2020-10-18 16:29                       ` Boruch Baum
2020-10-18 17:05                         ` Eli Zaretskii
2020-10-18 13:11         ` Stefan Monnier
2020-10-18 14:43           ` Boruch Baum
2020-10-18 15:50             ` Stefan Kangas
2020-10-18 16:20               ` Boruch Baum
2020-10-18 17:13                 ` Stefan Kangas [this message]
2020-10-18 20:40                 ` Kévin Le Gouguec
2020-10-19  2:55                   ` Boruch Baum
2020-10-21  5:52                     ` Kévin Le Gouguec
2020-10-21  6:00                       ` Boruch Baum
2020-10-21 22:31                     ` Stefan Monnier
2020-10-18 15:58             ` Boruch Baum
2020-10-18 20:18           ` Stefan Monnier
2020-10-19  2:24             ` Eli Zaretskii
2020-10-19  2:59               ` Boruch Baum
2020-10-19  3:16                 ` Stefan Monnier
2020-10-20  5:11                   ` Richard Stallman
2020-10-20  5:51                     ` Boruch Baum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmktTVEnHiOQTFHKKSRy7rciPZAVzoUZvwUbc7EXMuM4dQ@mail.gmail.com \
    --to=stefankangas@gmail.com \
    --cc=boruch_baum@gmx.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).