From: Stefan Kangas <stefankangas@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 30d4011b8a: Use substitute-command-keys in Info-index error
Date: Sun, 27 Nov 2022 16:44:30 -0800 [thread overview]
Message-ID: <CADwFkmkmNRXVRp8Y7x7ihPkRBsrYxrruw2Of_v2Cu_3Q6nxNbQ@mail.gmail.com> (raw)
In-Reply-To: <83v8n1st6t.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> From: emacs-diffs-request@gnu.org
>> Date: Sat, 26 Nov 2022 03:56:27 -0500
>>
>> diff --git a/lisp/info.el b/lisp/info.el
>> index 8860a664bd..7d44a1cec1 100644
>> --- a/lisp/info.el
>> +++ b/lisp/info.el
>> @@ -3329,6 +3329,12 @@ If FILE is nil, check the current Info file."
>> (or node (error "No index"))
>> (Info-goto-node node)))
>>
>> +(defun info--ensure-not-in-directory-node ()
>> + (if (equal Info-current-file "dir")
>> + (error (substitute-command-keys
>> + (concat "The Info directory node has no index; "
>> + "type \\[Info-menu] to select a manual")))))
>
> The new code doesn't handle the case where "DIR" is in upper-case, nor if
> Info-current-file is something like "/usr/share/info/dir" (which can happen
> if you say "C-u C-h i /usr/share/info/dir RET").
Good catch. I believe this has now been fixed with commit 059467ddc2.
prev parent reply other threads:[~2022-11-28 0:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-26 14:10 master 30d4011b8a: Use substitute-command-keys in Info-index error Eli Zaretskii
2022-11-28 0:44 ` Stefan Kangas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmkmNRXVRp8Y7x7ihPkRBsrYxrruw2Of_v2Cu_3Q6nxNbQ@mail.gmail.com \
--to=stefankangas@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).