From: Stefan Kangas <stefankangas@gmail.com>
To: Alan Coopersmith <alan.coopersmith@oracle.com>, emacs-devel@gnu.org
Cc: Ali Bahrami <Ali.Bahrami@oracle.com>, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] configure.ac: Fix FIONREAD check to work with gcc-14 on Solaris
Date: Sat, 12 Oct 2024 08:20:52 -0500 [thread overview]
Message-ID: <CADwFkmkjpKO_7gRPBqTUv8_1=LXP_-ozSWXS43=poyMt_-t+6Q@mail.gmail.com> (raw)
In-Reply-To: <20241008210227.27362-2-alan.coopersmith@oracle.com>
Alan Coopersmith <alan.coopersmith@oracle.com> writes:
> Before this fix, it would fail to build with gcc-14 with the error:
> conftest.c: In function 'main':
> conftest.c:265:11: error: implicit declaration of function 'ioctl'
> [-Wimplicit-function-declaration]
> 265 | int foo = ioctl (0, FIONREAD, &foo);
> | ^~~~~
>
> Solaris documents ioctl() as being defined in <unistd.h>
> ---
> configure.ac | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index 8a5ba7db3d1..947c2827b8e 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -7117,6 +7117,9 @@ AC_DEFUN
> #ifdef USG5_4
> # include <sys/filio.h>
> #endif
> + #ifdef HAVE_UNISTD_H
> + # include <unistd.h> /* defines ioctl() on Solaris */
> + #endif
> ]],
> [[int foo = ioctl (0, FIONREAD, &foo);]])],
> [emacs_cv_usable_FIONREAD=yes],
> --
> 2.45.2
I guess this should be installed on emacs-30. Eli, WDYT?
next prev parent reply other threads:[~2024-10-12 13:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 20:58 [PATCH] configure.ac: Fix FIONREAD check to work with gcc-14 on Solaris Alan Coopersmith
2024-10-12 13:20 ` Stefan Kangas [this message]
2024-10-12 14:28 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmkjpKO_7gRPBqTUv8_1=LXP_-ozSWXS43=poyMt_-t+6Q@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=Ali.Bahrami@oracle.com \
--cc=alan.coopersmith@oracle.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).