From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Proposal for an improved `help-for-help' Date: Fri, 30 Apr 2021 12:34:05 -0500 Message-ID: References: <838s7hxqkr.fsf@gnu.org> <1c2c69f9-f42e-45e2-ab0e-8506aa859f85@yandex.ru> <8335ven7tu.fsf@gnu.org> <6654ddbe-0f1b-f36e-26f2-f4ee178b12ac@yandex.ru> <83sg3elkdz.fsf@gnu.org> <283b4718-88eb-b63a-ce0b-316e4def4ff3@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3485"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Dmitry Gutov , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 30 20:02:46 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lcXTS-0000pf-Ac for ged-emacs-devel@m.gmane-mx.org; Fri, 30 Apr 2021 20:02:46 +0200 Original-Received: from localhost ([::1]:45880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcXTQ-0006vM-Ve for ged-emacs-devel@m.gmane-mx.org; Fri, 30 Apr 2021 14:02:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcX1n-0005r1-Gi for emacs-devel@gnu.org; Fri, 30 Apr 2021 13:34:12 -0400 Original-Received: from mail-pj1-f43.google.com ([209.85.216.43]:51753) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lcX1k-0006EV-IU; Fri, 30 Apr 2021 13:34:11 -0400 Original-Received: by mail-pj1-f43.google.com with SMTP id lp8so6755344pjb.1; Fri, 30 Apr 2021 10:34:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=xKBaI84Tb3xfvJt7quCuRjl+WYDYpCWAJo+x+3mmqlE=; b=QzSvhZDI6NvK3+7nurIqkl+Qcq9eMG2TuC2S0m+1A9N/TUVaT0ctcptzffnSjf1qOC DJdsvGgobYIW6VmNrtGa+WJ33yHhyPGXGKMLRPSNFL9yHRzJt4su/3rKQgi7U1sZv2uK dj6FBWeDu+pKRCEpSEhhA9ZYHfI4npIsDJiFlCO7yh4SX74lbgbbYT4PtdMbkemvTv42 vnQSnoHRrIU4sEl1rF6eoF0+qGd8+IftLuaQ6hwHLQFsib4gIYgWzAPueElAgT/EWKs5 KtiVx5aJOSX22F1T7i6Cdl5liL5fCJdKvufaIx3/dV0v2do7hBzXKLoIVKgIT+qL2iMB +/kw== X-Gm-Message-State: AOAM5324UgopDho8a0WbcgC+hlpohC0GYR3Eeu360zviFcnWXFwq5lbR uSOjMOz4BpiOPVzu3TgHDga61KPmCjbfcSQx3/k= X-Google-Smtp-Source: ABdhPJzYCeLcZJ3Kgo7iAif/+1j6Klx+yE2m3xVx57n8L+P0BpR2raWGhBqoPSvJ/jrTRqkyZO9MvT9556inMjVtNXM= X-Received: by 2002:a17:90a:b38a:: with SMTP id e10mr6425514pjr.175.1619804046074; Fri, 30 Apr 2021 10:34:06 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 30 Apr 2021 12:34:05 -0500 In-Reply-To: Received-SPF: pass client-ip=209.85.216.43; envelope-from=stefankangas@gmail.com; helo=mail-pj1-f43.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268680 Archived-At: Stefan Kangas writes: > So does that mean that the below diff correct? And is there a need to > handle `PageDown' and `PageUp' in addition to `next' and `prior'? No replies here, so I have now pushed the below change to master (commit 04266a2cac). If this leads to any problems, please reply here or report a bug and put me on Cc. > diff --git a/lisp/help-macro.el b/lisp/help-macro.el > index 6a0e11574c..663b14d3d1 100644 > --- a/lisp/help-macro.el > +++ b/lisp/help-macro.el > @@ -174,9 +174,9 @@ make-help-screen > (point-max)) > "" > (concat ", or " > - (help--key-description-fontified "\s") ; SPC > + (help--key-description-fontified (kbd "")) > " or " > - (help--key-description-fontified "\d") ; DEL > + (help--key-description-fontified (kbd "")) > " to scroll")))) > char (aref key 0))) > > diff --git a/lisp/help.el b/lisp/help.el > index e143501081..8d6279de8f 100644 > --- a/lisp/help.el > +++ b/lisp/help.el > @@ -232,9 +232,9 @@ 'help > (purecopy "Type a help option: [abcCdefFgiIkKlLmnprstvw.] C-[cdefmnoptw] or ?") > (concat > "\(Type " > - (help--key-description-fontified "\s") ; SPC > + (help--key-description-fontified (kbd "")) > " or " > - (help--key-description-fontified "\d") ; DEL > + (help--key-description-fontified (kbd "")) > " to scroll, " > (help--key-description-fontified "\C-s") > " to search, or \\\\[help-quit] to exit.)"