From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: RE: [External] : Consistent face for keys in *Help* and `substitute-command-keys' Date: Thu, 25 Feb 2021 10:22:14 -0600 Message-ID: References: <87h7m5iagw.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25346"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "emacs-devel@gnu.org" To: Drew Adams , Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 25 17:23:33 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lFJQK-0006Ty-Af for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Feb 2021 17:23:32 +0100 Original-Received: from localhost ([::1]:36430 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lFJQJ-0006fX-DJ for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Feb 2021 11:23:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFJP9-0005sL-Q0 for emacs-devel@gnu.org; Thu, 25 Feb 2021 11:22:19 -0500 Original-Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]:42061) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lFJP6-0005uu-VD for emacs-devel@gnu.org; Thu, 25 Feb 2021 11:22:19 -0500 Original-Received: by mail-pf1-x434.google.com with SMTP id w18so3929777pfu.9 for ; Thu, 25 Feb 2021 08:22:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=55GKmx9USsewndaQ4EdmHZqpwCtz5eh33EdhKvsu35Q=; b=I5nkeEyggPgotG6eAUzbsjoMZDtYgIAN1y8yBYqGdJrkY9CF0hHGkV4NhncI+IrEcQ V6P3Ocw/qn8RcIL+56O6x5PXywMQ2/CGVKG185Fwnz94ELTRkM5eJm59QRPF0at23R+7 s12XTitUP1AjlMROkgFBmAE0zhUN2byzX1gmVaUG0Wv1OgpZ8UXCOFmU2aKtH3pzITlY YPFZk1oRj65UDRioHYbcTQvbhpcFjHJlwemgR8bRr6ebiuLE1HwhI0HMkAT/PkmF1uRC ai6mbYILrn78hZb+eBd09ThXaxziuvrDepMdajA77QCrxWhJPdpC6bOkZ4A1jZlZOx06 v/sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=55GKmx9USsewndaQ4EdmHZqpwCtz5eh33EdhKvsu35Q=; b=aFwGC0j9dvF9V7/MfZm5tEZBpAjRMpQI/olU0iV0Jd4FtN4kzgd7sWlomHdva1BFO2 S0WMWY5GejbnsQDPNdC1O5nnbBUkqhv3I2COC31swlOCg6GXJvhMcuD128De2Fc3Wzrv yYs1U0L1y4qsZ/Eaq+fDKcIlTIdC4r4etT6Yef6JCsdxtlGiLm9CaYCebjxADbvaqrg7 p3nmHq0YQR6uYSvBeq0MPvPqnnxeTCJAoOTTUg5KrLv9Id3rZzpL25bKAvZAiK6FWQuu gV9hnycbLYajLcYlUFlbhtl30Rk/34RuNgTTBn3H+GD19CN0htbyUiHI8wwkJmlbwuMD mMjA== X-Gm-Message-State: AOAM532tqwdo0NDx5UuKT/6mQD5u+FhZU4DOKB42Iu9BWNFWVI9bsGM0 gb3qgH/ON5rMfG/2RWdagGlS6pEIiGA6zabViqg= X-Google-Smtp-Source: ABdhPJyhyDw4P8eNul+Pbe2pwLuMXqXFK2C3gGPVDhlqKKp904O/B1bA1Ymf99RY3S/hBS8eFDfzL9dqP2yahMVjTNs= X-Received: by 2002:a63:ed02:: with SMTP id d2mr3750273pgi.67.1614270135407; Thu, 25 Feb 2021 08:22:15 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 25 Feb 2021 10:22:14 -0600 In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=stefankangas@gmail.com; helo=mail-pf1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265630 Archived-At: Drew Adams writes: > Actually no, there was nothing you needed to do, for > `describe-keymap'. But you wanted different behavior, > so you changed it slightly. Fine. There are all kinds of adaptions to make before putting things on master besides just copying it from some library: making sure the code conforms to our style (yours doesn't), does not have features we do not need (support for your other "foo+" libraries), adding proper documentation (yes, we need to update the manual as well), adding NEWS, discussing the details, testing, etc. I have no idea why you dismiss that work as "nothing to do". If it is so easy and so little work, please start sending patches instead of just linking some library. Thanks in advance. > I don't care if you use my `describe-command' or > whatever. [...] > But what do I know? > > [NIH? Oh, please. Here is the definition of `describe-command': (defun describe-command (command) (interactive (help-fns--describe-function-or-command-prompt 'is-command)) (describe-function command)) Yeah, I chose not to "re-use" anything here. Sorry for suffering from NIH. I would suggest you actually study my patch, and then point out any opportunities for re-using your code. I have now studied your code and I see *no* such opportunities. (This was a fully expected result, for the reasons I have already provided.)