From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Patch proposal: display symbol source code in help buffers Date: Tue, 21 Sep 2021 00:41:22 -0700 Message-ID: References: <875yuvlrz3.fsf@gnus.org> <87r1djixiw.fsf@gnus.org> <878rzrzpfz.fsf@localhost> <87zgs7y5wc.fsf@localhost> <87sfxyftrw.fsf@gnus.org> <87mto6ifd2.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20180"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Arthur Miller , emacs-devel@gnu.org To: Ihor Radchenko , Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 21 09:42:39 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSaQH-00052h-BA for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Sep 2021 09:42:37 +0200 Original-Received: from localhost ([::1]:33948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSaQG-0001hk-AX for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Sep 2021 03:42:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSaP8-00005I-DU for emacs-devel@gnu.org; Tue, 21 Sep 2021 03:41:26 -0400 Original-Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]:50913) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSaP7-0000cf-1s for emacs-devel@gnu.org; Tue, 21 Sep 2021 03:41:26 -0400 Original-Received: by mail-pj1-x1030.google.com with SMTP id k23so13824658pji.0 for ; Tue, 21 Sep 2021 00:41:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=R+TXQ//e+YDGiGGajtkswAz3U9P5cVaqneL6D6XmW+E=; b=RQrPonWT2AAnuFAzghHZzrxSc+3blCWrYNsNm6bxyPvS7iY5N3/C1nNKw+FMBqi8VS o2FlzhVbMa6SVfFCcl5kJp4yLkZooIMOvGnGOFbKdJG/OMGB/eh5MCaoFzAPx9i5Jmw7 DD4B+Vf5eFaePGaS7QFsCzDWtX95o8Z3IxGcWEx8E112O5bAVVWTgPlwR8WWWwbMgzlL 1bcZhogG8zETrS/UWv7mDsKbHF2RFGYkL4tk2jzojs7ccDOSB9o42ZITi754SD16D8a2 804ddBtLPsd+PAes+dlM4fwEZG7xtBzlStgIsci2Not9uo5kgVoEtOk8G9kbQ6+ru2NS cc4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=R+TXQ//e+YDGiGGajtkswAz3U9P5cVaqneL6D6XmW+E=; b=xXBVJrLOudotJAsMypDgc0MXNrguCLHUcARHiy/Q37P0V91Nk6Ug88F+oIOxQZz6wU BsYn9M0l4Zzf8qOAF9nDzczovqT4vuO8FjtC1k2GLwl0eR12u3StiB/Tzn6yD/F4r46m zWJCazBNXfEdyfOPdJOLXpcrhZFH0a1nPVxpWUdwngfNy0M+jkmq24BXHrkEn0r4vSni cYdUEnhyn987zahbNVhsMEB3IaCkvu4Tk8BEho42dPpnJusVHmqOo3xkFyAtZ1fiL2OB 8PF3qq2criCcnTVXQ6IfOGXdqZeQFibI1eu1Xe9l4wOd+STk3KTkv84DMbhxTfx/hSji fjTQ== X-Gm-Message-State: AOAM531LswOlef6KTC9sOS/6KRmFy0KHgPgfD09dNyhZl3BHf6S/zhVZ xRBsXiLnpuoaNxKcTV45Upwge1VYLoWvuvLqkvo= X-Google-Smtp-Source: ABdhPJwmM8r/ItScGuxqAPjEyvbdEDNCwAVkU/slToaJBxmOBW5PAZOoz9ZJ9MkrxAkRZkA6DY0KR5X+k+Yt8ixn7TI= X-Received: by 2002:a17:90b:3805:: with SMTP id mq5mr3680558pjb.143.1632210083115; Tue, 21 Sep 2021 00:41:23 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 21 Sep 2021 00:41:22 -0700 In-Reply-To: <87mto6ifd2.fsf@localhost> Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=stefankangas@gmail.com; helo=mail-pj1-x1030.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275203 Archived-At: Ihor Radchenko writes: > I like this idea. Maybe we can simply change the default value of > find-function-after-hook like in the attached patch? We generally prefer not to add hooks like this if we can avoid it. We can usually just change the code instead. For example, in this case maybe we could just call `push-mark' at the end of `help-function-def--button-function'.