From: Stefan Kangas <stefankangas@gmail.com>
To: Jonas Bernoulli <jonas@bernoul.li>,
rms@gnu.org, Philip Kaludercic <philipk@posteo.net>
Cc: emacs-devel@gnu.org
Subject: Re: [NonGNU ELPA] New package proposal: git-modes
Date: Thu, 21 Oct 2021 19:13:08 -0700 [thread overview]
Message-ID: <CADwFkmk_LnKZErOqLo_=Z5xsWObXa489Dame=-hY8g1VeLN6Rg@mail.gmail.com> (raw)
In-Reply-To: <87k0i5ex9j.fsf@bernoul.li>
Jonas Bernoulli <jonas@bernoul.li> writes:
>> That's a shame. But how big is per code?
>> Would it be feasible to write new code to replace that code?
>
> It's not a of code: gitconfig-mode: 137, gitignore-mode: 61,
> gitattributes-mode 232 lines, all including headers. IMO it
> would make sense to re-implement them.
>
> gitignore-mode is completely trivial, basically just font-lock keywords.
Couldn't .gitignore-mode basically just be replaced with
`conf-unix-mode'? I have gitignore-mode running locally, but I'm not
sure the syntax highlighting it does have is very helpful. Why
highlight "/" in "foo/bar", for example?
This would be a trivial addition to auto-mode-alist in emacs-28, if
that's something we want to do.
> gitconfig-mode has more font-lock keywords plus some indentation code,
> which I personally find more annoying than helpful.
By default, we use `conf-mode' for these files, which already looks
pretty good to my eyes. Is gitconfig-mode much better?
> gitattributes-mode is more complex, also including support for eldoc and
> some navigation commands. The good news is that in this case we might
> actually be able to get all the required copyright assignments.
That's good news, indeed.
next prev parent reply other threads:[~2021-10-22 2:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 18:08 [NonGNU ELPA] New package proposal: git-modes Jonas Bernoulli
2021-10-18 19:18 ` Stefan Monnier
2021-10-18 19:50 ` Philip Kaludercic
2021-10-18 22:13 ` Jonas Bernoulli
2021-10-20 6:46 ` Richard Stallman
2021-10-20 13:02 ` Stefan Kangas
2021-10-22 23:44 ` git-modes Richard Stallman
2021-10-20 18:52 ` [NonGNU ELPA] New package proposal: git-modes Philip Kaludercic
2021-10-21 22:42 ` Richard Stallman
2021-10-22 0:08 ` Jonas Bernoulli
2021-10-22 2:13 ` Stefan Kangas [this message]
2021-10-22 6:50 ` Juri Linkov
2021-10-22 7:57 ` Stefan Kangas
2021-10-23 18:14 ` Juri Linkov
2021-10-22 18:05 ` Jonas Bernoulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmk_LnKZErOqLo_=Z5xsWObXa489Dame=-hY8g1VeLN6Rg@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=jonas@bernoul.li \
--cc=philipk@posteo.net \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).