From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Is it better to add treesitter modes to core? Date: Tue, 9 Jan 2024 10:59:50 -0800 Message-ID: References: <87a5phiap4.fsf@posteo.net> <7919cda7-a09e-498c-87e7-6a1733b0eeed@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36066"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stephen Leake To: Dmitry Gutov , Philip Kaludercic , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 09 20:00:46 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNHLC-0009Ac-4y for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Jan 2024 20:00:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNHKP-0004Yu-E2; Tue, 09 Jan 2024 13:59:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNHKN-0004Y8-Ie for emacs-devel@gnu.org; Tue, 09 Jan 2024 13:59:55 -0500 Original-Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNHKL-0000wM-TZ for emacs-devel@gnu.org; Tue, 09 Jan 2024 13:59:55 -0500 Original-Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-40e4d64a3fbso13836605e9.2 for ; Tue, 09 Jan 2024 10:59:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704826792; x=1705431592; darn=gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=ES+RQp1L2LuX8tuOd5bfcrYOFh28jLpT4/LNMZWTwbQ=; b=kUd0YOP/5XcHdwS17e9OYULMdfk1Ly1ec5bPx1bJP/OCIjsrUymLb1oLHmsnapxsgF sYUoDJ8JIfyxvCrqAet/88YtzDz9vn5vnvkkVl82XsfuU5sIXZuQ+/6bhlntXqiJgbR2 s/7uyRiAGUUR4ZZTG/OH8eaGBtfsiW6WNzcelQeEjrKvNASUUVyDWSO7fIaTK1klPBKf LHcbUbNBejC3+pD2y/LwjzgORuFBRbmlsb8l1tB+4oamMIA5N4jfytcGfPU/4Igp2CCa 9u8xWGsMm1f+4KL/zgq0FkvehG/1WNu6UCOhnwXHUAJi602haXtbfTF6S0bVsxHvyQWo Dntg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704826792; x=1705431592; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ES+RQp1L2LuX8tuOd5bfcrYOFh28jLpT4/LNMZWTwbQ=; b=aPkLO1YHtqaKNYVdQkcmPzi5WVFBmHgraMFndf5KH7Cg5DqpK4cSn2lX0CqIRzj8VE 3GE3opUkf1HlOdVvbTZuBz46cagToOXAArDhP2Ka85qr5oGeoFzqIQ9pkbxx2oabPjgt dZO4w92XaaHxuCz+zillKI3nwaHO9MbUifM77ZhJ3m1aVPJ43N8zv5di76kbfhshdvbw nXQmEK5vNNA5ncpqf0YscIh+JH3FzjINKIhtxhHhBfhDNp9nd1gmNDOzlvcReJPWTTio 7krxieDotUPhU986p+EsAp/M2STSpMql8BB+Uj7Fggh9ir8xAYuEXAGjqQ8cA/Wp8kNP itTA== X-Gm-Message-State: AOJu0Yz4NnRk8laJvpaBefjKxyQG70RRDoV333ZJ0d+ZYADktJrE9Dj5 ckzTeNbE3SRgvLX8IF3S17Np4bYxhjfCZ/gYEKI= X-Google-Smtp-Source: AGHT+IF8ZnzA8FbSbQxveTslcMURWfB6X5OO8oLDyNyLDY99AWlfXn3ai2tX0SR4w6vPhksWQKseRb8AyRhUGoTNPeo= X-Received: by 2002:a5d:624e:0:b0:337:20f5:22df with SMTP id m14-20020a5d624e000000b0033720f522dfmr830476wrv.110.1704826791707; Tue, 09 Jan 2024 10:59:51 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 9 Jan 2024 10:59:50 -0800 In-Reply-To: <7919cda7-a09e-498c-87e7-6a1733b0eeed@gutov.dev> Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=stefankangas@gmail.com; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314784 Archived-At: Dmitry Gutov writes: >> Yes, but VSCode has some niceties that we don't. When Emacs displays an >> unobtrusive little popup in the right corner saying >> >> "Hello, this looks like $LANGUAGE, do you want to install support >> for that? [YES/NO]" >> >> then I will agree with you that it's less important to keep stuff in >> core. > > That seems like the wrong positioning of the cart and the horse, IMHO. I suggest that, at least the way things stand, it would be desirable to have the basic programming modes available in core, for the top N languages. There's also no significant drawback to doing so. If we make it substantially easier to install extensions and customize Emacs in the future, then this might turn out to be less important. We will then adapt our way of working to that reality. This seems to me like exactly the right way to position our horse and cart. > As we've observed, moving things out of the core is *hard*. I propose that this consideration should not be decisive for how we proceed. If the current situation is not ideal, it's not horrible either. We can find better ways of doing things (e.g. distributing GNU ELPA packages with Emacs), but whatever we do later, it doesn't seem urgent to avoid adding things to core right now. >> For some of the things listed there, we don't even have a mode. > > I'm pretty sure we would have one somewhere, if not in-tree, for the > vast majority of cases. (I couldn't find one for /etc/fstab, FWIW. That may or may not be a silly example, but OTOH what's not to like about syntax highlighting. Maybe there were better examples too, I can't remember.) > I think it will be a good idea to have someone check out the ada-ts-mode > I linked to previously in this thread, and maybe talk to the author > about adding it to ELPA (GNU or NonGNU), if no major problems come up. > > So far it looks like it has very little users (judging by the numbers of > stars and open/closed issues - which is zero), that's kind of sad. Philip, what do you think about this?