From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master 977f3f27c5 2/2: Don't issue warnings for Unicode quotes for now Date: Sat, 18 Jun 2022 16:39:27 +0200 Message-ID: References: <165425457951.24295.4901777157797017566@vcs2.savannah.gnu.org> <20220603110939.F1B93C06564@vcs2.savannah.gnu.org> <87ilpgacuf.fsf@gnus.org> <874k0yyoa4.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13691"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs developers To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 18 16:40:22 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o2Zcc-0003Ma-Ns for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Jun 2022 16:40:22 +0200 Original-Received: from localhost ([::1]:48910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2Zcb-0006Gr-20 for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Jun 2022 10:40:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2Zc0-0005Kh-TJ for emacs-devel@gnu.org; Sat, 18 Jun 2022 10:39:44 -0400 Original-Received: from mail-pg1-f173.google.com ([209.85.215.173]:45675) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o2Zby-0007uK-H3 for emacs-devel@gnu.org; Sat, 18 Jun 2022 10:39:44 -0400 Original-Received: by mail-pg1-f173.google.com with SMTP id 184so6418304pga.12 for ; Sat, 18 Jun 2022 07:39:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9tP9RCJnC44jC29TOsVMfP/AfPcMVsazn/RROOC3aww=; b=zN2JJtWE3YrCAoRKcZ1Ghr5GFJglHTjmEjLjl5NQoySy/tNNPWKI1X/DqaAXoKqvLD bw+Q1iLx6+S1r+luyxTpnlw4RP6P4IxkQzi+OzeUfAVejS/nsXGKLuGgLSvTGm5wLZ0O 8Iv3VsmOn1KcqwfJjBEmFXDVs52hLSh+FXz9V2cwiAR89cByJ3XHeq6ZdR9SccqoqAYV lM+LZvODk1S5U35fhDrkThywok78t/bWS4QfF09JDUuID9tSaP38pdIrsF86AfcID6MX UHsG+vuqrSwFJ6kGRfdy49RijklTTHL3zOyMj2tE+Q/AgyreFFZ3Rm/JNweij3On7k0j uAIQ== X-Gm-Message-State: AJIora+WUsXLXLJ0aAxNb0ygWVRO7tCLAmeROb0OEsDrtxbrcBsyamd6 3qM3Dbr2WDRPNJg0yamm/xs3HGzRS+1raTiXPFY= X-Google-Smtp-Source: AGRyM1ssjOJFL+htKrn3JXQugk0lHG4U3/M0vG84zdkiEMfNKwmpnAqwxqeS+9YK8MCu7qK4yXupZiU4JKqidp7+adk= X-Received: by 2002:a63:dd56:0:b0:405:34ac:9bc9 with SMTP id g22-20020a63dd56000000b0040534ac9bc9mr13769031pgj.324.1655563179288; Sat, 18 Jun 2022 07:39:39 -0700 (PDT) In-Reply-To: <874k0yyoa4.fsf@gnus.org> Received-SPF: pass client-ip=209.85.215.173; envelope-from=stefankangas@gmail.com; helo=mail-pg1-f173.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291373 Archived-At: Lars Ingebrigtsen writes: > Yes. But it feels a bit awkward to introduce a variable just for this. That's true. > Perhaps we could make an explicit mapping: t to `(not > (docstrings-unicode-quotes ...))' and then introduce a new `emacs-build' > value that's the old t (basically)? That way we could (in the future) > introduce more warnings just for the Emacs build that wouldn't affect > other usages of the byte compiler. I like this approach. It would allow us to introduce experimental byte-compiler warnings: we could introduce new warnings more gently. For example, perhaps the "long docstrings" warning could have started out as experimental for a full major release to allow packages more time to adapt. (Not that it would have likely mattered much but still.)