From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Deleting functions and variables obsolete since 24.1--24.3 Date: Mon, 22 Aug 2022 20:20:21 -0700 Message-ID: References: <86wnb2u1wd.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19357"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, Alan Mackenzie To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 23 05:21:34 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQKTt-0004rS-Uq for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Aug 2022 05:21:33 +0200 Original-Received: from localhost ([::1]:58124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQKTs-0003gh-OC for ged-emacs-devel@m.gmane-mx.org; Mon, 22 Aug 2022 23:21:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37834) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQKSm-0002yD-Tr for emacs-devel@gnu.org; Mon, 22 Aug 2022 23:20:24 -0400 Original-Received: from mail-vs1-xe32.google.com ([2607:f8b0:4864:20::e32]:35405) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQKSl-00007s-Bi for emacs-devel@gnu.org; Mon, 22 Aug 2022 23:20:24 -0400 Original-Received: by mail-vs1-xe32.google.com with SMTP id 67so13229781vsv.2 for ; Mon, 22 Aug 2022 20:20:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc; bh=a5MJQ6+PHpKlRfQuf+3pFDW8hlY0gDjjC1iem0nVABg=; b=YbkLYTdiyaQp+EtanbPWo2VMGiVpSn5zH9/ZFkSHLUEM6+ZuojbmVGo1D49pPIPFHI 4Rv86wZq5VcfYPiRcC6VRu/9UzGT/sZnb2+ei4kkecPVbulHoADS7zF3QyZcv68XLxEX cGfIWo9k+av1++Jp5Z1v6+QT++5j4lEkfKsJnWbzRCSYz+arldT3B0VidZmN4v2ZMwMH 35ckCqpxcQiRfRu5GkjCYt4BIJFdAhCyOOoM+73XPr6Ch65eR1K6ML0TXJgozm/ZftWQ /D45mDfRM9PknmRv189BR+B9rwcCW/bCur0zF3/tmvdGzdzBHinwyUs2Nbk2VJMB65lb pYDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc; bh=a5MJQ6+PHpKlRfQuf+3pFDW8hlY0gDjjC1iem0nVABg=; b=YZpZRMT+ovPwLFa6uPBlvu3QHHkQ2LrSY/HtLqRJYs52o7Ix2KJTbBqg+YK78xAktk s5Q4T2V72krVBUV2v0pdl0lDNhskqFgPBXLFkKNxiK1fH3HhgXkBSyc0phdN6pRKAk3Z gKIGGzh29fLAveyU/TyB9n/RaXcY7x4iLsftTVdGYVkN3DFJ/C2nHmq5OOfZSezk5ENd y4YM8FVWvTLsmSVEGMEU/QaqeFXKzJoLqCPi7LjZA3oG/tbjKmPVHCJjOO1oLhyvx+Rb +/uJ65iFzLGiY4H5xj2c6nxNWR7BGwADNunCMGuOz1ZQhtAg2N92yIJUFMvS1+83VIvm zY2g== X-Gm-Message-State: ACgBeo2wGlZRkWY9uIGODjbSEGVogbmXeVLOhYFGO/kvDcQ3Csx89I+C PB/0P1OD3QZELaERahseWBg2A8dER0mGR9IVMOzcmvpg X-Google-Smtp-Source: AA6agR6EP+n3muL/LK+dJXiPB0MRbGlrrrgiBuqvcrGCMmJx0UFUgd4z5lb5E1xl1aYaoynu+SpNpZYb3jqtqbueHj8= X-Received: by 2002:a67:ab04:0:b0:38a:9cd3:d02e with SMTP id u4-20020a67ab04000000b0038a9cd3d02emr8545435vse.55.1661224822254; Mon, 22 Aug 2022 20:20:22 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 22 Aug 2022 20:20:21 -0700 In-Reply-To: <86wnb2u1wd.fsf@mail.linkov.net> X-Hashcash: 1:20:220823:emacs-devel@gnu.org::KZqRWtYNaBc9J3UL:6xNA Received-SPF: pass client-ip=2607:f8b0:4864:20::e32; envelope-from=stefankangas@gmail.com; helo=mail-vs1-xe32.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293832 Archived-At: Juri Linkov writes: > diff --git a/lisp/proced.el b/lisp/proced.el > index a27638d367..29e2860fba 100644 > --- a/lisp/proced.el > +++ b/lisp/proced.el > @@ -1768,6 +1768,8 @@ proced-with-processes-buffer > (save-window-excursion > ;; Analogous to `dired-pop-to-buffer' > ;; Don't split window horizontally. (Bug#1806) > + ;; FIXME: `dired-pop-to-buffer' was removed. Should we just > + ;; use `pop-to-buffer' here also? > (display-buffer (current-buffer) > '(display-buffer-in-direction > (direction . bottom) > > But the obsolesce message in etc/NEWS.24 informs: > > ** The following functions and variables are obsolete: > *** 'dired-pop-to-buffer' (use 'dired-mark-pop-up') > > So the replacement is 'dired-mark-pop-up' rather than `pop-to-buffer'. Hmm, not sure what the fix is here. Would it be enough to just update the FIXME? diff --git a/lisp/proced.el b/lisp/proced.el index 29e2860fba..a176ebcf91 100644 --- a/lisp/proced.el +++ b/lisp/proced.el @@ -1768,8 +1768,8 @@ proced-with-processes-buffer (save-window-excursion ;; Analogous to `dired-pop-to-buffer' ;; Don't split window horizontally. (Bug#1806) - ;; FIXME: `dired-pop-to-buffer' was removed. Should we just - ;; use `pop-to-buffer' here also? + ;; FIXME: `dired-pop-to-buffer' was removed and replaced with + ;; `dired-mark-pop-up'. (display-buffer (current-buffer) '(display-buffer-in-direction (direction . bottom)