From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master 40dcf9c2ab 4/5: read-multiple-choice: Display "SPC" instead of " " Date: Sun, 26 Dec 2021 09:09:15 -0800 Message-ID: References: <83ee5znx7r.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23997"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 26 18:10:59 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1X2w-0005y2-SC for ged-emacs-devel@m.gmane-mx.org; Sun, 26 Dec 2021 18:10:58 +0100 Original-Received: from localhost ([::1]:36764 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n1X2u-0005Cg-RN for ged-emacs-devel@m.gmane-mx.org; Sun, 26 Dec 2021 12:10:56 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1X1L-0003xx-Iq for emacs-devel@gnu.org; Sun, 26 Dec 2021 12:09:19 -0500 Original-Received: from mail-pj1-f45.google.com ([209.85.216.45]:41879) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n1X1J-0002oF-VK; Sun, 26 Dec 2021 12:09:19 -0500 Original-Received: by mail-pj1-f45.google.com with SMTP id b1-20020a17090a990100b001b14bd47532so12536325pjp.0; Sun, 26 Dec 2021 09:09:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=cXYRMAVTr+p9r7RaDYkGQE/CCEXqplv11SA1gR7wYMI=; b=VbZIsM48lwnXB1g6BC2wGHFtKwfZyCSpfXNVANmfwhUK3ID02DzZ45EtBIqAp4mGYz CZbLbIHxdCWwZ+prFkqcGPXUEknPauLVJzLmrrszm88U1qTZWq/k6EaSxtbt/SERanBc /wrSgYD7B8dzxNOLwVz6IDOh7+fv+U7Gs20ndyOmAYpu4ZG/A+6IXUe34/P/hYRrECnp MZu2LrnO217NvwBtJhRbooChn43GY30kZoHEtEeuxLvqaemV5rmhlv8PFD3GK/BR5nDJ O0hMiftqnHeEZM+fKjERxB0s9kcFWWWFszy/9d1Gpl6/fqus90zzQ87gyvh4EcRcgDRt BCoQ== X-Gm-Message-State: AOAM530WEd4tz99bWv02pizvOaJ0kpN+qv8xITDgQIcQ1t5psvBT+Iua D/nt4jxB/ii9lEsFf9LZG4HBFku4PZOi61hpYgE9La2N X-Google-Smtp-Source: ABdhPJyAOUTZcpqqKSUCjViKN3zhNA4Yo/saN+8D/6OkzpiFUp50f2tnPkKPiQnnanjmB0zI5GrCdghJcciRG2Fy+TA= X-Received: by 2002:a17:90b:4b0e:: with SMTP id lx14mr17270247pjb.132.1640538556131; Sun, 26 Dec 2021 09:09:16 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 26 Dec 2021 09:09:15 -0800 In-Reply-To: <83ee5znx7r.fsf@gnu.org> Received-SPF: pass client-ip=209.85.216.45; envelope-from=stefankangas@gmail.com; helo=mail-pj1-f45.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283341 Archived-At: Eli Zaretskii writes: > I don't think I like the result of this changeset. Now SPC is > displayed as [SPC], in brackets, for a reason I cannot understand. Before this change, SPC in `read-multiple-choice' was displayed as, for example yes; use once ^ Where the indicated space character was underlined. So this is much less confusing, I think. (See below regarding the brackets.) Though when moving `disabled-command' to use `read-multiple-choice' it is true that we did lose the explanation in the old prompt that said: Type y, n, ! or SPC (the space bar): I'm not sure what, if anything we should do about this. One idea is to explain what SPC means at the bottom of the *Disabled Command* buffer. (Personally, I think by the time you stumble upon `disabled-command' you should already be proficient enough to know what SPC means. But I have nothing against being defensive.) > Those brackets get in the way, especially if the Help buffer is > already shown, because there the keys are shown as they should be: > without any brackets. > > This affects novice.el, which is for newbies, and so the instructions > cannot be confusing. > > Why is it a good idea to show some of the responses in brackets? I > say let's remove the brackets altogether, they are not needed, > especially since the keys are already in a special face. Too many > features at once are not necessarily a Good Thing. I think you have a point regarding these brackets, but note that they have always been there with `read-multiple-choice'. We could remove them, I think, but would they still be needed on terminals that can't display underline? Or should we perhaps just use help-key-binding in that case?