From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master ae7fe26 1/3: ; Fix my previous commit Date: Thu, 28 Jan 2021 20:19:14 -0800 Message-ID: References: <20210128210843.30971.34738@vcs0.savannah.gnu.org> <20210128210845.9436B20B72@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10891"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 29 05:20:02 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l5LGL-0002kO-UG for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Jan 2021 05:20:01 +0100 Original-Received: from localhost ([::1]:43306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5LGK-0005tH-SN for ged-emacs-devel@m.gmane-mx.org; Thu, 28 Jan 2021 23:20:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5LFe-0005S2-J2 for emacs-devel@gnu.org; Thu, 28 Jan 2021 23:19:18 -0500 Original-Received: from mail-pg1-f169.google.com ([209.85.215.169]:45557) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l5LFc-0007IM-QJ for emacs-devel@gnu.org; Thu, 28 Jan 2021 23:19:18 -0500 Original-Received: by mail-pg1-f169.google.com with SMTP id v19so5768591pgj.12 for ; Thu, 28 Jan 2021 20:19:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=zlMUNCal/7OPJ5EmgYflDSbF2TxWDi5yZ1bTiJv6DBg=; b=pN0nzjGagOzTaq2xjVqUfb3cLuUDSZo7Ni1Edxs1jJ0JlQB8HWG2VGJxR37EuDzItl uk1Ey9UWSDtKGEF2aJOVLOMslaTHxd7Id4DU1kvs9kvG81dwytEmQaL/OxuzA5+861Wl lzpoW5rEjSEOc8dKgg9+ECWNouTFeLyi9gDnhnrGuubtXpJduY7uNJr0xtCSPe2p3zAW XZ3RnGHm7rTH3ysoiOcRsw0iV88ZsJu8gRpIJZi8cfMUAymcYgfvJRTkKYYUSRmEWH7t Mg/ZJAzntrkQXzLyjYTNpIssmELnjTqhIw70p97otJZL/nN3LCF3WVc+V5R/gl7T4C+o Ks8g== X-Gm-Message-State: AOAM533f2a8DsAnbKZDUXaQbaDsseGXP29a4A00O9pyVIDLIZG8/Uj89 pfcU0gvLcd9TLqz1I5rfWmgcFaQKkuYxjLO25Xg= X-Google-Smtp-Source: ABdhPJzEaV8ZsDD4/H2IbYAdfy0HpxYNar+SJ9Yd0fHuHjEeESEjrgwlmcidnSctuaNRh53xCtTYO37FxpMEW+C0h6Y= X-Received: by 2002:a63:e108:: with SMTP id z8mr2710311pgh.363.1611893954788; Thu, 28 Jan 2021 20:19:14 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 28 Jan 2021 20:19:14 -0800 In-Reply-To: Received-SPF: pass client-ip=209.85.215.169; envelope-from=stefankangas@gmail.com; helo=mail-pg1-f169.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263565 Archived-At: Stefan Monnier writes: >> * lisp/generic-x.el (generic-mode-ini-file-find-file-hook): Fix my >> previous commit; for some reason 'function' produces a warning here >> while 'quote' does not. > [...] >> (define-obsolete-function-alias 'generic-mode-ini-file-find-file-hook >> - #'ini-generic-mode-find-file-hook "28.1")) >> + 'ini-generic-mode-find-file-hook "28.1")) > > The problem is that most of the `defun`s in this file are not at top > level but inside a `when`. This is ugly and should be fixed. Yes, that was my diagnosis as well. I suppose one could argue that this warning is a bug, but it hardly seems worth fixing: this use-case is not something we should encourage. So I installed the workaround. > We should throw out `generic-extras-enable-list`. Agreed. I guess it only exists for historical reasons? BTW, is there any reason why the modes in generic-x.el are not autoloaded and in auto-mode-alist? I did not know that (require 'generic-x) was a thing until today, and I do remember at times missing the syntax highlighting of some of the files it supports.