From: Stefan Kangas <stefan@marxist.se>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master ae7fe26 1/3: ; Fix my previous commit
Date: Thu, 28 Jan 2021 20:19:14 -0800 [thread overview]
Message-ID: <CADwFkmkER6ZkMnd=-bEZKhDtKwEBR44quW0U7YxbMkiOFw+oaQ@mail.gmail.com> (raw)
In-Reply-To: <jwv8s8cveoy.fsf-monnier+emacs@gnu.org>
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> * lisp/generic-x.el (generic-mode-ini-file-find-file-hook): Fix my
>> previous commit; for some reason 'function' produces a warning here
>> while 'quote' does not.
> [...]
>> (define-obsolete-function-alias 'generic-mode-ini-file-find-file-hook
>> - #'ini-generic-mode-find-file-hook "28.1"))
>> + 'ini-generic-mode-find-file-hook "28.1"))
>
> The problem is that most of the `defun`s in this file are not at top
> level but inside a `when`. This is ugly and should be fixed.
Yes, that was my diagnosis as well. I suppose one could argue that this
warning is a bug, but it hardly seems worth fixing: this use-case is not
something we should encourage. So I installed the workaround.
> We should throw out `generic-extras-enable-list`.
Agreed. I guess it only exists for historical reasons?
BTW, is there any reason why the modes in generic-x.el are not
autoloaded and in auto-mode-alist? I did not know that (require
'generic-x) was a thing until today, and I do remember at times missing
the syntax highlighting of some of the files it supports.
next prev parent reply other threads:[~2021-01-29 4:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210128210843.30971.34738@vcs0.savannah.gnu.org>
[not found] ` <20210128210845.9436B20B72@vcs0.savannah.gnu.org>
2021-01-28 23:14 ` master ae7fe26 1/3: ; Fix my previous commit Stefan Monnier
2021-01-29 4:19 ` Stefan Kangas [this message]
2021-01-29 5:09 ` Stefan Monnier
2021-01-30 14:45 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmkER6ZkMnd=-bEZKhDtKwEBR44quW0U7YxbMkiOFw+oaQ@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).