From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master 97679d06e8 1/2: Avoid an unnecessary call to intern Date: Mon, 19 Sep 2022 09:23:35 -0400 Message-ID: References: <166358035244.5217.7919161622861356432@vcs2.savannah.gnu.org> <20220919093912.CB62CC0270B@vcs2.savannah.gnu.org> <87pmfroe96.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18028"; mail-complaints-to="usenet@ciao.gmane.io" To: Po Lu , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 19 15:25:14 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaGlu-0004Y6-4y for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Sep 2022 15:25:14 +0200 Original-Received: from localhost ([::1]:42458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oaGls-0003LT-SF for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Sep 2022 09:25:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38540) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaGkM-0000dV-EL for emacs-devel@gnu.org; Mon, 19 Sep 2022 09:23:38 -0400 Original-Received: from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]:43896) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oaGkK-00071f-Up for emacs-devel@gnu.org; Mon, 19 Sep 2022 09:23:38 -0400 Original-Received: by mail-oi1-x22d.google.com with SMTP id t62so14579479oie.10 for ; Mon, 19 Sep 2022 06:23:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date; bh=fcUtIiF6Sf+6eebWaCQy2mnOKICEepO5E6vZbhwcBEk=; b=Snyd++EOji9PYPzczTKjQ9+j+K6u0qU+rL/sVosfZp2S9ozeiT22QEC0FhDYrTJidK NZU37Vr0Lvv4DM0b7lP+PIpHG7mzdyabIrIvnPSIx9wlIUbBSi+VOqaqJehtN0D149UH m0HtRPoUYIl7+hcn5XIZDmftd5ImENeye08z2GQI6CPEQjlElk4JdUO4HToKXxuf2H06 zgV4mMOdkDkft1iNYiDzq+W335ppw/JKFRSyHSLvlA/RYU+ViuHdg5sZptagapAh10K7 +gpNZVfI+pxBpYS2tyJoO8VQxdYFJyKkwSIBn3Zed8klk23S1PmeWBq3PUXOZCTkGa+z 0AtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date; bh=fcUtIiF6Sf+6eebWaCQy2mnOKICEepO5E6vZbhwcBEk=; b=JUorhJDgZsaFDliGUqTakksqcN19pSFiFjWL9dUmftiz1lfAin60vZbH1oRaemz5Gq yrM03FQ1B3UorUwhxpn2PPl1L0drBKtzlfzjFDL4eFf9rdTDTOwSZ5ACtLEY9NqwsRUr XEfzB4eB2uV6Gy/lhnHxQNEpDMLsBNo9Fw5m2JXj0ptlpMO+JsJjY7qOA6CpALv26UIp VPkS1pMwT4jyr3bbGugW9dBCXPPuviPAzxbwyzCyRg75INR7DsQq1MIC8YEh6bAOmOle TbMIE7lvgTlaRzz+KTJjU8U8uhP+/2imt2pwHqa5qsufBo5xYFtgcp0K6E+N6cTiHt9+ lujA== X-Gm-Message-State: ACgBeo2uVtT5g+XqNlU6Q49QBmTOS/WnSSsX4U9s2OtDTZFbQAxMK5MS W5R/cw9kPhG6DCsfHwZGuy/qjpRnn6Kh+iZUqEMri8o5 X-Google-Smtp-Source: AA6agR701D5uYV60/bdykD1Sta/xVDZbHG8TLUk8F7PeBYbcAOLtwHYXWHkTcEIzW0fXYRJCsCRqq7c5261B3jU4BEI= X-Received: by 2002:a05:6808:1a09:b0:350:1e6a:e469 with SMTP id bk9-20020a0568081a0900b003501e6ae469mr10663674oib.92.1663593815766; Mon, 19 Sep 2022 06:23:35 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 19 Sep 2022 09:23:35 -0400 In-Reply-To: <87pmfroe96.fsf@yahoo.com> X-Hashcash: 1:20:220919:luangruo@yahoo.com::oENtuM/4DlVXiQ2v:EwK3 Received-SPF: pass client-ip=2607:f8b0:4864:20::22d; envelope-from=stefankangas@gmail.com; helo=mail-oi1-x22d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295693 Archived-At: Po Lu writes: >> * src/doc.c (Fdocumentation): Prefer DEFSYM to using intern directly. > > Maybe we should get rid of all of the calls to intern with a static > string in one go? Sounds good to me. > I think leaving them there is really just a waste of cycles. Getting rid of them also gives us compile-time error checking, which is nice.