From: Stefan Kangas <stefankangas@gmail.com>
To: Jim Porter <jporterbugs@gmail.com>,
Thierry Volpiatto <thievol@posteo.net>
Cc: emacs-devel@gnu.org
Subject: Re: master 7f631a3e2ac: Allow using multiple buffers in 'eshell-command'
Date: Sat, 6 Jul 2024 10:15:13 -0700 [thread overview]
Message-ID: <CADwFkmk3UcQ2oL107=Ne3Dqv0-7i+s8yCbMyXnLaxf43RExRCg@mail.gmail.com> (raw)
In-Reply-To: <20240706024807.B74E4C1FB6A@vcs2.savannah.gnu.org>
Jim Porter <jporterbugs@gmail.com> writes:
> branch: master
> commit 7f631a3e2aca97e95b8659c902c25ab21f084e08
> Author: Thierry Volpiatto <thievol@posteo.net>
> Commit: Jim Porter <jporterbugs@gmail.com>
>
> Allow using multiple buffers in 'eshell-command'
>
> Provide the same functionality as 'async-shell-command-buffer' but for
> 'eshell-command'.
>
> Co-Authored-By: Jim Porter <jporterbugs@gmail.com>
>
> * lisp/eshell/eshell.el (eshell-command-async-buffer): New option...
> (eshell-command): ... use it.
>
> * lisp/eshell/esh-proc.el (eshell-sentinel): Check for buffer liveness
> in 'finish-io'.
>
> * test/lisp/eshell/eshell-tests.el
> (eshell-test/eshell-command/output-buffer/async-kill): New test.
This new test is failing here:
Test eshell-test/eshell-command/output-buffer/async-kill backtrace:
rename-buffer("*Eshell Async Command Output*" nil)
eshell-command("*echo bye &")
#f(compiled-function () #<bytecode -0x9447a45fbdbd42>)()
#f(compiled-function () #<bytecode 0x4e527f523db3b2e>)()
handler-bind-1(#f(compiled-function () #<bytecode 0x4e527f523db3b2e>
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name eshell-test/eshell-command/output-buf
ert-run-or-rerun-test(#s(ert--stats :selector (not ...) :tests [...
ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
command-line()
normal-top-level()
Test eshell-test/eshell-command/output-buffer/async-kill condition:
(error "Buffer name ‘*Eshell Async Command Output*’ is in use")
FAILED 5/16 eshell-test/eshell-command/output-buffer/async-kill
(0.005699 sec) at lisp/eshell/eshell-tests.el:120
next parent reply other threads:[~2024-07-06 17:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <172023408734.9826.6615246233994903888@vcs2.savannah.gnu.org>
[not found] ` <20240706024807.B74E4C1FB6A@vcs2.savannah.gnu.org>
2024-07-06 17:15 ` Stefan Kangas [this message]
2024-07-06 19:47 ` master 7f631a3e2ac: Allow using multiple buffers in 'eshell-command' Jim Porter
2024-07-06 21:17 ` Jim Porter
2024-07-10 0:32 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmk3UcQ2oL107=Ne3Dqv0-7i+s8yCbMyXnLaxf43RExRCg@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=jporterbugs@gmail.com \
--cc=thievol@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).