From: Stefan Kangas <stefankangas@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-29 e2ac0d416b9 1/5: ; Merge from origin/emacs-28
Date: Mon, 20 Feb 2023 08:50:10 -0800 [thread overview]
Message-ID: <CADwFkm=ziAJQ7dyBZCnt9C5EozggQCyDQEtxbgrzVxu7VWAs2A@mail.gmail.com> (raw)
In-Reply-To: <83fsb1wmeh.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> git diff 068b53500e24b7b..ad6c6a3a11569c4
>
> Why would we need to eyeball all those changes now? It's a wasted
> effort. We never merge to the release branch, never.
I already eyeballed all of those changes, so there's no need for you to
do it too. Here's a summary of the changes:
$ git diff -b --stat 068b53500e24b7b..ad6c6a3a11569c4
ChangeLog.3 | 430 +++++++++++++++++++++++++++++++++++++-
etc/AUTHORS | 24 +--
etc/HISTORY | 2 +
3 files changed, 443 insertions(+), 13 deletions(-)
> You will recreate those as part of tarring Emacs 29 anyway, so why
> merge them?
You left out the part of my message where I explained this, but a merge
preserves history and tags. That's generally why you merge instead of
simply copying files. It also happens to be more convenient.
> It is simply unnecessary risk, and something we never do, for very
> good reasons. I'd sleep better if you'd reverted those changes on
> emacs-29, and made the single change in HISTORY by hand.
The risk is minimal, since we're only changing documentation files and
not code. There is also a big gain in simplicity. These are standard
git operations, after all.
next prev parent reply other threads:[~2023-02-20 16:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-19 17:05 emacs-29 e2ac0d416b9 1/5: ; Merge from origin/emacs-28 Eli Zaretskii
2023-02-19 17:31 ` Stefan Kangas
2023-02-19 18:16 ` Eli Zaretskii
2023-02-20 16:50 ` Stefan Kangas [this message]
2023-02-20 17:18 ` Eli Zaretskii
2023-02-21 9:53 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=ziAJQ7dyBZCnt9C5EozggQCyDQEtxbgrzVxu7VWAs2A@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).