From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Concern about new binding. Date: Wed, 3 Feb 2021 18:41:39 -0600 Message-ID: References: <20210202134950.vybbpf3iewbymfjo.ref@Ergus> <20210202134950.vybbpf3iewbymfjo@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37999"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Gregory Heytings , Richard Stallman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 04 01:45:45 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7SmG-0009nb-Sc for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Feb 2021 01:45:44 +0100 Original-Received: from localhost ([::1]:34192 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7SmF-0005he-RE for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Feb 2021 19:45:43 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59790) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7SiP-0002RA-Mr for emacs-devel@gnu.org; Wed, 03 Feb 2021 19:41:45 -0500 Original-Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]:34902) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l7SiN-0003xF-7N; Wed, 03 Feb 2021 19:41:45 -0500 Original-Received: by mail-pl1-x633.google.com with SMTP id g3so824438plp.2; Wed, 03 Feb 2021 16:41:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=vBjDSsYldxHXCKeoh5n6luv534gwB3JP97ddjJmgaNI=; b=DbBUHzqbZyWCmonkFV9hThKeaojeQVm1623D/IsEatVf6creS3A+/YdmC47IAuhl9H QNIQTh2jC8j6bGKo2WcwNeU+EKquiiUo3gT2D1vw9jDAZlwUFjDPs6xInkRqfmTCa9UC BeD4F85tV0LsrH8viv8UTBWOaeeR9zR8eGurtKBZg1TXlAWUWX/4e6yVCVqarXU7RTxe S7qE4fxO+xMdaubagtp106GVs2vq7ma8UbN4NYwUrNeMvM6OIu0JClJUqVbLRtRB4ZRJ RhkdrTYuS2WqXZHj9GaRUxUxxNyg5zFSoSHaP+ARmD9y27pfMiaufiTLbvxnHzJeafFZ 8ONw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=vBjDSsYldxHXCKeoh5n6luv534gwB3JP97ddjJmgaNI=; b=o3LZNPkZK0aaTso+pU6iWS7dcrSdgDE6/CjZdrApsbpiiutSyMow1MzyA5jcxyWVDV 879Z/NGeTOfx4R4LZ/kWrtBAW66SDnnnusHEiHI9M47QdzG2gflAXxpcqxzCpX8C28iQ WE6vMY0zHJeitkSzkrNVkY2797OgYLLEFUziO0SeaejMX74knx0rok5keIxQnyykklwZ IJtUz6ActXoi7izv5C1hOS/+bqkTDgpfADgWRFAX8isBvUnZ6My2X3zz2+LFYCA2hxdN 0lRS/UkwyKcq3noHPYflz36/DQZSu3usmMuCmHE9YTtj5p9Ei7fsHKgTN3qeUcNVqwua O9IA== X-Gm-Message-State: AOAM5317ydFP+6Dyhl0Es74e8TqJHCVvtKTLtpGE48kGrhSqZVXPo5Nj 78GY2iOu5VQsbFPnvEjvBghQWPXDNViCsUiDBYbR7phu X-Google-Smtp-Source: ABdhPJwsKgWG7XMu8FNYjZDcNb4twRIbMVvuZxnTGGFVoDntK5MRjNDYg5YPUa5fw37GjDi4CJvVzD/RTXtb8c4etEE= X-Received: by 2002:a17:90a:5c81:: with SMTP id r1mr5672259pji.175.1612399300253; Wed, 03 Feb 2021 16:41:40 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 3 Feb 2021 18:41:39 -0600 In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=stefankangas@gmail.com; helo=mail-pl1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263827 Archived-At: Gregory Heytings writes: >>> In a recent commit I see that the C-x g binding was taken for >>> revert-buffer. >> >> I see another disadvantage in that binding: revert-buffer is a drastic >> operation, so we should not make it easier. I think it is wiser not to >> put it on a key -- which is why I never did. >> FWIW, I think this is the correct idea here. In particular, I think `C-x g' is an unfortunate keybinding, as it is too easy to make a drastic mistake. If we need to have a keybinding, I like the idea of something like `C-x M-u' more. > It's true that it is a drastic operation, but it asks for confirmation, > and it can be undone. AFAIK, that depends on the size of your changes and the value of `undo-limit', `undo-strong-limit' and `undo-outer-limit'. > An additional security measure would be to disable it by default: (put > 'revert-buffer 'disabled t). I think making it easy to type only to make it harder to use would be both contradictory and self-defeating.