From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: New library wallpaper.el pushed to master Date: Wed, 14 Sep 2022 00:13:02 -0700 Message-ID: References: <837d2743lt.fsf@gnu.org> <835yhr42bj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35107"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 14 09:18:01 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYMem-0008rw-Pf for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Sep 2022 09:18:00 +0200 Original-Received: from localhost ([::1]:36084 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYMel-0000pn-Eo for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Sep 2022 03:17:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYMa2-000728-Mn for emacs-devel@gnu.org; Wed, 14 Sep 2022 03:13:09 -0400 Original-Received: from mail-ot1-x330.google.com ([2607:f8b0:4864:20::330]:40607) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oYMa0-0002uC-SR; Wed, 14 Sep 2022 03:13:06 -0400 Original-Received: by mail-ot1-x330.google.com with SMTP id r13-20020a056830418d00b0065601df69c0so4347847otu.7; Wed, 14 Sep 2022 00:13:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date; bh=90n/nmjghgM0Rc2vxpOZiW3RI1KKpcaBpuLtRkNYYz0=; b=jTrxb0EFBB4k63ljZX0xtlLJyokIdY7QBQEH3h211ftjHh7QGFwZLMWNCfhTH+c07E OJAV6sknNTCKvOVXwc2zLCHLed9micUZ3fmUD9ZKZY4UMcwHkIcTrwosgltQmqLYpI80 u3/5Uv39jWlgkrX6PxRfVPK35qUL4PCOQhT4+opgp4ddVkHBsrwHbY5EwXzCDcwV3ivB sgxMXfV55d6Vu+yVNjoloVtPCLUWy8PDAWFdFdaXagK7BU2YOOqE/3CKrSXZxwTCBHPJ c23DEPQ70qIYK7QVvcf6u1bn22y3fuUMSxUbat0xq2q2YUX6Rt7RYk9fH1MQmfbZTdC3 +TSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date; bh=90n/nmjghgM0Rc2vxpOZiW3RI1KKpcaBpuLtRkNYYz0=; b=CpzpBDqwASsaQXX2GwW+3SWBdE7ANnKvV3hmpBXXi2+DVd43QZxSjFkllDx4u68c9t Bl2Pm0kN0k8S+E3XchUu6OHPtaJE/5soikoKY09aOopU58FqXkyC1gSQE85m73ApVpl2 YJYt7n5Wdz57yh7Mi4ReCXhDjYaz4MugFvqIXJ07WeWPBN7GZxILzaeiq271/a9MXDwB IUmNoisOUso5PMQlFf36EgKfFCNhEae2tIzU6mU3ShcKfKDzToUyGjiCZn9uJRT9/IGN cgJUBxb83ySVPOxrJM5fYxc6Y813uGpPiTgC8/2D8GeMVIfyzwD8zrhGyz95U8A0labz gH4g== X-Gm-Message-State: ACgBeo2FD65EA52vnZtV6bKJn8TCeIWqKJ26ORT+N09vlKO4Z6MSFqq1 +cp3gAK5X7rp9ZrBWRDrgCl6bwQM+6Sw6Aub8bpuNt21 X-Google-Smtp-Source: AA6agR6A7EX3FXgfIR80G8bgYpNW/2IGA004iYYiLu5lLCvNqtw2M+R7AkY4Md9KXY7xlRzakvE+iUuYTppRjVo5Rus= X-Received: by 2002:a05:6830:3c1:b0:637:28be:7920 with SMTP id p1-20020a05683003c100b0063728be7920mr14013056otc.105.1663139582959; Wed, 14 Sep 2022 00:13:02 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 14 Sep 2022 00:13:02 -0700 In-Reply-To: <835yhr42bj.fsf@gnu.org> X-Hashcash: 1:20:220914:eliz@gnu.org::YItnivNrlowne1Yw:0vK2 Received-SPF: pass client-ip=2607:f8b0:4864:20::330; envelope-from=stefankangas@gmail.com; helo=mail-ot1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295299 Archived-At: Eli Zaretskii writes: > I though that would be considered unclean, given that you deployed the > cl-defgeneric machinery there. At the very least, it would mean w32 > users will not be able to use external programs to do the job, even if > they do have such a program. Is that acceptable? I don't know; I don't use MS-Windows. But if we can do it natively, perhaps it is acceptable to not be able to use an external command. If we're fine with that limitation, I see that Po Lu added support for Haiku, and I think MS-Windows could do something similar to that. > Also, the display-graphic-p requirement is IMO a gratuitous > restriction, since one can invoke these external programs from an > Emacs running in a terminal emulator as well, I presume. Please see my reply to Po Lu regarding this. > The reason you needed display-graphic-p is that you rely on > display-pixel-height, but is that really such an important > requirement? why not let people specify the height manually? Indeed, that could be changed. > I actually thought about computing the value of the defcustom > dynamically at run time, trying each candidate until one is found. > The template for the command's arguments doesn't need to be in the > value, you can use a separate default template for each executable. > Then all users will have to do is to specify a name of a program, and > perhaps a few optional command-line switches. I like this idea. Let me see what I can come up with.