* Re: master bfa951cdfa: Fix invalid current buffer after print-unreadable-function signals
[not found] ` <20220727094240.C94FEC0F1E3@vcs2.savannah.gnu.org>
@ 2022-07-27 9:54 ` Lars Ingebrigtsen
2022-07-28 8:14 ` Stefan Kangas
0 siblings, 1 reply; 8+ messages in thread
From: Lars Ingebrigtsen @ 2022-07-27 9:54 UTC (permalink / raw)
To: Po Lu via Mailing list for Emacs changes; +Cc: Po Lu
Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
> Fix invalid current buffer after print-unreadable-function signals
>
> * src/print.c (PRINTPREPARE): Remove `old' and
> record_unwind_current_buffer instead.
> (PRINTFINISH): Stop restoring `old'. (bug#56773)
This apparently leads to:
1 unexpected results:
FAILED terpri
in print-tests.el.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: master bfa951cdfa: Fix invalid current buffer after print-unreadable-function signals
2022-07-27 9:54 ` master bfa951cdfa: Fix invalid current buffer after print-unreadable-function signals Lars Ingebrigtsen
@ 2022-07-28 8:14 ` Stefan Kangas
2022-07-28 8:31 ` Eli Zaretskii
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Kangas @ 2022-07-28 8:14 UTC (permalink / raw)
To: Lars Ingebrigtsen, Po Lu via Mailing list for Emacs changes; +Cc: Po Lu
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
>
>> Fix invalid current buffer after print-unreadable-function signals
>>
>> * src/print.c (PRINTPREPARE): Remove `old' and
>> record_unwind_current_buffer instead.
>> (PRINTFINISH): Stop restoring `old'. (bug#56773)
>
> This apparently leads to:
>
> 1 unexpected results:
> FAILED terpri
>
> in print-tests.el.
If there is no quick fix, could we please revert the change?
It's currently stopping me from merging emacs-28 to master.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: master bfa951cdfa: Fix invalid current buffer after print-unreadable-function signals
2022-07-28 8:14 ` Stefan Kangas
@ 2022-07-28 8:31 ` Eli Zaretskii
2022-07-28 8:47 ` Stefan Kangas
0 siblings, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2022-07-28 8:31 UTC (permalink / raw)
To: Stefan Kangas; +Cc: larsi, emacs-devel, luangruo
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Thu, 28 Jul 2022 01:14:30 -0700
> Cc: Po Lu <luangruo@yahoo.com>
>
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
> > Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
> >
> >> Fix invalid current buffer after print-unreadable-function signals
> >>
> >> * src/print.c (PRINTPREPARE): Remove `old' and
> >> record_unwind_current_buffer instead.
> >> (PRINTFINISH): Stop restoring `old'. (bug#56773)
> >
> > This apparently leads to:
> >
> > 1 unexpected results:
> > FAILED terpri
> >
> > in print-tests.el.
>
> If there is no quick fix, could we please revert the change?
>
> It's currently stopping me from merging emacs-28 to master.
Why does it prevent a merge?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: master bfa951cdfa: Fix invalid current buffer after print-unreadable-function signals
2022-07-28 8:31 ` Eli Zaretskii
@ 2022-07-28 8:47 ` Stefan Kangas
2022-07-28 8:59 ` Eli Zaretskii
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Kangas @ 2022-07-28 8:47 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: larsi, emacs-devel, luangruo
Eli Zaretskii <eliz@gnu.org> writes:
> Why does it prevent a merge?
Because the tests are failing, and admin/automerge doesn't like that.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: master bfa951cdfa: Fix invalid current buffer after print-unreadable-function signals
2022-07-28 8:47 ` Stefan Kangas
@ 2022-07-28 8:59 ` Eli Zaretskii
2022-07-28 9:14 ` Stefan Kangas
0 siblings, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2022-07-28 8:59 UTC (permalink / raw)
To: Stefan Kangas; +Cc: larsi, emacs-devel, luangruo
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Thu, 28 Jul 2022 01:47:47 -0700
> Cc: larsi@gnus.org, emacs-devel@gnu.org, luangruo@yahoo.com
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Why does it prevent a merge?
>
> Because the tests are failing, and admin/automerge doesn't like that.
I think you are taking this too seriously. A known failure on master
shouldn't hold off the merge, IMO. Can't you ignore the test failure?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: master bfa951cdfa: Fix invalid current buffer after print-unreadable-function signals
2022-07-28 8:59 ` Eli Zaretskii
@ 2022-07-28 9:14 ` Stefan Kangas
2022-07-28 9:25 ` Eli Zaretskii
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Kangas @ 2022-07-28 9:14 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Lars Ingebrigtsen, Emacs developers, Po Lu
Eli Zaretskii <eliz@gnu.org> writes:
> I think you are taking this too seriously. A known failure on master
> shouldn't hold off the merge, IMO. Can't you ignore the test failure?
Sure, it's a bit more work is all. It's not the end of the world, but
I'd prefer if we could avoid breaking the test suite on master
instead.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: master bfa951cdfa: Fix invalid current buffer after print-unreadable-function signals
2022-07-28 9:14 ` Stefan Kangas
@ 2022-07-28 9:25 ` Eli Zaretskii
2022-07-28 9:32 ` Stefan Kangas
0 siblings, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2022-07-28 9:25 UTC (permalink / raw)
To: Stefan Kangas; +Cc: larsi, emacs-devel, luangruo
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Thu, 28 Jul 2022 11:14:57 +0200
> Cc: Lars Ingebrigtsen <larsi@gnus.org>, Emacs developers <emacs-devel@gnu.org>, Po Lu <luangruo@yahoo.com>
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > I think you are taking this too seriously. A known failure on master
> > shouldn't hold off the merge, IMO. Can't you ignore the test failure?
>
> Sure, it's a bit more work is all. It's not the end of the world, but
> I'd prefer if we could avoid breaking the test suite on master
> instead.
But you aren't breaking the test suite, it's already broken.
The part of automerge that runs the test suite is meant to ensure that
the merge doesn't introduce new regressions. This is not that case.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: master bfa951cdfa: Fix invalid current buffer after print-unreadable-function signals
2022-07-28 9:25 ` Eli Zaretskii
@ 2022-07-28 9:32 ` Stefan Kangas
0 siblings, 0 replies; 8+ messages in thread
From: Stefan Kangas @ 2022-07-28 9:32 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Lars Ingebrigtsen, Emacs developers, Po Lu
Eli Zaretskii <eliz@gnu.org> writes:
> The part of automerge that runs the test suite is meant to ensure that
> the merge doesn't introduce new regressions. This is not that case.
Of course, but it the script is too primitive to decide if the
regression is new or not. So every time it happens, I need to
intervene manually.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-07-28 9:32 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <165891496054.3950.2967202128456340980@vcs2.savannah.gnu.org>
[not found] ` <20220727094240.C94FEC0F1E3@vcs2.savannah.gnu.org>
2022-07-27 9:54 ` master bfa951cdfa: Fix invalid current buffer after print-unreadable-function signals Lars Ingebrigtsen
2022-07-28 8:14 ` Stefan Kangas
2022-07-28 8:31 ` Eli Zaretskii
2022-07-28 8:47 ` Stefan Kangas
2022-07-28 8:59 ` Eli Zaretskii
2022-07-28 9:14 ` Stefan Kangas
2022-07-28 9:25 ` Eli Zaretskii
2022-07-28 9:32 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).