unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
Subject: Tests and linting not coupled to one file (was: Re: master 664927b: Add an expensive test for defcustom types)
Date: Fri, 25 Sep 2020 06:11:32 -0700	[thread overview]
Message-ID: <CADwFkm=qHi-9=O6YtCEZUqG3o3NSZuoGd49o1c_RPfXSW9V5HQ@mail.gmail.com> (raw)
In-Reply-To: <20200925124647.83150209D4@vcs0.savannah.gnu.org>

larsi@gnus.org (Lars Ingebrigtsen) writes:

> branch: master
> commit 664927b5257fdaf26f24063edb1f41c407805ed8
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
>     Add an expensive test for defcustom types
>
>     * admin/cus-test.el (cus-test-opts): Return the tests.
>
>     * test/lisp/custom-tests.el (check-for-wrong-custom-types): Test
>     custom types (bug#30990).

Thanks.

I have been thinking about what to with this kinds of expensive
tests/linting.  It is of course good that we now run the above
automatically, since it will help us catch bugs.  But it isn't very
clean conceptually to add such a test to "custom-tests.el", since it
operates on the entire code base instead of just one file/component.

One idea I've had is to create a new directory "test/misc" or something
to keep such tests in.  We could arrange for them to be run with
"check-expensive" and continue using ert to get standardized reporting,
etc.

The custom tests are good candidates here, but there are others.



       reply	other threads:[~2020-09-25 13:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200925124646.29315.84502@vcs0.savannah.gnu.org>
     [not found] ` <20200925124647.83150209D4@vcs0.savannah.gnu.org>
2020-09-25 13:11   ` Stefan Kangas [this message]
2020-09-25 13:46     ` Tests and linting not coupled to one file Lars Ingebrigtsen
2020-09-25 15:36       ` Stefan Kangas
2020-09-26 13:38         ` Lars Ingebrigtsen
2021-02-21 10:37           ` Stefan Kangas
2021-02-21 13:18             ` Lars Ingebrigtsen
2021-02-21 19:34               ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkm=qHi-9=O6YtCEZUqG3o3NSZuoGd49o1c_RPfXSW9V5HQ@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).