From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Zero byte-compiler warnings in the test suite Date: Tue, 21 Dec 2021 05:39:08 -0800 Message-ID: References: <87ilvigl3z.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16008"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 21 14:43:07 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mzfQ3-0003z8-HV for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Dec 2021 14:43:07 +0100 Original-Received: from localhost ([::1]:36292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mzfQ1-0007xA-EJ for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Dec 2021 08:43:05 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzfMF-0005Eu-QE for emacs-devel@gnu.org; Tue, 21 Dec 2021 08:39:13 -0500 Original-Received: from mail-pf1-f174.google.com ([209.85.210.174]:46802) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mzfME-0001XX-83 for emacs-devel@gnu.org; Tue, 21 Dec 2021 08:39:11 -0500 Original-Received: by mail-pf1-f174.google.com with SMTP id t123so10402105pfc.13 for ; Tue, 21 Dec 2021 05:39:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=hN8tY7vnOlvrk/+oTRJjPQbKSnLfK+yvnpEzx9Z5jYM=; b=jW7rUAR6je+KWOPDNwQAiu4lAztic5ONbEbzWJN0MBpHAyIc8BOi3/dQkjB/ZEM+Nj K4TkvSzFAMNYvERZU5MrBaY2CvhVwnipIngU+kSA1pO5aMcmP5VDJJNIKhOyuQxsR24N iLCT/oTzK4tltj6FJ8hlSRtZpd7AamuYbQBXiD+HUboyah196j8Vo8oo3358HouR3hNg ZwXM4p3RAZMf0fYevPwsMNmafZC2ACtBMylvPHOBTBp0f3RDP7fTalz5wdlwnjiheDFz WlrABT9LqW8ZDivMELF1PU1g4o6A208cUM3mMlIr16GMnplnTkB/PPqUX/UZjTETRajE wm1w== X-Gm-Message-State: AOAM530qBfPvbhfPuqRFqN0QLOJZEcIIOaEerDicAMS1AB2t+oU13iUv sjjpvSasi1DT9lEA17aUbxTK2FtFXg5l8/jCWqw= X-Google-Smtp-Source: ABdhPJxOFUbHGXhAaFeNppjlLmlCtx3B5pGOhkXDBmzcqkSxAjwYIIHSy8jvW9PQiI+CdV0lDC+x3pS1ciosBKzLVG4= X-Received: by 2002:a63:4b42:: with SMTP id k2mr1768406pgl.591.1640093948981; Tue, 21 Dec 2021 05:39:08 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 21 Dec 2021 05:39:08 -0800 In-Reply-To: <87ilvigl3z.fsf@gnus.org> Received-SPF: pass client-ip=209.85.210.174; envelope-from=stefankangas@gmail.com; helo=mail-pf1-f174.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:282583 Archived-At: Lars Ingebrigtsen writes: > But with a native-comp build (at least), I'm getting two > warnings/errors on the current trunk: > > In toplevel form: > lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:273:1: Warning: = =E2=80=98defgeneric=E2=80=99 is an obsolete macro (as of 25.1); use =E2=80= =98cl-defgeneric=E2=80=99 instead. Strange, I don't see that here (with native-comp). Does this help? diff --git a/test/lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el b/test/lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el index e881e46a2d..bc89f23b58 100644 --- a/test/lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el +++ b/test/lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el @@ -271,6 +271,7 @@ E-base2 (defclass E (E-base1 E-base2) () :method-invocation-order :breadth-first) (with-suppressed-warnings ((obsolete defmethod) + (obsolete defgeneric) (obsolete next-method-p) (obsolete call-next-method)) (defmethod eitest-F ((_p E)) > Compiler-macro error for cl-typep: (error "Unknown type notatype") > Compiler-macro error for cl-typep: (error "Unknown type notatype") > Compiler-macro error for cl-typep: (error "Unknown type notatype") > Compiler-macro error for cl-typep: (error "Unknown type notatype") > Compiler-macro error for cl-typep: (error "Unknown type notatype") I've seen these as well, but they weren't counted by compilation-mode so I just sort of ignored them. It would be good to fix them as well of course. AFAICT, they come from here: ELC+ELN lisp/emacs-lisp/pcase-tests.elc Compiler-macro error for cl-typep: (error "Unknown type notatype") Compiler-macro error for cl-typep: (error "Unknown type notatype") Compiler-macro error for cl-typep: (error "Unknown type notatype") Compiler-macro error for cl-typep: (error "Unknown type notatype") Compiler-macro error for cl-typep: (error "Unknown type notatype") GEN lisp/emacs-lisp/pcase-tests.log Grepping for notatype leads me to: ./lisp/emacs-lisp/pcase-tests.el:111: ((cl-type notatype) 'integer)))) Does anyone know what is going on here?