From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master 80abaea: Use lexical-binding in lunar.el and add tests Date: Sun, 7 Jun 2020 23:49:40 -0700 Message-ID: References: <20200607190128.16579.5580@vcs0.savannah.gnu.org> <20200607190130.38C4E20A2E@vcs0.savannah.gnu.org> <87r1uqo7cq.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="51702"; mail-complaints-to="usenet@ciao.gmane.io" To: "Basil L. Contovounesios" , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 08 08:50:18 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jiBbt-000DN0-U1 for ged-emacs-devel@m.gmane-mx.org; Mon, 08 Jun 2020 08:50:17 +0200 Original-Received: from localhost ([::1]:55206 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiBbs-00008B-TT for ged-emacs-devel@m.gmane-mx.org; Mon, 08 Jun 2020 02:50:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35114) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiBbL-00089H-Ub for emacs-devel@gnu.org; Mon, 08 Jun 2020 02:49:43 -0400 Original-Received: from mail-yb1-xb32.google.com ([2607:f8b0:4864:20::b32]:42995) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jiBbK-0001C9-ON for emacs-devel@gnu.org; Mon, 08 Jun 2020 02:49:43 -0400 Original-Received: by mail-yb1-xb32.google.com with SMTP id t9so8625411ybk.9 for ; Sun, 07 Jun 2020 23:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to; bh=/bg+4ubfwvNq3gZB64vLooSrbMn9rXwN5oPxSX/L5e4=; b=JTkJiy8bOtkvVfKdA0zga+02AEwytscQG3qySCX/ncVjvdaqoxCVgcGvrOCc8fw/0U enKcxBnncf3fIp8dEa63jIL7TlmaF77SE8EUqqRRG39C3hHPMXYmWBQK3GBiRMcG35As TZVnpIdQdGrie58j2Wlqf7zdu+8Zm1IaD1KBflLXvL4OuYAko6+K+kj6w7fbMmIT7u1+ LCUvyqEj1Ld/ZvEthljovfpRcn7f+lXhMNCkm8ZJ4t86ZL9s/ueKJPFPa4oocwUaQUP2 u/0IgbB6v5Q2M0AtoHN7J7vXiDPyX3LPOarFRrl8RjwbdXyyavueGIa3ptbmdHfHXksQ A6FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to; bh=/bg+4ubfwvNq3gZB64vLooSrbMn9rXwN5oPxSX/L5e4=; b=gPPQ9IImqKWKUEae2DAGLfRu6N47g9+3gEB+GPmjNyvCepXFuzoC5Kusr1ls4LGunf dN8dmM6S3RHLNP6C+bxGKLS/VrwHaslF8mqobTk5c64tzlE8pk0IAvauWryS1XkX8lYK i8lDTomGIEDV3iPYBvsnk5vsVP/Ua5ULn9lXiQUub2F6i9ThM0W9OWWIUWxzV5jnd1X6 1o8ARFnrWrJp/37z8OakVgLdRm5ZWj8YKrr35mIqkFXrQj6gvig9sZyx5A80h7pptD2L 66qxgfxpY38JRLhmQYT88qsO7mVmkdqVnCl16HBbAdaJMnm/aKODTPCcZOYim9g0Hzy+ U4yA== X-Gm-Message-State: AOAM532kLcx4dlg6UvRH1E5AASs5c/m/3k398I+CMeqA+9EXtxpFicEm CcPfsG1ij7wT5MGb6+XXGgBw90D9g/v2Zk3SMfc= X-Google-Smtp-Source: ABdhPJwp3bZovG29L/bCY0Bw4EO1GxDTitL/VUKxMrn6uJNinNBQVxMRiQOyB8FPyffqnuKSst7BPOKUZjxHd93h3uM= X-Received: by 2002:a25:5306:: with SMTP id h6mr24900876ybb.466.1591598981211; Sun, 07 Jun 2020 23:49:41 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 7 Jun 2020 23:49:40 -0700 In-Reply-To: <87r1uqo7cq.fsf@tcd.ie> Received-SPF: pass client-ip=2607:f8b0:4864:20::b32; envelope-from=stefankangas@gmail.com; helo=mail-yb1-xb32.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252040 Archived-At: "Basil L. Contovounesios" writes: > I'm seeing the following test failure: Thanks for pointing this out. > Test lunar-test-phase-list condition: > (ert-test-failed > ((should > (equal > (lunar-phase-list 3 1871) > '...)) > :form > (equal > ((... "9:03pm" 0 "") > (... "11:46pm" 1 "** Eclipse **") > (... "7:20am" 2 "") > (... "10:57pm" 3 "** Eclipse possible **") > (... "12:06pm" 0 "") > (... "4:49pm" 1 "") > (... "3:57pm" 2 "") > (... "7:29am" 3 "") > (... "3:46am" 0 "") > (... "6:02am" 1 "")) > ((... "11:03pm" 0 "") > (... "1:46am" 1 "** Eclipse **") > (... "9:20am" 2 "") > (... "12:57am" 3 "** Eclipse possible **") > (... "2:06pm" 0 "") > (... "6:49pm" 1 "") > (... "5:57pm" 2 "") > (... "9:29am" 3 "") > (... "5:46am" 0 "") > (... "8:02am" 1 ""))) > :value nil :explanation > (list-elt 0 > (list-elt 1 > (arrays-of-different-length 6 7 "9:03pm" "11:03pm" first-mismatch-at 0))))) > FAILED 5/5 lunar-test-phase-list (0.000611 sec) Hmm, so there is a difference of two hours. Yet I attempt to set the timezone like this in the tests: `(let ((calendar-latitude 40.1) (calendar-longitude -88.2) (calendar-location-name "Urbana, IL") (calendar-time-zone -360) (calendar-standard-time-zone-name "CST") (calendar-time-display-form '(12-hours ":" minutes am-pm))) Does anyone see if I'm missing to set something important here? > In case it matters, my time zone is > > (format-time-string "%Z %z") ; => "IST +0100" Here, I have: (format-time-string "%Z %z") ; => "CEST +0200" Which does not make it clearer to me why we have a two hour difference... Best regards, Stefan Kangas