From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/consult-recoll c5926ca3eb 1/2: format for size annotation Date: Fri, 14 Oct 2022 19:57:29 -0700 Message-ID: References: <166569465562.12992.2240825905795534702@vcs2.savannah.gnu.org> <20221013205735.EF3DEC03F23@vcs2.savannah.gnu.org> <87h707qivx.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4490"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, jao To: Stefan Monnier , Visuwesh Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 15 04:58:16 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ojXNQ-0000ys-7i for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Oct 2022 04:58:16 +0200 Original-Received: from localhost ([::1]:54196 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ojXNP-0005tg-5d for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Oct 2022 22:58:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojXMj-0004w6-Pg for emacs-devel@gnu.org; Fri, 14 Oct 2022 22:57:33 -0400 Original-Received: from mail-oa1-x2e.google.com ([2001:4860:4864:20::2e]:41486) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ojXMh-0007oJ-Vt; Fri, 14 Oct 2022 22:57:33 -0400 Original-Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-132af5e5543so7939318fac.8; Fri, 14 Oct 2022 19:57:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ic3Zzod8hHNG8/nm4ifDX92z+nUctfcb7TQ5d3HUYUI=; b=kMdv2GwZA6H2MgT04NloQL6cZ3hPfSwHEEOSejHRF4JEKQfTBPKbBJNPwE+MZ3bnob dbiclhRWyIKzh2xcMRsGG44o4sDbhVMenzdMZKXTZsGKgZlOqudALHEp7KAf4jVH334f ZByQCSjlKCDx4k8O4goXzV/GAsFD7FXJ1tLoqanl0UeESUaYheVvLhNR6NDyOO5U5nav 22hBH8kdlN2Y160XsefvsQ24B02lT2WL/svF7BWvjlc7JhQjDrzgIzfcR+svZfrkSKwz csh1CJ0EpTij0T2BkS74mpYH67qF9JCqV1KRsC4I8VGtTgPyfGQsrBo3ifF2kz5V6Nkc WRiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Ic3Zzod8hHNG8/nm4ifDX92z+nUctfcb7TQ5d3HUYUI=; b=7cOueF5y+Cd3NwIlyYPU7pACNj1nLVBFFenNCllujjgM4qCCi6tMBXIWivx2RFut9V UKCebJ61SoAwv+HDuTVPuYiSfSODRw2LEtQnlXGYl/2ZTMXl1zs26DmGoIZAzxAR28yC /0NZCHYu4vYvNTwx/roAlZZiKb/kHCHKnoR50XZ3pCSKeZi85PHY4aW7S3ru3e+BIx/d zS/ac/y6llqe+s/M1PUm26xGKpYpcOEng62B1c+hXOx3TW4b9lDbZZ/r8P0Jxg9nfkGG 6hGtTmCZHdP7PdAt5e1XuwsHrisY2NJ3Y4bvNAS6IwqyTpdL1AcBWPfol7/2T/exfgK/ 2uqg== X-Gm-Message-State: ACrzQf0nY6m9p/X0MnRWtRGAW9rGPyHgmfVoWxrZ6ypELwXHeHaCGkr7 qEjUZmvjoNCBvhEFFrRmmWecwohbPlyxUDlPsVh1AxrG X-Google-Smtp-Source: AMsMyM5gU+COFoNMJcu+XmBEgtk2gGuzPTftxj/8d27b8/b23RmZdOIMsIjBbbMFLCDgfwfEenG92i/QLRYbWisTrxw= X-Received: by 2002:a05:6870:9126:b0:132:b724:e96c with SMTP id o38-20020a056870912600b00132b724e96cmr10211981oae.199.1665802649598; Fri, 14 Oct 2022 19:57:29 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 14 Oct 2022 19:57:29 -0700 In-Reply-To: X-Hashcash: 1:20:221015:monnier@iro.umontreal.ca::Y2vKgYiG4dxTLkM6:4C/c Received-SPF: pass client-ip=2001:4860:4864:20::2e; envelope-from=stefankangas@gmail.com; helo=mail-oa1-x2e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297743 Archived-At: Stefan Monnier writes: > Visuwesh [2022-10-14 07:14:02] wrote: >> [=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D =E0=AE= =85=E0=AE=95=E0=AF=8D=E0=AE=9F=E0=AF=8B=E0=AE=AA=E0=AE=B0=E0=AF=8D 13, 2022= ] Stefan Monnier wrote: >>> I see we have `memory-report--format` which does something similar. >>> I'm pretty sure we have other chunks of code doing the same elsewhere. >>> Should Someone=E2=84=A2 introduce a function in `subr.el` or somesuch t= o solve >>> it once and for all? >> Don't we already have `file-size-human-readable' for that? > > Ah, that's it, thanks! > So Consult should simply use that instead of `consult-recoll--format-size= `. I changed `memory-report--format' to use `file-size-human-readable' (commit 8300899953).