* Re: master 89365d7: Fix mouse buttons in dired--make-directory-clickable
[not found] ` <20211024192145.A6670209A5@vcs0.savannah.gnu.org>
@ 2021-10-24 19:38 ` Stefan Kangas
2021-10-24 19:44 ` Lars Ingebrigtsen
2021-10-24 22:20 ` [External] : " Drew Adams
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Kangas @ 2021-10-24 19:38 UTC (permalink / raw)
To: Lars Ingebrigtsen, emacs-devel
larsi@gnus.org (Lars Ingebrigtsen) writes:
> branch: master
> commit 89365d748f15f2fd789c3818480a16849ac05a94
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
> Fix mouse buttons in dired--make-directory-clickable
>
> * lisp/dired.el (dired--make-directory-clickable): Adjust mouse
> clicks to conform to our standards.
> ---
> lisp/dired.el | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/dired.el b/lisp/dired.el
> index ced1811..40dfc39 100644
> --- a/lisp/dired.el
> +++ b/lisp/dired.el
> @@ -1672,7 +1672,8 @@ see `dired-use-ls-dired' for more details.")
> (dired-goto-subdir current-dir)
> (dired current-dir)))))
> (define-keymap
> - [down-mouse-1] click
> + [mouse-2] click
> + [follow-link] 'mouse-face
AFAICT, our standards are to follow links on mouse-1. This happens in
eww, help-mode, etc.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: master 89365d7: Fix mouse buttons in dired--make-directory-clickable
2021-10-24 19:38 ` master 89365d7: Fix mouse buttons in dired--make-directory-clickable Stefan Kangas
@ 2021-10-24 19:44 ` Lars Ingebrigtsen
2021-10-24 22:47 ` Stefan Kangas
2021-10-24 22:20 ` [External] : " Drew Adams
1 sibling, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2021-10-24 19:44 UTC (permalink / raw)
To: Stefan Kangas; +Cc: emacs-devel
Stefan Kangas <stefankangas@gmail.com> writes:
>> - [down-mouse-1] click
>> + [mouse-2] click
>> + [follow-link] 'mouse-face
>
> AFAICT, our standards are to follow links on mouse-1. This happens in
> eww, help-mode, etc.
Yes, that's what this magical incantation does (in conjunction with
the mouse-1-click-follows-link user option). I think? Or has this
changed again?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master 89365d7: Fix mouse buttons in dired--make-directory-clickable
2021-10-24 19:44 ` Lars Ingebrigtsen
@ 2021-10-24 22:47 ` Stefan Kangas
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Kangas @ 2021-10-24 22:47 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Stefan Kangas <stefankangas@gmail.com> writes:
>
>>> - [down-mouse-1] click
>>> + [mouse-2] click
>>> + [follow-link] 'mouse-face
>>
>> AFAICT, our standards are to follow links on mouse-1. This happens in
>> eww, help-mode, etc.
>
> Yes, that's what this magical incantation does (in conjunction with
> the mouse-1-click-follows-link user option). I think? Or has this
> changed again?
Aha! Yes, it works as it should. Please ignore me, carry on.
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [External] : Re: master 89365d7: Fix mouse buttons in dired--make-directory-clickable
2021-10-24 19:38 ` master 89365d7: Fix mouse buttons in dired--make-directory-clickable Stefan Kangas
2021-10-24 19:44 ` Lars Ingebrigtsen
@ 2021-10-24 22:20 ` Drew Adams
1 sibling, 0 replies; 4+ messages in thread
From: Drew Adams @ 2021-10-24 22:20 UTC (permalink / raw)
To: Stefan Kangas, Lars Ingebrigtsen, emacs-devel@gnu.org
> AFAICT, our standards are to follow links on mouse-1. This happens in
> eww, help-mode, etc.
(Not really. That's done by default, but it doesn't
express our standards. Our standards are to respect
user option `mouse-1-click-follows-link'.)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-24 22:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20211024192144.9942.11801@vcs0.savannah.gnu.org>
[not found] ` <20211024192145.A6670209A5@vcs0.savannah.gnu.org>
2021-10-24 19:38 ` master 89365d7: Fix mouse buttons in dired--make-directory-clickable Stefan Kangas
2021-10-24 19:44 ` Lars Ingebrigtsen
2021-10-24 22:47 ` Stefan Kangas
2021-10-24 22:20 ` [External] : " Drew Adams
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).