From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master 89365d7: Fix mouse buttons in dired--make-directory-clickable Date: Sun, 24 Oct 2021 12:38:48 -0700 Message-ID: References: <20211024192144.9942.11801@vcs0.savannah.gnu.org> <20211024192145.A6670209A5@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13820"; mail-complaints-to="usenet@ciao.gmane.io" To: Lars Ingebrigtsen , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 24 21:39:48 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mejLQ-0003Ni-3y for ged-emacs-devel@m.gmane-mx.org; Sun, 24 Oct 2021 21:39:48 +0200 Original-Received: from localhost ([::1]:44624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mejLO-0000Cr-J3 for ged-emacs-devel@m.gmane-mx.org; Sun, 24 Oct 2021 15:39:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46712) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mejKV-0007wf-VK for emacs-devel@gnu.org; Sun, 24 Oct 2021 15:38:51 -0400 Original-Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]:35737) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mejKU-0006GA-4I for emacs-devel@gnu.org; Sun, 24 Oct 2021 15:38:51 -0400 Original-Received: by mail-pf1-x436.google.com with SMTP id l203so3973436pfd.2 for ; Sun, 24 Oct 2021 12:38:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:in-reply-to:references:mime-version:date:message-id:subject:to; bh=jlbczPsqnQzji7AORSNAd8IUVvwr3QKG2fH6LdlKums=; b=dOjcQflGD0b8geTLF7Oi3tmjYKAQhd65VJHxd64YxUXdAyytJ4cAyKBJRh8vSr1Yme DQ0Lm4n6H/Xq2uj0m7OhLvusrnWZm5IjGsmzZ8TE543fHsl9zNTOMIHiQrI6Hr5ivAPH /X1VjQeOYSh2mEzlG6TPMokeXGF0frJq4T5agmZLYEQRzZ4FN2U7ckxmSadJr+/UK9WY 7L1iarzMsLNbYQsrKNAdR4KaOrod1bItMMEd7lGejfkUd944RSVZ7Wip2HXP9QQ/2DBg yc+Q/o2omqLm9p/REkUXjOl64oW9S4pDzNXP+FllmaElgL9z2jxCAGJRhA7j6d5yF5Xi PyjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to; bh=jlbczPsqnQzji7AORSNAd8IUVvwr3QKG2fH6LdlKums=; b=5F9LBe9vV2lRsDn1qnDxcYqd9BhKuGZciUVSfT7TJbQP2OS7HH7meIrxsWhKvBCLmv 4frzUVGyhjzuYSzaTJ+rpojjHaqiJ7Md5n4Lp0+vUAgrOv+BWpbV14Wgj8NhrJ61wEyV E+6fp5LjOnygQ3ESLYIdbWDOC6j5brT14j4BG61tFQzQb1i+2F0iyRq1vZBdwRa3gGKm uixEFXUIk1XmslH5xdrpUcuZ2PwfMRbBvEywA2hiKYOA9T5+YZ0ENmX2u1QT7bwpUXWl cJovX+vDBBiJuWzxuaS3AzVHiNpAPULsxdfI+sEwxceCyRxaLChgUKKfiA0W7B73trOe 1BTA== X-Gm-Message-State: AOAM533+1UAQmuTiln6C3pRvKlqi/ZGTqYMLMO5HxkACK3Kwl6n20WJ2 qsR+OVyynqZg90lMlW/s4Su/IGCf0P7HjMrTGZU= X-Google-Smtp-Source: ABdhPJwkFfy0GBpUo72el3Z6DuOVawF9Y+WDtSBhhLFyw9kNrzKL2RqhX/Cpb7h5khz19u3T5TKmj3ZImSLe+4wHzIo= X-Received: by 2002:a63:370c:: with SMTP id e12mr10259602pga.359.1635104328382; Sun, 24 Oct 2021 12:38:48 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 24 Oct 2021 12:38:48 -0700 In-Reply-To: <20211024192145.A6670209A5@vcs0.savannah.gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::436; envelope-from=stefankangas@gmail.com; helo=mail-pf1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277681 Archived-At: larsi@gnus.org (Lars Ingebrigtsen) writes: > branch: master > commit 89365d748f15f2fd789c3818480a16849ac05a94 > Author: Lars Ingebrigtsen > Commit: Lars Ingebrigtsen > > Fix mouse buttons in dired--make-directory-clickable > > * lisp/dired.el (dired--make-directory-clickable): Adjust mouse > clicks to conform to our standards. > --- > lisp/dired.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lisp/dired.el b/lisp/dired.el > index ced1811..40dfc39 100644 > --- a/lisp/dired.el > +++ b/lisp/dired.el > @@ -1672,7 +1672,8 @@ see `dired-use-ls-dired' for more details.") > (dired-goto-subdir current-dir) > (dired current-dir))))) > (define-keymap > - [down-mouse-1] click > + [mouse-2] click > + [follow-link] 'mouse-face AFAICT, our standards are to follow links on mouse-1. This happens in eww, help-mode, etc.