From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Splitting image-dired.el into smaller files Date: Tue, 23 Aug 2022 12:02:47 -0700 Message-ID: References: <83sflqcfhk.fsf@gnu.org> <83tu65br5f.fsf@gnu.org> <83r119bp35.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26448"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, mathias.dahl@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 23 21:06:00 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQZDs-0006h0-3O for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Aug 2022 21:06:00 +0200 Original-Received: from localhost ([::1]:51432 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQZDr-0002CI-4p for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Aug 2022 15:05:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43048) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQZAp-0000V9-P5 for emacs-devel@gnu.org; Tue, 23 Aug 2022 15:02:51 -0400 Original-Received: from mail-vs1-xe2f.google.com ([2607:f8b0:4864:20::e2f]:41493) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQZAn-0000fa-QC; Tue, 23 Aug 2022 15:02:51 -0400 Original-Received: by mail-vs1-xe2f.google.com with SMTP id k2so15373099vsk.8; Tue, 23 Aug 2022 12:02:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc; bh=aDSCREWASLyADVSNaItZGjULKePA15O4B6dLCt8Vrsg=; b=kAmswDox4p/qyx/lxc1JwjaSR3OTt8siaV+1+4RHn7pCEyTVoypOLrHGUKqRx14bcJ g1FZjPutMIABM6VeSH7GFShFVq7ASnI/MySx4hLANtB3RR2KmSF4Wl2IdRCz4LVnU3A5 SOGtZt1k+XgD2+f+wPPlCPVYtLlSZeqEKqY83E71GsbuoIFqLxKNN/+OTPJ562ejYpXP WrnawlirmJaOwiA84yirir3G9flzl9yocFW6qmUhm4KTHCDQsQxoxL4DQECJ8jHSxwCE 5tjyoY6/eML8r+krRmjSnJAHwvWGJTqIDse01QPCJm0vGOmLShBWQV3dW/BAvqhUProc 54dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc; bh=aDSCREWASLyADVSNaItZGjULKePA15O4B6dLCt8Vrsg=; b=rIhLQCcXdHPhyEAlfBR3NB8R4uxtx8AXH/cQZL6I7x5y5ah/CuIZ2Bn4vHDvhRXx98 PEyID1aVvQxLlYMB5C9QRmUgG67AHPEbsNL12MRWVXcCUNJCtTZCDSpdzXs+PtE1MPYZ kDU60BJgNBYWQOqtYajQPgwa/CwzIe7AU/UfU+QPNHw1QV51aJhK7QWIkOJGJxv+BJfM 28aF/hYyZ8bzt16oOQnJXFN/w8hRTiXCBfDEQCTKVh9CI7AFYfZPACINrsOA4GEdK+5n FSsKFUcxxIP2J1uvBC2NI4dqdJz2rLO4A+AMwYB5FOKsVYa0JAzHIquztRawV2Opoo4T qELw== X-Gm-Message-State: ACgBeo0Cw+ufDjDmatgvQAcIL34K5sgKHPzCAeceJcDOzlno21QKTo0/ Bpk0+Umx3H8FXCTjOsxgF5jQvLTIzlLIMXLau1b1I3WI X-Google-Smtp-Source: AA6agR5ANnMcjjdTaiWKD6/j9FU3P6/87TW1f35XWc7ty0st1X+2Qd7ZWX/V53PQMlOXY25S/ju1LX7TVCuxmaRomW8= X-Received: by 2002:a05:6102:313b:b0:38f:7ffa:166c with SMTP id f27-20020a056102313b00b0038f7ffa166cmr9813014vsh.46.1661281368052; Tue, 23 Aug 2022 12:02:48 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 23 Aug 2022 12:02:47 -0700 In-Reply-To: <83r119bp35.fsf@gnu.org> X-Hashcash: 1:20:220823:mathias.dahl@gmail.com::rXCcNIIIrBNCnlIs:7mn3 Received-SPF: pass client-ip=2607:f8b0:4864:20::e2f; envelope-from=stefankangas@gmail.com; helo=mail-vs1-xe2f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293916 Archived-At: Eli Zaretskii writes: > How come, when all the code now lives on the same file and we don't > have any problems? Maybe your factoring between the files needs > revisiting? For example, `image-dired-dir' is used in image-dired-tags.el, image-dired-dired.el, and image-dired.el. To have a non-circular dependency graph, I introduced image-dired-util.el, which gives me a diamond shaped dependency graph with arrows pointing in only one direction. It's possible that this is fixable using autoloads, but that leaves us with the same number of files, so I'm not sure it's much of an improvement. But maybe I'm missing something.