From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default Date: Mon, 13 Sep 2021 11:46:45 +0200 Message-ID: References: <1df50c0d035675f851387d689030d588@purelymail.com> <87k0nw1qaq.fsf@red-bean.com> <878s4cf74z.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36919"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Karl Fogel , Eli Zaretskii , "Paul W. Rankin" , "Paul W. Rankin via Emacs development discussions." To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 13 11:47:52 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPiZ5-0009Q2-NY for ged-emacs-devel@m.gmane-mx.org; Mon, 13 Sep 2021 11:47:51 +0200 Original-Received: from localhost ([::1]:35408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPiZ4-0007TA-IH for ged-emacs-devel@m.gmane-mx.org; Mon, 13 Sep 2021 05:47:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPiYG-0006nJ-Pc for emacs-devel@gnu.org; Mon, 13 Sep 2021 05:47:00 -0400 Original-Received: from mail-pj1-f41.google.com ([209.85.216.41]:42638) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mPiYF-0003qn-7b; Mon, 13 Sep 2021 05:47:00 -0400 Original-Received: by mail-pj1-f41.google.com with SMTP id w19-20020a17090aaf9300b00191e6d10a19so6052278pjq.1; Mon, 13 Sep 2021 02:46:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P2WBA415/SCb9tV7lBzaA05NMTyr/Yz89bQVgOa1GAo=; b=Cvh79Mc0XckS43+e+2V/vlNighf1zd1924hP2Lh0xjqrahpohgArRAmIeqR9YNU86f iLKqxchfEvIOY2eGSh3EgfArErlkJ+Qjnepmeuw8Q4WAHtwvPHg2ZtZ0cmKwvyvVWSPS W4kB6Kmz1ebhK5FJ5suUi8xJCjP2Wsrg34tOSHUnG3xDJISXuyo1aEM49wVkY/ghs4V3 6uJmtBKWKu4nZSgd/L9IkBIamne57ZMCtd33xNJmw4ZWkEsum5NThUdsxZN+WNuQxm30 VDBRVDdAFDHLlw6laLrHaxKUuvHbVgTYJfLtqR/qiYiAuGKX9C5PgHdmb9Vk45W4Ov5R Hcsw== X-Gm-Message-State: AOAM530/uaE4In2E3RVx/5Mb7nXP3LYDEYbSlid22XNoDLC4UPXtFsCE 3cGH/ewG5stoaz7Sb35sYKdR63sV010BOh7lFkw= X-Google-Smtp-Source: ABdhPJwdvIZ/cyPRWCUeYfMjTWJv2PmI2SDMejrlQp17dijAHJ5gsEVJxD+RbsCVS6pRrBX0m8pxVHp/us6uDScs0Ls= X-Received: by 2002:a17:90b:380d:: with SMTP id mq13mr5826882pjb.143.1631526416930; Mon, 13 Sep 2021 02:46:56 -0700 (PDT) In-Reply-To: <878s4cf74z.fsf@gnus.org> Received-SPF: pass client-ip=209.85.216.41; envelope-from=stefankangas@gmail.com; helo=mail-pj1-f41.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:274625 Archived-At: [That was in May.] Lars Ingebrigtsen writes: > Eli Zaretskii writes: > > > Please don't make this change until you hear from Lars, who examined > > the original patch and decided to install it. It doesn't get more > > "considerate" than that. > > It does seem to be an unexpectedly (to me, at least) controversial > change, so perhaps it should be tweaked. For instance, using fringe > markers (on frames that support that) instead of highlighting the entire > line, or something else that isn't that stark. This discussion sort of fizzled out with everyone, as far as I can tell, mostly agreeing that a fringe marker or similar might be better for the default behaviour. On master, bookmark-fontify is still t, and the highlighting is still done by changing the background colour. In general, I think we are sometimes too cautious with turning on so-called "bells and whistles", so I'm actually in one sense happy to see that a useful new feature is enabled by default. Yet I'm a little surprised that this particular feature happened to pass the bar. I personally find that highlighting the entire line is fairly distracting, and I'm concerned that this is not a good new default behavior. If I'm wrong, and long-time users of bookmark.el thinks this change is great, then that's fine of course. But just in case I'm right, perhaps we could wait with setting the default to t until Emacs 29? That way we have a chance to wait for the new less intrusive fringe marker feature, which sounds harder to have many reservations about. WDYT?