From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] When deleting in bookmark menu, prompt for confirmation. Date: Mon, 3 May 2021 07:47:50 -0500 Message-ID: References: <87a6pcqy7s.fsf@red-bean.com> <83czu86o46.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9357"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii , Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 03 14:49:02 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldY0S-0002H4-Vh for ged-emacs-devel@m.gmane-mx.org; Mon, 03 May 2021 14:49:00 +0200 Original-Received: from localhost ([::1]:49836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldY0S-0005ME-2C for ged-emacs-devel@m.gmane-mx.org; Mon, 03 May 2021 08:49:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34772) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldXzS-0004Ua-CN for emacs-devel@gnu.org; Mon, 03 May 2021 08:47:58 -0400 Original-Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:40781) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldXzN-0001uI-3V; Mon, 03 May 2021 08:47:58 -0400 Original-Received: by mail-pl1-x62f.google.com with SMTP id n16so2635365plf.7; Mon, 03 May 2021 05:47:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=n23zB2zsyLvwGgKoDX0knWOqLnG2AUcTUE4jVKQI6vs=; b=pJuMbBJnXHTlvsRQMhLCR8RiAQxENHPRUcKXluOl0JIRYfaeUFKjfp5ECEOaj88ITZ BLLTsWPWUX/5k30e60lF1bIQhXZdeX2p98VQ5miI5rlHTgxCqaiyCwIf7BF19joT/YJ4 K5sgyTk1zm2OdJYbouki4lJqbxBikP/nciQ+vXkClHYfOTccKGUDYIINPvfCsQCL7EZS 5eJHupf1OA2rLNb/8XuvgcwZMwN4tFtzo3s2/Gpvb9E6nGyl3NayhX7/hoClA2npmD2i glkWZ2KxqznsE39a8kLw+tQ+cgfnLxIqe7Pf1y2c0KfP38TziaDEXYv5vdM85GYHJW/L Np3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=n23zB2zsyLvwGgKoDX0knWOqLnG2AUcTUE4jVKQI6vs=; b=m1gdQBSdrRx4w6x12fV38ycPUO023W+GXS1JcK+nyei33VKfx0fcG1nIXT9tjvcr5V 7x7tCtHtHgSksr1giToVeAtpegk7iEqcmYOlEy8qDse0o6wTgjmMDjqt4nT314pKTPXv X+a10urGageaKhTH//ZYc5rN1xn7v2Vl0n/O5jWtuTna+El6K6GK9JybOuXCeWByNUCk ySczo4vdSeZGdJZ8vHykyJj0xBubNg4hJWvyBNr2HO4AlpvWhhQBAwpo/zW/kDw1s/pN MlOH7Xoasnxt0BcokQOH03K1hIRuB5DMDCVetuUGkpanNuW/1CW5dNRwsuLZ/6/TEDun OhNQ== X-Gm-Message-State: AOAM531IkavmCGK1zigIwya93urJmXLwqvzS8T7oQEDHVQM2DN6/GsD1 +ljPv42SLDV7kBY43GDYYluZ6dZF/BTQNZ9cvhv+f+QL X-Google-Smtp-Source: ABdhPJwJ5AMPxCuWunfoT3BiSHZWK1k6Niaerogy1sSj38OOf5OWXbV0P+237zK/D7T06+6SsERBT95uLozxknubMf8= X-Received: by 2002:a17:90b:d81:: with SMTP id bg1mr20701907pjb.179.1620046070716; Mon, 03 May 2021 05:47:50 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 3 May 2021 07:47:50 -0500 In-Reply-To: <83czu86o46.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::62f; envelope-from=stefankangas@gmail.com; helo=mail-pl1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268807 Archived-At: Eli Zaretskii writes: >> I wanted to run this by folks here to get opinions/review before >> committing. It stems from a suggestion by Oliver Taylor in a >> thread on the Emacs Humanites mailing list (the thread is linked >> to from the commit message). > > Isn't this a backward-incompatible change in behavior? If it is, then > (a) I'd prefer the default to remain as it was before, and (b) the > change should be called out in NEWS. I don't see how backwards-compatibility is relevant here, but perhaps you could provide more specifics. IMO, we should do what we always do: enable this new feature by default if it is generally useful, and disable it if it is not. If someone does not like the change, we already have an option in place to disable it.