From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master c86995d07e9: Enable code block evaluation when generating .org manuals Date: Tue, 18 Jun 2024 19:37:49 +0000 Message-ID: References: <171767737644.19678.784876979840850798@vcs2.savannah.gnu.org> <20240606123616.DE7C9C1F9EF@vcs2.savannah.gnu.org> <87h6e6i1mg.fsf@gmail.com> <87sexplbmn.fsf@kyleam.com> <874ja22e7t.fsf@localhost> <87v82i0xc4.fsf@localhost> <87sexefezd.fsf@localhost> <87wmmnbxlc.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18016"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Kyle Meyer , Robert Pluim , emacs-devel@gnu.org, Andrea Corallo , Eli Zaretskii To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 18 21:38:18 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sJeeo-0004Ot-MS for ged-emacs-devel@m.gmane-mx.org; Tue, 18 Jun 2024 21:38:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJeeV-0001sx-4m; Tue, 18 Jun 2024 15:37:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJeeU-0001sf-35 for emacs-devel@gnu.org; Tue, 18 Jun 2024 15:37:58 -0400 Original-Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJeeS-0001pS-EQ; Tue, 18 Jun 2024 15:37:57 -0400 Original-Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-57d07464aa9so279837a12.2; Tue, 18 Jun 2024 12:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718739470; x=1719344270; darn=gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=UDyvEJTnxVc1tTeCbERO9oqEf1PCOvPzu6fzYEPmrBk=; b=e9N06h4kKEJYAVMuVnHL0Lv0L0SIp1qEzbKwvWHt1CnPrWFEYVzoUbt31TuYxftMs7 2uCxGE4fs8Bghi2QYzzP9Ba9PvjAu74TImp1qhUNAtP2Jhx9SHAVXVJxzN/wmYIcTlMf Sn//1T4NjKZx8/wqCtvhcvfhq68qpHIYI3ifiyPm8MkhLzeN0DekwSgHNiGobZo7aTgk exyofl3mVVsyVBP+dzXeUNhE5JnWIvQmKOGq+8bGJJgwMwUob1r/oT4klr5JAATQJyc6 xHyrC95UEUFDzw5IxczagVV+UrV65YUjEReg4QKa98eEYIl1kPKS0Cl03RCPQmIB2nLB ji1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718739470; x=1719344270; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UDyvEJTnxVc1tTeCbERO9oqEf1PCOvPzu6fzYEPmrBk=; b=TiEZp1p+IBq1uAiYkcey+E7b+1sYrI3+1jMbEaud7CKDU3P0dY6Hzo4qa+JjwGJvDh x2LfxYeJlNIiWSLw0p4Ynqq5HOvBtYldilv3d+kD89/b7P8iiLn+pFoQ/UFhC6e3jsmT fOpKrv4DYwYvDgD5JZIjp2T8Gzqlhf+vpNWGFR68yW11ndhg00BgvTOZ5AWmC3RZicB2 iBX/7HNo+Q5k5hHgIG2DJSqZy4hERtRxlPQzLruR7Uask0PrQrJgr7cs7JyeFGcEPkv1 Q9vKw9Cun7Q+js46Ox9dCqzuCdBrDwcgtSgwn6kiZ/Vx/sckwg5NLV1sKTerw34SwGIc OY0Q== X-Forwarded-Encrypted: i=1; AJvYcCVfnYFa2dUJFqvX4TULuAFYpoGYlvq7tEPWiYJgVVeXFZMQ5Z1rsyEtDN6/7yYX8iD69fPUB5rSQw8vAdDxcmVBMixiCq1M1WdsJ+SMaJly6D1oUDvj9wo+Rmzi965rmUomSoI= X-Gm-Message-State: AOJu0Yz1z53G9IPipM3IcXJqN40IIMG6lWVNyWVLmlwLshCfsBLqZJXI HpabLz7Drs9+joRMJ2mbGxqo5wtxEC4fWbTZBu9l8w7NjCs0pb2mxodWRQCgWkVLsEch7j0Kn+q fsXjv5lnCox/axqs9wwVCa6aYN/NV/z3a X-Google-Smtp-Source: AGHT+IFawmkQYQDELGeTM1oUM7ifBjsDPeGmjyog+WA2Nfpm6wq51YcUqGDOcEmlT2m/AkY4qYYPsK6GD72FKnZi3WE= X-Received: by 2002:a50:aac7:0:b0:57c:563b:cc40 with SMTP id 4fb4d7f45d1cf-57d07e703edmr238136a12.25.1718739469719; Tue, 18 Jun 2024 12:37:49 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 18 Jun 2024 19:37:49 +0000 In-Reply-To: <87wmmnbxlc.fsf@localhost> Received-SPF: pass client-ip=2a00:1450:4864:20::52c; envelope-from=stefankangas@gmail.com; helo=mail-ed1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320268 Archived-At: Ihor Radchenko writes: >> Running the `admin/update_autogen` script results in commits like this >> one: >> >> commit 1ea3b369021c90701c634c512426f75ce1291d77 >> Author: Eli Zaretskii >> Date: Sat Mar 9 04:24:30 2024 -0500 >> >> Auto-commit of loaddefs files. > > Thanks! > I am now looking into that script, and into doc/misc/Makefile. > I can see two approaches wrt to the Makefile: > > 1. Implement a separate Makefile target to generate org.org version with > all the necessary code blocks inside evaluated, so that there is no > need to redo it during make doc. > > 2. (simpler) Just reuse the existing .org->.texi target and run the full > .texi generation from admin/update_autogen script itself. > > The second option is less work and also ultimately shorter build times > as there will be no need to arrange Org mode compilation, and > .org->.texi conversion. > > What do you think about such approach? I think either approach is acceptable, so whichever you prefer is fine. There is always some drawback to checking in generated files though, so let's see if anyone else has any comments or better ideas first. That said, I think we should let `admin/update_autogen` be strictly about loaddefs files. If we decide to go in this direction, we could add a new script `admin/update-manuals`. If it needs to share code with the former, the shared code could go in `admin/emacs-shell-lib`.