From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Patch to vertically center line content when using line-spacing variable Date: Sun, 25 Apr 2021 20:00:30 -0500 Message-ID: References: <1398d749303cdc2a490cd9eb35f88fcf@johnmuhl.me> <87sg3ei23u.fsf@gnus.org> <6b523482-4420-e162-a41e-f178813779c2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28181"; mail-complaints-to="usenet@ciao.gmane.io" To: =?UTF-8?Q?Cl=C3=A9ment_Pit=2DClaudel?= , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 26 03:01:52 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lapdI-0007Dm-2z for ged-emacs-devel@m.gmane-mx.org; Mon, 26 Apr 2021 03:01:52 +0200 Original-Received: from localhost ([::1]:38494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lapdG-0005IR-Nw for ged-emacs-devel@m.gmane-mx.org; Sun, 25 Apr 2021 21:01:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lapc2-0004iw-OA for emacs-devel@gnu.org; Sun, 25 Apr 2021 21:00:35 -0400 Original-Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]:40923) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lapc0-0005Gu-LG for emacs-devel@gnu.org; Sun, 25 Apr 2021 21:00:34 -0400 Original-Received: by mail-pg1-x52b.google.com with SMTP id b17so1974497pgh.7 for ; Sun, 25 Apr 2021 18:00:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :content-transfer-encoding; bh=GAcJzwjOj2CJE0QTHKTEqvMAEXB8E8nIUVRDtDlxmDM=; b=bD+3SmYBK/4AZXiF8oYc2vjv4TttwxFhokli/SDZgLpi5i9+DgIEbL17WMjAvgtbQG JBGNm7p74Ifk8cGY1H2Q/p5+Xj2gOuh98eIcBGQ8561ipELukzbFdfq1msJ+kV1TdJEo QTZfpAS5V4KexCTuYjaqe9rdY0HMh1uY9lbVgWw2z6VZcw3F4fSxPdVxrlpMBod+85y8 Fy/RpnMAj09lUBbaYxbVIlZKaVymOd6K4+1sByYt/w3hE2EPMQF6TCeMZXQP1+G8573o i0Qh9E9+QY27aWPieRM38722llB0SazIT6LbmrCxylKxFKH6+SPTEhjSD27h7Bk9kvi7 X7+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:content-transfer-encoding; bh=GAcJzwjOj2CJE0QTHKTEqvMAEXB8E8nIUVRDtDlxmDM=; b=VjHklZjGkSszIalroumfrvUj+FiuMREcbO8sFQrQNtgWr9Rib15cDVRnDymvjnZNvh 07QjXL2UerYgID6lgoPnBXYNemhdGx8xK22su3xisbXSjianHLpkobLzaRLAAmpwABH3 2Txsh39hbTf6z6boVja/7is9Ku0bx4zbr4K3pJSva+aL32zeKEtP+9f8H+ZcgdIWVyN7 uhKpfu2BDuD5X4sb65ZrFt4F3MIAEGPYfQugtNtmayi3SD6hLpbnhR3WwYrPSmU+cjOV 4GI8SGDelzK3HFm317uZQmNNNiASL9ALa64B7skc+br4iYtr2H0qKCcNISVONVpleJ3/ IfVQ== X-Gm-Message-State: AOAM531cxtxP5FAzCoeH1s8TPLcPi3IeZqHMtAWWI95SuKXgsQ4d/Dv+ iu3Bmw0R5YgepjNFlpStbAyRsUxRsxWiLMk0EOk= X-Google-Smtp-Source: ABdhPJyNa3iOGIk+rQFDb5SUtoKYSVjHY8Iv5q8DA3DYI0onNDm2jYYhbtZJPk3StLp4GlDWc+EGGux8sIVEASXMUbo= X-Received: by 2002:a63:5b5c:: with SMTP id l28mr14397743pgm.363.1619398831345; Sun, 25 Apr 2021 18:00:31 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 25 Apr 2021 20:00:30 -0500 In-Reply-To: <6b523482-4420-e162-a41e-f178813779c2@gmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::52b; envelope-from=stefankangas@gmail.com; helo=mail-pg1-x52b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268443 Archived-At: Cl=C3=A9ment Pit-Claudel writes: > On 4/25/21 7:28 PM, Stefan Kangas wrote: >> (I would just treat the old behavior as a bug and not even add a >> variable for it, but that's me. Perhaps there is some rationale for >> why someone would want to set this to nil?) > > Does this patch change the behavior of the line-spacing text property, > too, or just the line-spacing variable? It seems to affect the 'line-spacing' text property too. > I use the line property in multiple packages, and it would break these > packages is line-spacing suddenly added space above the line, not just > below. I'll take your word for it. It sounds like I was wrong and there should be a variable that you could set buffer locally to nil. Out of curiosity, could you briefly explain how this would break your use of this text property? And/or could you link one of your packages?