From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] image-dired-show-all-from-dir: reuse dired's default directory Date: Thu, 2 Jan 2025 18:23:06 -0600 Message-ID: References: <87cyh5ugte.fsf@sachachua.com> <87v7uw97yu.fsf@sachachua.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37328"; mail-complaints-to="usenet@ciao.gmane.io" To: Sacha Chua , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 03 01:24:22 2025 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTVUE-0009af-OI for ged-emacs-devel@m.gmane-mx.org; Fri, 03 Jan 2025 01:24:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTVT7-0004Q8-JQ; Thu, 02 Jan 2025 19:23:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTVT4-0004Pw-Ab for emacs-devel@gnu.org; Thu, 02 Jan 2025 19:23:10 -0500 Original-Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tTVT2-0003tf-NR for emacs-devel@gnu.org; Thu, 02 Jan 2025 19:23:10 -0500 Original-Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5d122cf8dd1so20280574a12.2 for ; Thu, 02 Jan 2025 16:23:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735863787; x=1736468587; darn=gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=QOo5gH5bTPZXZrEQ0z0AveEAfzFH6PVvzk22IwqIjFk=; b=E6MowkLqYMt4d3spH6B+sdy92kYWita4H7MWAjF4prBbqCyyhziUh3Fi+nahGEc5gE lkjdVkERTgo59BQpxnsF03J1JoTE4v+vkofykh0WNWkJPzLYjv7Y5gz4RyiJgSeuf9J0 ChZspzUhdpjjMeLNUEFhGYsUQx4SvLrtNggX3wCzWhG6mIr+nYO3e+xo+5y8WlN8saPp 2t29tdXYYHfE+KCk//IOudnapUvu05U3dn3HwU3XFdbe4R3wA9Sao8C6wb8q+rU2Gv6k 1IZktYyV6evmTs8xhNqvdDR2kfWEAYS9y3nyl8A9gy+2d6fo1oBpNDSDxgTyjxPG1Hk4 tDIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735863787; x=1736468587; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QOo5gH5bTPZXZrEQ0z0AveEAfzFH6PVvzk22IwqIjFk=; b=SouHa/C2bj50CCIOabqZ/Cx2ucFFri8z3oyPqb/TmIoWg6xlFRmo/WPgN/kq51F7Bv pye4HK5fVyV5bgSTh/lT96jDeGZWkWMCeV9rf9PqJGd7ZAZRTFFFOLr9nqHSNMrt6TzN R1fwNFVbueDvBxp05zjaqtAWyBVCK7CKUviEViR6VE2RELGfM9dOGrlOuZGynM16K2H/ 9RUUQrAB7SlvkIYOPsmCqkqFA0qnludWFGmKWFSwhHqOa37kZCmCu2Dy1j8o82WzvEpn WtO7a45d7EgnDgU2MnJBZPoJLf6zjpexzwhTEDfrwk9WAE0a0ihvtz3bPvJSi6LFkMAx kP3Q== X-Forwarded-Encrypted: i=1; AJvYcCUFVp1AffSwMFcL/t/e6ks9u/JQ7ay18WdxDJ8MueidmbBmZkrHpUpOiG0gEK/8kn5PCMBYe26Gy4kkrQ==@gnu.org X-Gm-Message-State: AOJu0YxuKu8bhT4+QNYoSdp4faVSXLe+5oECbOhufJoPJEdQh1qa5FcQ 4iNfPZ/BpiKgBrCVmoNbI6+TCbx9r/5SDYq7v6/5fSbyV1V0jWmLkkb36Lf/dnOIq2HoTirOMCa +giYsI2DkEqFQU9dJZxCCzSsgbqdFVW/Z1My6Tw== X-Gm-Gg: ASbGncujjZnvCx6RNtB6SwGAJrNRi7GuaHNK1P8W3DyZmtLNYg7KXBpFusnhDOUjqnN oaIiUK+wfaOcfHagd6E+/ge7nSNJX2umTYNLkZToM X-Google-Smtp-Source: AGHT+IF+GDhCk+eu16mrIfT8YouReQdSlk6UULKDzZ5aKFXMaxTFxIkBmqomc0mPBrbshfmxhTazcgi3YBaJ/UdO8eo= X-Received: by 2002:a05:6402:4306:b0:5d3:d733:7ad4 with SMTP id 4fb4d7f45d1cf-5d81dd83b9emr38320432a12.3.1735863786795; Thu, 02 Jan 2025 16:23:06 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 2 Jan 2025 18:23:06 -0600 In-Reply-To: <87v7uw97yu.fsf@sachachua.com> Received-SPF: pass client-ip=2a00:1450:4864:20::531; envelope-from=stefankangas@gmail.com; helo=mail-ed1-x531.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327604 Archived-At: Sacha Chua writes: > Stefan Kangas writes: > > Hello, Stefan! > >> Thanks for the patch, and interesting use case. >> I can't find the variable `dired-default-directory`, but I do see that a >> function of that name was removed in Emacs 27. Where did you find that >> variable, and which version of Emacs are you running? Could it be that >> this variable is from a third-party package? > > Oh! That's a coincidence, I hadn't known that was used before. We can > call it temp-default-directory or something else if you prefer. I called it > dired-default-directory because I just needed to temporarily store the > default-directory from the dired buffer so that we could copy it to the > image-dired-thumbnail-buffer, which is why it's a let-bound variable. Ah, my bad. I got confused and thought it was supposed to be a special variable. I think your patch looks basically good, but let me take a proper look before installing it.