From: Stefan Kangas <stefankangas@gmail.com>
To: "Mattias Engdegård" <mattiase@acm.org>, emacs-devel@gnu.org
Subject: Re: master b2167d9843: Don't fail flymake-tests if `gcc` actually is Clang
Date: Sun, 2 Jan 2022 10:11:53 -0500 [thread overview]
Message-ID: <CADwFkm=TrToApvD3gJ0ki8Gc099Z0wfO2NPwsg6x7Ds0=GkUcg@mail.gmail.com> (raw)
In-Reply-To: <20220102125921.CEC93C0DA1A@vcs2.savannah.gnu.org>
Mattias Engdegård <mattiase@acm.org> writes:
> +(defun flymake-tests--gcc-is-clang ()
> + "Whether the `gcc' command actually runs the Clang compiler."
> + (string-match "[Cc]lang version "
> + (shell-command-to-string "gcc --version")))
We have a similar check in test/lisp/cedet/semantic/bovine/gcc.el
(let ((semantic-gcc-test-strings (list (semantic-gcc-query "gcc" "-v"))))
;; Some macOS machines run llvm when you type gcc. (!)
;; We can't even check if it's a symlink; it's a binary placed in
;; "/usr/bin/gcc". So check the output and just skip this test if
;; it looks like that's the case.
(unless (string-match "Apple \\(LLVM\\|clang\\)\\|Xcode\\.app"
(car semantic-gcc-test-strings))
...))
Should these tests perhaps be consolidated somehow?
next parent reply other threads:[~2022-01-02 15:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <164112836156.3693.5253778017552372948@vcs2.savannah.gnu.org>
[not found] ` <20220102125921.CEC93C0DA1A@vcs2.savannah.gnu.org>
2022-01-02 15:11 ` Stefan Kangas [this message]
2022-01-02 16:30 ` master b2167d9843: Don't fail flymake-tests if `gcc` actually is Clang Mattias Engdegård
2022-01-02 16:46 ` Stefan Kangas
2022-01-02 18:34 ` Stefan Kangas
2022-01-02 18:12 ` Eli Zaretskii
2022-01-02 19:04 ` Stefan Monnier
2022-01-02 19:42 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=TrToApvD3gJ0ki8Gc099Z0wfO2NPwsg6x7Ds0=GkUcg@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).