Re: master b2167d9843: Don't fail flymake-tests if `gcc` actually is Clang

[Stefan Kangas <stefankangas@gmail.com>]

Mattias Engdegård <mattiase@acm.org> writes:

> +(defun flymake-tests--gcc-is-clang ()
> +  "Whether the `gcc' command actually runs the Clang compiler."
> +  (string-match "[Cc]lang version "
> +                (shell-command-to-string "gcc --version")))

We have a similar check in test/lisp/cedet/semantic/bovine/gcc.el

  (let ((semantic-gcc-test-strings (list (semantic-gcc-query "gcc" "-v"))))
    ;; Some macOS machines run llvm when you type gcc.  (!)
    ;; We can't even check if it's a symlink; it's a binary placed in
    ;; "/usr/bin/gcc".  So check the output and just skip this test if
    ;; it looks like that's the case.
    (unless (string-match "Apple \\(LLVM\\|clang\\)\\|Xcode\\.app"
                          (car semantic-gcc-test-strings))
        ...))

Should these tests perhaps be consolidated somehow?