From: Stefan Kangas <stefankangas@gmail.com>
To: Po Lu <luangruo@yahoo.com>, emacs-devel@gnu.org
Subject: Re: emacs-28 64ea1a1: Fix eshell for systems that do not have subprocesses
Date: Sun, 12 Dec 2021 00:17:52 -0800 [thread overview]
Message-ID: <CADwFkm=TY=c52SvqL-OnOWiAGnBvoWnuN2h=hi8nnOmOncnVxQ@mail.gmail.com> (raw)
In-Reply-To: <20211212075136.10D6020A0A@vcs0.savannah.gnu.org>
luangruo--- via Mailing list for Emacs changes <emacs-diffs@gnu.org>
writes:
> branch: emacs-28
> commit 64ea1a178c6cb3a436eeb6783237bd603be4f5e4
> Author: Po Lu <luangruo@yahoo.com>
> Commit: Po Lu <luangruo@yahoo.com>
>
> Fix eshell for systems that do not have subprocesses
>
> * lisp/eshell/esh-cmd.el (eshell-eval-command): Use
> `eshell-processp' instead of `processp'.
> ---
> lisp/eshell/esh-cmd.el | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/eshell/esh-cmd.el b/lisp/eshell/esh-cmd.el
> index a2464ad..213b7ab 100644
> --- a/lisp/eshell/esh-cmd.el
> +++ b/lisp/eshell/esh-cmd.el
> @@ -945,12 +945,12 @@ at the moment are:
> ;; In that case, unwrap the value before checking the delimiter
> ;; value.
> (if (and val
> - (not (processp val))
> + (not (eshell-processp val))
> (not (eq val t)))
> (error "Unmatched delimiter: %S" val)
> ;; Eshell-command expect a list like (<process>) to know if the
> ;; command should be async or not.
> - (or (and (processp val) delim) val)))))
> + (or (and (eshell-processp val) delim) val)))))
>
> (defun eshell-resume-command (proc status)
> "Resume the current command when a process ends."
Is this relevant only to MS-DOS? If yes, should we add a comment to
that effect to `eshell-processp'?
next parent reply other threads:[~2021-12-12 8:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211212075134.13255.37107@vcs0.savannah.gnu.org>
[not found] ` <20211212075136.10D6020A0A@vcs0.savannah.gnu.org>
2021-12-12 8:17 ` Stefan Kangas [this message]
2021-12-12 9:33 ` emacs-28 64ea1a1: Fix eshell for systems that do not have subprocesses Po Lu
2021-12-12 10:07 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=TY=c52SvqL-OnOWiAGnBvoWnuN2h=hi8nnOmOncnVxQ@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).