unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Philip Kaludercic <philipk@posteo.net>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
Subject: Re: Adding a "quick-help" menu
Date: Mon, 17 Oct 2022 05:10:25 +0000	[thread overview]
Message-ID: <CADwFkm=D9ykby---dsZVX7M4mPWEUbGCv_XZQ46bSFv8FpvY8g@mail.gmail.com> (raw)
In-Reply-To: <87fsgnfzb2.fsf@posteo.net>

Philip Kaludercic <philipk@posteo.net> writes:

>> - I think we should use `help-for-help-header' for the headlines, not
>>   capitalize them, and align them with :align-to.
>
> That can be done.

I note that you did not use the `help-for-help-header' face for the
headlines.  They are also manually aligned, not with :align-to.

I tried with this naive patch, which means that alignment is off, but
the results look promising to me:

diff --git a/lisp/help.el b/lisp/help.el
index 1cfd044db8..3979d772bc 100644
--- a/lisp/help.el
+++ b/lisp/help.el
@@ -197,7 +197,7 @@ help-quick
                         (concat
                          (car section)
                          (make-string (- width (length (car section))) ?\s))
-                        'face 'bold)
+                        'face 'help-for-help-header)
                       ,@(mapcar (lambda (ent)
                                   (format fmt
                                           (propertize

In any case, I don't think using the face `bold' is best here, as that
makes this hard to customize.  I'd prefer a proper defface (whether it
inherits from `help-for-help-header' by default or not).



  parent reply	other threads:[~2022-10-17  5:10 UTC|newest]

Thread overview: 95+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-16 15:43 Adding a "quick-help" menu Philip Kaludercic
2022-09-16 16:11 ` Sean Whitton
2022-09-16 16:24 ` Stefan Kangas
2022-09-16 16:48   ` Philip Kaludercic
2022-09-16 17:03     ` Sławomir Grochowski
2022-09-16 17:22       ` Philip Kaludercic
2022-09-17 12:09         ` Gregor Zattler
2022-09-17 14:44           ` Philip Kaludercic
2022-09-17 17:48             ` Stefan Kangas
2022-09-17 21:45               ` Philip Kaludercic
2022-09-18  0:05                 ` Stefan Kangas
2022-09-18  5:41                   ` Eli Zaretskii
2022-09-18  9:10                   ` Philip Kaludercic
2022-09-18  5:07             ` Visuwesh
2022-09-18  7:51             ` Gregor Zattler
2022-09-17 14:53           ` which-key (was: Adding a "quick-help" menu) Stefan Monnier
2022-09-18  5:12             ` which-key Visuwesh
2022-09-18  8:56               ` which-key Gregory Heytings
2022-09-18  8:58             ` which-key (was: Adding a "quick-help" menu) Gregory Heytings
2022-09-18  9:19               ` which-key Po Lu
2022-09-18  9:53                 ` which-key Gregory Heytings
2022-09-18 10:10                   ` which-key Lars Ingebrigtsen
2022-09-18 13:51                     ` which-key Stefan Monnier
2022-09-18 15:39                       ` which-key Stefan Kangas
2022-09-18 16:43                         ` which-key Gregor Zattler
2022-09-18 16:49                       ` which-key Gregory Heytings
2022-09-19  8:08                         ` which-key Lars Ingebrigtsen
2022-09-19  8:19                           ` which-key Gregory Heytings
2022-09-19 13:26                             ` which-key Corwin Brust
2022-09-19 23:43                               ` which-key Emanuel Berg
2022-09-19  8:06                       ` which-key Lars Ingebrigtsen
2022-09-19  9:08                         ` which-key Stefan Kangas
2022-09-18 11:09                   ` which-key Po Lu
2022-09-17 16:47           ` [External] : Re: Adding a "quick-help" menu Drew Adams
2022-09-16 17:11     ` Stefan Kangas
2022-09-16 17:29       ` Philip Kaludercic
2022-09-16 17:38         ` [External] : " Drew Adams
2022-09-16 17:36       ` Drew Adams
2022-09-16 18:00       ` Stefan Monnier
2022-09-17  1:56       ` Po Lu
2022-09-16 21:03 ` Philip Kaludercic
2022-09-17 14:53   ` Philip Kaludercic
2022-09-17  1:54 ` Po Lu
2022-09-17  2:51   ` Stefan Kangas
2022-09-17  3:28     ` Stefan Monnier
2022-09-17  4:01       ` Visuwesh
2022-09-17  4:50       ` Po Lu
2022-09-17  4:48     ` Po Lu
2022-09-17  6:38       ` Stefan Kangas
2022-09-17  8:24         ` Po Lu
2022-09-17  8:49   ` Philip Kaludercic
2022-09-17 16:45     ` [External] : " Drew Adams
2022-09-17 17:36       ` Philip Kaludercic
2022-09-18 10:11 ` Lars Ingebrigtsen
2022-09-18 10:53   ` Philip Kaludercic
2022-09-18 17:03     ` Bob Rogers
2022-09-18 17:53       ` Philip Kaludercic
2022-09-18 19:25         ` Bob Rogers
2022-09-18 20:38         ` wilnerthomas--- via Emacs development discussions.
2022-09-18 21:21           ` Philip Kaludercic
2022-09-18 22:45             ` Christopher Dimech
2022-09-18 23:00               ` Philip Kaludercic
2022-09-19  1:40                 ` Christopher Dimech
2022-09-19  7:54     ` Lars Ingebrigtsen
2022-09-19  8:26       ` Po Lu
2022-09-19  9:08         ` Stefan Kangas
2022-09-19  9:08     ` Stefan Kangas
2022-09-19 10:12       ` Philip Kaludercic
2022-10-13 14:30         ` Philip Kaludercic
2022-10-13 19:09           ` Lars Ingebrigtsen
2022-10-13 20:21             ` Philip Kaludercic
2022-10-14 11:03               ` Lars Ingebrigtsen
2022-10-14  7:30             ` Philip Kaludercic
2022-10-14 11:08               ` Lars Ingebrigtsen
2022-10-14 18:10                 ` Philip Kaludercic
2022-10-16  0:29             ` Howard Melman
2022-10-16 16:01               ` Philip Kaludercic
2022-10-16 16:13                 ` Howard Melman
2022-10-16 22:44                   ` Philip Kaludercic
2022-10-17  1:00                     ` Howard Melman
2022-10-17  1:00                     ` [External] : " Drew Adams
2022-10-17  6:17                     ` Eli Zaretskii
2022-10-17  6:29                       ` Philip Kaludercic
2022-10-17  7:00                         ` Eli Zaretskii
2022-10-17  7:12                         ` Stefan Kangas
2022-10-17 15:32                           ` Howard Melman
2022-10-17  5:10         ` Stefan Kangas [this message]
2022-10-17  6:31           ` Philip Kaludercic
2022-10-20  5:58             ` Protesilaos Stavrou
2022-10-20  6:37               ` Eli Zaretskii
2022-10-20 11:27                 ` Philip Kaludercic
2022-10-20 12:51                   ` Eli Zaretskii
2022-10-20 16:37                     ` Philip Kaludercic
2022-10-20 16:39                       ` Eli Zaretskii
2022-09-19 15:21     ` Howard Melman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkm=D9ykby---dsZVX7M4mPWEUbGCv_XZQ46bSFv8FpvY8g@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).