From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: [External] : Re: Consistent face for keys in *Help* and `substitute-command-keys' Date: Tue, 9 Mar 2021 01:38:40 -0600 Message-ID: References: <83zgzsq7xn.fsf@gnu.org> <83v9afriqp.fsf@gnu.org> <83zgzjhvdn.fsf@gnu.org> <83a6rhxwah.fsf@gnu.org> <837dmlxspt.fsf@gnu.org> <834khpxr0s.fsf@gnu.org> <8335x8ybw9.fsf@gnu.org> <87czwageno.fsf@mail.linkov.net> <877dmhwnfu.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000a52c0c05bd15a326" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11511"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , "larsi@gnus.org" , Drew Adams , "emacs-devel@gnu.org" To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 09 08:40:14 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJWyT-0002tC-QK for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Mar 2021 08:40:13 +0100 Original-Received: from localhost ([::1]:56098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJWyS-0002le-St for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Mar 2021 02:40:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJWx4-0002L5-IB for emacs-devel@gnu.org; Tue, 09 Mar 2021 02:38:47 -0500 Original-Received: from mail-pg1-f177.google.com ([209.85.215.177]:35677) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJWx2-00055Z-Ky; Tue, 09 Mar 2021 02:38:46 -0500 Original-Received: by mail-pg1-f177.google.com with SMTP id v14so1268725pgq.2; Mon, 08 Mar 2021 23:38:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=cSxGFq/0gquDLhl4EI2TQNDewGzjGIr+Han1WSMPNUM=; b=XtKfya01MUhnlpynvbJZ/Oo3fYReWtvH4Y5wWssQnBHafyQPFR4Z8u3TkOQKSW8Uv/ b3LbxBUU2DANIv0m/H7db5uDePNk1BR5kwHab5Y+NcQZsncCU56NKbEQqfGdixfhu4gF xoQdqaErfdCyHpweScTPk1+1XlVsT7skLxTUGdmS2IjwYo2BpI8KEU9xEC7X0hcRuPwf A9JAxRtFqlizkdU88HVEC0UwLVkB0fRnyqCivqqEX6xsn93NK0/ZDzR1VBKRr2sMwylI BORUS8USFTmAXocSLweE2+/LjKVSxrXF6kNN2XBq4+8rfR7xFpUzEJPf4NhwONopAgp6 C/Bw== X-Gm-Message-State: AOAM530lrVylUD5cbtK0we3CE1vxI1fwj52VuYBjTHoWP0jgseTP+xTn v/zODIRKDLbzMVrNnKnyVlXih9aOee3A+W38Z7g= X-Google-Smtp-Source: ABdhPJwmu/07bOS+hWi8HpAWVua5gom5S35UrDDLeki6wt/wZkOm1hcinYXzohsuCj3aQlq4bMFq7Q7QeX5qiJ7yakQ= X-Received: by 2002:aa7:8889:0:b029:1ed:f38:4438 with SMTP id z9-20020aa788890000b02901ed0f384438mr24740014pfe.44.1615275521018; Mon, 08 Mar 2021 23:38:41 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 9 Mar 2021 01:38:40 -0600 In-Reply-To: <877dmhwnfu.fsf@mail.linkov.net> Received-SPF: pass client-ip=209.85.215.177; envelope-from=stefankangas@gmail.com; helo=mail-pg1-f177.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266230 Archived-At: --000000000000a52c0c05bd15a326 Content-Type: text/plain; charset="UTF-8" Juri Linkov writes: > It would be nice to keep the current face 'help-key-binding' > even after adding links. Yes, as it happens that is exactly what I'm currently experimenting with. See the attached patch if you want to try it out; I think the effect is quite nice. But I'm seeing bootstrap problems if I flip the new option here to t, so we couldn't use it as the default in its current form. [The problem is that the button type `help-function' is defined in help-mode.el, but that file is not autoloaded (and help.el is). There are several ways to fix it, but I haven't yet had time to think about which is better. (For example, we could force the option to nil during bootstrap. Or we could just move the button definitions into its own file or into help.el to make sure they are there during bootstrap.) ] --000000000000a52c0c05bd15a326 Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Add-new-option-help-link-key-to-documentation.patch" Content-Disposition: attachment; filename="0001-Add-new-option-help-link-key-to-documentation.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: e8718a865fe6fbe1_0.1 RnJvbSA5MzdlMmVkOWQ3YjVhMWE0M2YxOTljODM0MmVkOWVlMmFhYTdjYWM4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogRnJpLCA1IE1hciAyMDIxIDAyOjQ5OjA3ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gQWRkIG5l dyBvcHRpb24gaGVscC1saW5rLWtleS10by1kb2N1bWVudGF0aW9uCgoqIGxpc3AvaGVscC5lbCAo aGVscC1saW5rLWtleS10by1kb2N1bWVudGF0aW9uKTogTmV3IG9wdGlvbi4KKHN1YnN0aXR1dGUt Y29tbWFuZC1rZXlzKTogQWRkIGxpbmsgZnJvbSBrZXlzIHRvIHRoZSBjb21tYW5kIHRoZXkKYXJl IGJvdW5kIHRvIGlmIGFib3ZlIG5ldyBvcHRpb24gaXMgbm9uLW5pbC4gIChCdWcjODk1MSkKKiBl dGMvTkVXUzogQW5ub3VuY2UgdGhlIG5ldyBvcHRpb24uCi0tLQogZXRjL05FV1MgICAgICAgICAg fCAgNyArKysrKysrCiBsaXNwL2hlbHAtbW9kZS5lbCB8ICA3ICsrKysrKysKIGxpc3AvaGVscC5l bCAgICAgIHwgMTQgKysrKysrKysrKysrKy0KIDMgZmlsZXMgY2hhbmdlZCwgMjcgaW5zZXJ0aW9u cygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5k ZXggY2UzMzdlNzUxNy4uNGMzZjI0MThhMyAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRj L05FV1MKQEAgLTkyOCw2ICs5MjgsMTMgQEAgYmUgYXNzdW1lZCB0byBiZSBhIHByb3BlcnRpemVk IHN0cmluZy4KIE5vdGUgdGhhdCB0aGUgbmV3IGZhY2Ugd2lsbCBhbHNvIGJlIHVzZWQgaW4gdG9v bHRpcHMuICBXaGVuIHVzaW5nIHRoZQogR1RLIHRvb2xraXQsIHRoaXMgaXMgb25seSB0cnVlIGlm ICd4LWd0ay11c2Utc3lzdGVtLXRvb2x0aXBzJyBpcyB0LgogCistLS0KKyoqKiBOZXcgdXNlciBv cHRpb24gYGhlbHAtbGluay1rZXktdG8tZG9jdW1lbnRhdGlvbicuCitXaGVuIHRoaXMgb3B0aW9u IGlzIG5vbi1uaWwsIGtleSBiaW5kaW5ncyBkaXNwbGF5ZWQgaW4gdGhlICpIZWxwKgorYnVmZmVy IHdpbGwgYmUgbGlua2VkIHRvIHRoZSBkb2N1bWVudGF0aW9uIGZvciB0aGUgY29tbWFuZCB0aGV5 IGFyZQorYm91bmQgdG8uICBOb3RlIHRoYXQgdGhpcyBkb2VzIG5vdCBhZmZlY3QgbGlzdGluZ3Mg b2Yga2V5IGJpbmRpbmdzIGFuZAorZnVuY3Rpb25zLgorCiAtLS0KICoqKiAnZycgKCdyZXZlcnQt YnVmZmVyJykgaW4gJ2hlbHAtbW9kZScgbm8gbG9uZ2VyIHJlcXVpcmVzIGNvbmZpcm1hdGlvbi4K IApkaWZmIC0tZ2l0IGEvbGlzcC9oZWxwLW1vZGUuZWwgYi9saXNwL2hlbHAtbW9kZS5lbAppbmRl eCBjN2VhYWU1ZmViLi43NjkxMDAyZjdmIDEwMDY0NAotLS0gYS9saXNwL2hlbHAtbW9kZS5lbAor KysgYi9saXNwL2hlbHAtbW9kZS5lbApAQCAtMzIxLDYgKzMyMSwxMyBAQCAnaGVscC1uZXdzCiAg ICAgKHZpZXctYnVmZmVyLW90aGVyLXdpbmRvdyAoZmluZC1maWxlLW5vc2VsZWN0IGZpbGUpKQog ICAgIChnb3RvLWNoYXIgcG9zKSkKICAgJ2hlbHAtZWNobyAocHVyZWNvcHkgIm1vdXNlLTIsIFJF VDogc2hvdyBjb3JyZXNwb25kaW5nIE5FV1MgYW5ub3VuY2VtZW50IikpCisKKzs7OyMjI2F1dG9s b2FkCisoZGVmdW4gaGVscC1tb2RlLS1hZGQtZnVuY3Rpb24tbGluayAoc3RyIGZ1bikKKyAgKG1h a2UtdGV4dC1idXR0b24gKGNvcHktc2VxdWVuY2Ugc3RyKSBuaWwKKyAgICAgICAgICAgICAgICAg ICAgJ3R5cGUgJ2hlbHAtZnVuY3Rpb24KKyAgICAgICAgICAgICAgICAgICAgJ2hlbHAtYXJncyAo bGlzdCBmdW4pKSkKKwogDAogKGRlZnZhciBib29rbWFyay1tYWtlLXJlY29yZC1mdW5jdGlvbikK IApkaWZmIC0tZ2l0IGEvbGlzcC9oZWxwLmVsIGIvbGlzcC9oZWxwLmVsCmluZGV4IDk0MDczZTU3 MzAuLmNjNjI0ZDU3MzcgMTAwNjQ0Ci0tLSBhL2xpc3AvaGVscC5lbAorKysgYi9saXNwL2hlbHAu ZWwKQEAgLTk3OCw2ICs5NzgsMTQgQEAgbG9va3VwLW1pbm9yLW1vZGUtZnJvbS1pbmRpY2F0b3IK ICAgICByZXN1bHQpKQogCiAMCisoZGVmY3VzdG9tIGhlbHAtbGluay1rZXktdG8tZG9jdW1lbnRh dGlvbiBuaWwKKyAgIk5vbi1uaWwgbWVhbnMgdG8gbGluayBrZXlzIHRvIHRoZWlyIGNvbW1hbmQg aW4gKkhlbHAqIGJ1ZmZlcnMuCitUaGlzIGFmZmVjdHMgXFxcXD1cXFtjb21tYW5kXSBzdWJzdGl0 dXRpb25zIGluIGRvY3VtZW50YXRpb24KK3N0cmluZ3MgZG9uZSBieSBgc3Vic3RpdHV0ZS1jb21t YW5kLWtleXMnLiAgIgorICA6dHlwZSAnYm9vbGVhbgorICA6dmVyc2lvbiAiMjguMSIKKyAgOmdy b3VwICdoZWxwKQorCiAoZGVmdW4gc3Vic3RpdHV0ZS1jb21tYW5kLWtleXMgKHN0cmluZykKICAg IlN1YnN0aXR1dGUga2V5IGRlc2NyaXB0aW9ucyBmb3IgY29tbWFuZCBuYW1lcyBpbiBTVFJJTkcu CiBFYWNoIHN1YnN0cmluZyBvZiB0aGUgZm9ybSBcXFxcPVtDT01NQU5EXSBpcyByZXBsYWNlZCBi eSBlaXRoZXIgYQpAQCAtMTA2NSw3ICsxMDczLDExIEBAIHN1YnN0aXR1dGUtY29tbWFuZC1rZXlz CiAgICAgICAgICAgICAgICAgICAgICAgICAoZGVsZXRlLWNoYXIgMSkpCiAgICAgICAgICAgICAg ICAgICAgIDs7IEZ1bmN0aW9uIGlzIG9uIGEga2V5LgogICAgICAgICAgICAgICAgICAgICAoZGVs ZXRlLWNoYXIgKC0gZW5kLXBvaW50IChwb2ludCkpKQotICAgICAgICAgICAgICAgICAgICAoaW5z ZXJ0IChoZWxwLS1rZXktZGVzY3JpcHRpb24tZm9udGlmaWVkIGtleSkpKSkpCisgICAgICAgICAg ICAgICAgICAgIChsZXQgKChrZXkgKGhlbHAtLWtleS1kZXNjcmlwdGlvbi1mb250aWZpZWQga2V5 KSkpCisgICAgICAgICAgICAgICAgICAgICAgKGluc2VydCAoaWYgKGFuZCBoZWxwLWxpbmsta2V5 LXRvLWRvY3VtZW50YXRpb24KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IChmdW5jdGlvbnAgZnVuKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoaGVs cC1tb2RlLS1hZGQtZnVuY3Rpb24tbGluayBrZXkgZnVuKQorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBrZXkpKSkpKSkKICAgICAgICAgICAgICAgIDs7IDFELiBce2Zvb30gaXMgcmVw bGFjZWQgd2l0aCBhIHN1bW1hcnkgb2YgdGhlIGtleW1hcAogICAgICAgICAgICAgICAgOzsgICAg ICAgICAgICAoc3ltYm9sLXZhbHVlIGZvbykuCiAgICAgICAgICAgICAgICA7OyAgICAgXDxmb28+ IGp1c3Qgc2V0cyB0aGUga2V5bWFwIHVzZWQgZm9yIFxbY21kXS4KLS0gCjIuMzAuMQoK --000000000000a52c0c05bd15a326--