From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/rainbow-delimiters a32b39bdfe: Add license file with GPLv3 Date: Sat, 1 Jan 2022 19:02:30 -0500 Message-ID: References: <164107430330.17202.17260845381664886032@vcs2.savannah.gnu.org> <20220101215824.BB13CC0DEC3@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13462"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 02 01:03:48 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n3oLk-0003MP-6l for ged-emacs-devel@m.gmane-mx.org; Sun, 02 Jan 2022 01:03:48 +0100 Original-Received: from localhost ([::1]:46438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n3oLh-0000zt-Vy for ged-emacs-devel@m.gmane-mx.org; Sat, 01 Jan 2022 19:03:46 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n3oKY-0000JI-H4 for emacs-devel@gnu.org; Sat, 01 Jan 2022 19:02:34 -0500 Original-Received: from mail-pj1-f47.google.com ([209.85.216.47]:33755) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n3oKW-0001Nn-V6 for emacs-devel@gnu.org; Sat, 01 Jan 2022 19:02:34 -0500 Original-Received: by mail-pj1-f47.google.com with SMTP id g11-20020a17090a7d0b00b001b2c12c7273so4519274pjl.0 for ; Sat, 01 Jan 2022 16:02:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to; bh=Mk9wScQnPQtvPYqR5FeH7blppZkhOef8BHd0Q2SAvYU=; b=D5VzfsAwMbaZQBut3tDKlQbZ6ktF1kciUcvmSt/jIwh5OdfNJsvefmETMVqY2qJycY n62A4MJpFwUY4V9reIhPx5SYXlAL9amii1tQ0c+GTnWoYtSyG40l1Ou6l2tPm8G38yOV bM5Lg5CltVaKZHEZPMbW3MZkELui+A82voLVnS1BS7PX/ebMwQyJt2uPUCs5GCmydDEo 7ztBOA3ekMJE/LCVs0exHp52NNKRXTJbywHHDWZnq+FGuLM3a0wh8OoHSY5jNOoVIZo0 SjND/HO7XbfJn16jefjFCgjm8ybrwGxpzVORPuspj7fR9SKJjkp3s/wZ7llOO1qQ5IdD hEFg== X-Gm-Message-State: AOAM5323PYEoCsOhVmQLUpstR2OuusbSdGXsZvUWzQOZ6UGYZ0SU8R8j w3YExwk+bbWIeqkCYkn12Sf93JEW47ruKOs/LHw= X-Google-Smtp-Source: ABdhPJywyNAvr3VPczOBbk6KHGqLIGBS5J1tdSrDjj0NWoMAfhBQ4cAaFZ/vJhwOpx9IYqDP0PEM01IoOIpciKH/av4= X-Received: by 2002:a17:90b:1646:: with SMTP id il6mr49181619pjb.143.1641081751358; Sat, 01 Jan 2022 16:02:31 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 1 Jan 2022 19:02:30 -0500 In-Reply-To: Received-SPF: pass client-ip=209.85.216.47; envelope-from=stefankangas@gmail.com; helo=mail-pj1-f47.google.com X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283838 Archived-At: Stefan Kangas writes: > How about adding the files "LICENSE", "LICENSE.md" and "COPYING" to a > global ignore list instead? (Those three being the variations I have > seen so far.) IOW, how about something like this (untested)? I think there are some other files that we could always exclude as well, like ".dir-locals.el", ".github", "*-tests.el", and ".travis.yml". diff --git a/elpa-admin.el b/elpa-admin.el index b4ad318ef..37b3112dd 100644 --- a/elpa-admin.el +++ b/elpa-admin.el @@ -562,6 +562,10 @@ auxillary files unless TARBALL-ONLY is non-nil ." "######## Build of package %s FAILED!!") tarball))))) +(defvar elpaa--make-tarball-global-ignore + '("COPYING" "LICENSE" "LICENSE.md") + "List of files that will not be included in the tarball.") + (defun elpaa--make-one-tarball-1 ( tarball dir pkg-spec metadata &optional revision-function tarball-only) (elpaa--with-temp-files @@ -572,7 +576,8 @@ auxillary files unless TARBALL-ONLY is non-nil ." (make-directory destdir))) (vers (nth 1 metadata)) (elpaignore (expand-file-name ".elpaignore" dir)) - (ignores (elpaa--spec-get pkg-spec :ignored-files)) + (ignores (append (elpaa--spec-get pkg-spec :ignored-files) + elpaa--make-tarball-global-ignore)) (renames (elpaa--spec-get pkg-spec :renames)) (ldir (elpaa--spec-get pkg-spec :lisp-dir)) (re (concat "\\`" (regexp-quote pkgname)