From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: 2a73673 Change how thread-first/thread-last indent the first argument Date: Wed, 6 Oct 2021 12:27:14 +0200 Message-ID: References: <87ee90vtye.fsf@alphapapa.net> <87czoj7wlk.fsf@gnus.org> <875yubx3rj.fsf@alphapapa.net> <87bl42frku.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2635"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Adam Porter , Emacs developers To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 06 12:31:59 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mY4DO-0000SP-8P for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Oct 2021 12:31:58 +0200 Original-Received: from localhost ([::1]:49702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mY4DM-0004fc-96 for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Oct 2021 06:31:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY497-0000kD-6V for emacs-devel@gnu.org; Wed, 06 Oct 2021 06:27:34 -0400 Original-Received: from mail-pj1-f50.google.com ([209.85.216.50]:36816) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mY491-0007gK-KL for emacs-devel@gnu.org; Wed, 06 Oct 2021 06:27:29 -0400 Original-Received: by mail-pj1-f50.google.com with SMTP id qe4-20020a17090b4f8400b0019f663cfcd1so4145120pjb.1 for ; Wed, 06 Oct 2021 03:27:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vl/xXc1BlJl+BZkorvT4RXMzbFci+i15zYazw2yE+fY=; b=UhN4G/lVgbOl4jfJLwJgxkQwEH+V8gaEnyPUOX1vvc4x0fkFsj85iGp57AEQgkLRn1 oUntN5FR4kfaworvU6i+j0bnEXOpm2OCl9lay9gFzGukDmr74dL4G2z1Fq/4JUiq5MXl OWbG5MCDii79h5ax7vxyp4HqdSQCwLZJuWxTWIKuB+hDSDxp96042Fs3p1KttZgQWAHt Kc05MXkBV37iTMqGXiy2CsIYdBez7BBfUQcgghSBNtdMXakr/684VRf9NQ19HzwMUdo9 gF5i09vedQs22J7ICTUnuz5XFiPAuV6qWS03j+FMnnXiBeqV4RZMot6Zbb5a/gEv41EA PmHg== X-Gm-Message-State: AOAM531z3o8HWn79t3DFwaLtcsb07iQP6ChorgDjqDJIzBvtGrfDUKiS M2pmOiwu7xGgCtbm/5Chm/lmOkT5nLqTsiXxm3Cm49fk X-Google-Smtp-Source: ABdhPJyhT3VULB3QMmv0TT/Hd7dWSfA+fYi2nveISremD3r8cr2JOKibPAyBx9WLgTtpuctseHdFcmKmIT36peSgg5M= X-Received: by 2002:a17:902:6b07:b0:13e:d5ba:3d8f with SMTP id o7-20020a1709026b0700b0013ed5ba3d8fmr10224815plk.32.1633516045988; Wed, 06 Oct 2021 03:27:25 -0700 (PDT) In-Reply-To: <87bl42frku.fsf@gnus.org> Received-SPF: pass client-ip=209.85.216.50; envelope-from=stefankangas@gmail.com; helo=mail-pj1-f50.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276418 Archived-At: Lars Ingebrigtsen writes: > I don't really have much of an opinion here -- but the old indentation > looks like a bug to me. If the thread-first/last community disagrees > with this, I'm open to reverting the patch. Does anybody else have an > opinion here? I don't have a strong opinion, but I'm personally not too concerned about some churn given that "git blame" has an option to ignore whitespace changes. (Magit uses that flag by default, and if I'm not mistaken VC does too.) As for aggressive-indent, it does sound like a somewhat unusual use-case. I only re-indent code specifically when it makes sense. When looking over my diff before committing, I usually double-check to see that I'm not accidentally doing some random re-indenting unless I'm also changing those lines, or otherwise have some specific reason to do it (for example, if it substantially improves readability). Just my two cents.